A comment by David Malcolm in the thread "Trying to build gcc-python-plugin-0.9 on Debian unstable" https://fedorahosted.org/pipermail/gcc-python-plugin/2012-March/000203.html drew my attention to the build system. After looking at it, there are a few tweaks that could be made to simplify maintenance of the Makefile, match typical conventions for variable usage, and so forth. I have some patches pending for this and would like to submit them. My first inclination was to file a ticket. However, it looks like Trac is read-only to anonymous users and does not allow anonymous users to create accounts. Maintainers, how would you prefer to receive these patches? The shortlog for the changes so far is:
Build: use $CC, not $GCC, for convention's sake Build: mark target 'all' as .PHONY Build: use $(CURDIR) instead of shell call. Build: use implicit rules for building generated files. Build: split CPPFLAGS/CFLAGS/LDFLAGS. Build: use $(RM), not explicit "rm -f". Build: reuse Python CFLAGS variable Build: rework tarball target to use .PHONY Build: tarball: disallow empty $(VERSION)
Hi Dave,
On 18.03.2012 23:28, gcc-python-plugin.5.8eaf7cd8e5128d8191fe@spamgourmet.com wrote:
create accounts. Maintainers, how would you prefer to receive these patches?
What about github pull requests ... ? It seems that a github mirror will be convenient for Buke too ...
Kind Regards, Alek
On Sun, 2012-03-18 at 16:28 -0500, gcc-python-plugin.5.8eaf7cd8e5128d8191fe@spamgourmet.com wrote:
A comment by David Malcolm in the thread "Trying to build gcc-python-plugin-0.9 on Debian unstable" https://fedorahosted.org/pipermail/gcc-python-plugin/2012-March/000203.html drew my attention to the build system. After looking at it, there are a few tweaks that could be made to simplify maintenance of the Makefile, match typical conventions for variable usage, and so forth. I have some patches pending for this and would like to submit them. My first
Thanks for looking at this.
inclination was to file a ticket. However, it looks like Trac is read-only to anonymous users and does not allow anonymous users to create accounts. Maintainers, how would you prefer to receive these patches?
The Trac instance is tied to the Fedora project's account system; creating an account is trivial and is described at http://fedoraproject.org/wiki/Account_System/NewAccount
FWIW, I've finally succumbed to the inevitable and created a github account for myself; a clone of the project's git repository can be seen here: https://github.com/davidmalcolm/gcc-python-plugin
So if that's more convenient, go for it.
Hope this is helpful Dave
gcc-python-plugin@lists.fedorahosted.org
-
Alek Paunov -
David Malcolm -
gcc-python-plugin.5.8eaf7cd8e5128d8191fe＠spamgourmet.com