1:11 p.m.
Hello, I starting to use the python plugin today.
In order to build it, I had to 2 two things:
1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
2) to use the plugin, I have to add a LD_PRELOAD=libpython2.7.so
I don't know if that was intended, but maybe it would be nice to add a
hint to the README.
I'm using ubuntu oneiric ocelot 64bit.
Also I got some failures in some tests:
253 successes; 4 failures; 1 skipped
Failed tests:
tests/plugin/gc/_gc_selftest
tests/plugin/gimple-walk-tree/dump-all
tests/plugin/gimple-walk-tree/exceptions
tests/plugin/gimple-walk-tree/find-one
make: *** [test-suite] Error 1
3 of them had the same reason, just some warnings:
--- Expected stderr
+++ Actual stderr
@@ -0,0 +1,3 @@
+tests/plugin/gc/_gc_selftest/input.c: In function 'main':
+tests/plugin/gc/_gc_selftest/input.c:41:9: warning: format '%i'
expects argument of type 'int', but argument 2 has type 'char *'
[-Wformat]
+tests/plugin/gc/_gc_selftest/input.c:41:9: warning: format '%s'
expects a matching 'char *' argument [-Wformat]
1 of them had this reason, with an actual error:
--- Expected stderr
+++ Actual stderr
@@ -1,4 +1,6 @@
tests/plugin/gimple-walk-tree/exceptions/input.c: In function 'main':
+tests/plugin/gimple-walk-tree/exceptions/input.c:41:9: warning:
format '%i' expects argument of type 'int', but argument 2 has type
'char *' [-Wformat]
+tests/plugin/gimple-walk-tree/exceptions/input.c:41:9: warning:
format '%s' expects a matching 'char *' argument [-Wformat]
tests/plugin/gimple-walk-tree/exceptions/input.c:35:1: error:
Unhandled Python exception raised calling 'execute' method
Traceback (most recent call last):
File "tests/plugin/gimple-walk-tree/exceptions/script.py", line 30,
in execute
tests/plugin/gimple-walk-tree/find-one: FAIL
--
Emilio Wuerges
ECL - Embedded Computing Lab
UFSC - Universidade Federal de Santa Catarina
Brasil
2:13 p.m.
On Fri, Feb 3, 2012 at 2:11 PM, Emílio Wuerges <wuerges(a)gmail.com> wrote:
Hello, I starting to use the python plugin today.
In order to build it, I had to 2 two things:
1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
+1
https://fedorahosted.org/pipermail/gcc-python-plugin/2012-January/000167....
David E. Narvaez
2:47 p.m.
On Fri, 2012-02-03 at 15:13 -0500, David Narvaez wrote:
On Fri, Feb 3, 2012 at 2:11 PM, Emílio Wuerges
<wuerges(a)gmail.com> wrote:
>
> Hello, I starting to use the python plugin today.
>
> In order to build it, I had to 2 two things:
>
> 1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
+1
https://fedorahosted.org/pipermail/gcc-python-plugin/2012-January/000167....
Ah, thanks.
For some reason I can't find that email in my inbox (perhaps I got
trigger-happy with the delete key? sorry).
It makes sense to add -fPIC, and I don't think it can hurt; I've added
it in c1433651f0bee9f9e0e568a863f195b5209c435d
[I'm a bit nervous about the python builds that don't supply it
automatically within distutils.sysconfig's CFLAGS configvar; are they
buggy, or have I misunderstood that part of distutils?]
Thanks!
Dave
5:37 p.m.
Thanks for including it!
Btw, I'm planning in submit some a patch adding a call to dominator analysis.
Is there any trick for the copyright? I have no problems with GPL.
The error without -fPIC is:
Stderr:
/usr/bin/ld: /tmp/ccnYvmYr.o: relocation R_X86_64_32 against
`.rodata.str1.1' can not be used when making a shared object;
recompile with -fPIC
/tmp/ccnYvmYr.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
And what I get in my system from python config is this:
$ python-config --cflags
-I/usr/include/python2.7 -I/usr/include/python2.7 -fno-strict-aliasing
-g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
$ python-config --ldflags
-L/usr/lib/python2.7/config -lpthread -ldl -lutil -lm -lpython2.7
-Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
$ python -c "from distutils import sysconfig as sc;
print(sc.get_config_var('CFLAGS'))"
-fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
ew@arrakis:~/gcc-python-plugin/gcc-python-plugin$
Its the default from ubuntu. I've not changed anything.
Hey, I have a question.
How do I create a pass that will run only once after "ira" pass?
Something like an SimpleIpaPass, but after "ira".
Any ideas?
On Fri, Feb 3, 2012 at 6:47 PM, David Malcolm <dmalcolm(a)redhat.com> wrote:
On Fri, 2012-02-03 at 15:13 -0500, David Narvaez wrote:
> On Fri, Feb 3, 2012 at 2:11 PM, Emílio Wuerges <wuerges(a)gmail.com> wrote:
> >
> > Hello, I starting to use the python plugin today.
> >
> > In order to build it, I had to 2 two things:
> >
> > 1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
>
> +1
>
> https://fedorahosted.org/pipermail/gcc-python-plugin/2012-January/000167....
Ah, thanks.
For some reason I can't find that email in my inbox (perhaps I got
trigger-happy with the delete key? sorry).
It makes sense to add -fPIC, and I don't think it can hurt; I've added
it in c1433651f0bee9f9e0e568a863f195b5209c435d
[I'm a bit nervous about the python builds that don't supply it
automatically within distutils.sysconfig's CFLAGS configvar; are they
buggy, or have I misunderstood that part of distutils?]
Thanks!
Dave
_______________________________________________
gcc-python-plugin mailing list
gcc-python-plugin(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/gcc-python-plugin
--
Emilio Wuerges
ECL - Embedded Computing Lab
UFSC - Universidade Federal de Santa Catarina
Brasil
5:48 p.m.
Btw, the test errors I reported as failing are ok now, after a git pull.
On Fri, Feb 3, 2012 at 9:37 PM, Emílio Wuerges <wuerges(a)gmail.com> wrote:
Thanks for including it!
Btw, I'm planning in submit some a patch adding a call to dominator analysis.
Is there any trick for the copyright? I have no problems with GPL.
The error without -fPIC is:
Stderr:
/usr/bin/ld: /tmp/ccnYvmYr.o: relocation R_X86_64_32 against
`.rodata.str1.1' can not be used when making a shared object;
recompile with -fPIC
/tmp/ccnYvmYr.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
And what I get in my system from python config is this:
$ python-config --cflags
-I/usr/include/python2.7 -I/usr/include/python2.7 -fno-strict-aliasing
-g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
$ python-config --ldflags
-L/usr/lib/python2.7/config -lpthread -ldl -lutil -lm -lpython2.7
-Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
$ python -c "from distutils import sysconfig as sc;
> print(sc.get_config_var('CFLAGS'))"
-fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
ew@arrakis:~/gcc-python-plugin/gcc-python-plugin$
Its the default from ubuntu. I've not changed anything.
Hey, I have a question.
How do I create a pass that will run only once after "ira" pass?
Something like an SimpleIpaPass, but after "ira".
Any ideas?
On Fri, Feb 3, 2012 at 6:47 PM, David Malcolm <dmalcolm(a)redhat.com> wrote:
> On Fri, 2012-02-03 at 15:13 -0500, David Narvaez wrote:
>> On Fri, Feb 3, 2012 at 2:11 PM, Emílio Wuerges <wuerges(a)gmail.com> wrote:
>> >
>> > Hello, I starting to use the python plugin today.
>> >
>> > In order to build it, I had to 2 two things:
>> >
>> > 1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
>>
>> +1
>>
>> https://fedorahosted.org/pipermail/gcc-python-plugin/2012-January/000167....
>
> Ah, thanks.
>
> For some reason I can't find that email in my inbox (perhaps I got
> trigger-happy with the delete key? sorry).
>
> It makes sense to add -fPIC, and I don't think it can hurt; I've added
> it in c1433651f0bee9f9e0e568a863f195b5209c435d
>
> [I'm a bit nervous about the python builds that don't supply it
> automatically within distutils.sysconfig's CFLAGS configvar; are they
> buggy, or have I misunderstood that part of distutils?]
>
> Thanks!
> Dave
>
> _______________________________________________
> gcc-python-plugin mailing list
> gcc-python-plugin(a)lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/gcc-python-plugin
--
Emilio Wuerges
ECL - Embedded Computing Lab
UFSC - Universidade Federal de Santa Catarina
Brasil
--
Emilio Wuerges
ECL - Embedded Computing Lab
UFSC - Universidade Federal de Santa Catarina
Brasil
9:29 p.m.
Very helpful.
GCC does like this:
for each function:
for each pass:
do pass on function
but when you add manually a pass like SimpleIpaPass, it works as a
barrier for other passes:
for each pass:
do pass on cgraph
The nicest thing would be to register an SimpleIpaPass after ira.
I've done it inside gcc, but can't figure out how to do it with the
python plugin.
Your suggestion is a nice work-around.
I'll just add a static variable to the callback to check if it is the
first call.
And yeah, I still need the LD_PRELOAD.
But this is not much of a problem.
Btw, try to run and check the funny message:
gcc -fplugin=libpython2.7.so test.c
On Fri, Feb 3, 2012 at 10:36 PM, David Malcolm <dmalcolm(a)redhat.com> wrote:
On Fri, 2012-02-03 at 21:48 -0200, Emílio Wuerges wrote:
> Btw, the test errors I reported as failing are ok now, after a git pull.
Excellent, thanks!
_______________________________________________
gcc-python-plugin mailing list
gcc-python-plugin(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/gcc-python-plugin
--
Emilio Wuerges
ECL - Embedded Computing Lab
UFSC - Universidade Federal de Santa Catarina
Brasil
6:36 p.m.
On Fri, 2012-02-03 at 21:37 -0200, Emílio Wuerges wrote:
Thanks for including it!
Btw, I'm planning in submit some a patch adding a call to dominator analysis.
Sounds interesting.
Is there any trick for the copyright? I have no problems with GPL.
The project doesn't have any copyright assignment requirement: you get
to keep copyright in any contributions you make, though AIUI there's an
implicit licensing of such contributions under the GPLv3 or later, given
that any contribution is a derived work of the plugin, which is itself
licensed under the GPLv3 or later. I'm not a lawyer, though.
The error without -fPIC is:
Stderr:
/usr/bin/ld: /tmp/ccnYvmYr.o: relocation R_X86_64_32 against
`.rodata.str1.1' can not be used when making a shared object;
recompile with -fPIC
/tmp/ccnYvmYr.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
And what I get in my system from python config is this:
$ python-config --cflags
-I/usr/include/python2.7 -I/usr/include/python2.7 -fno-strict-aliasing
-g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
$ python-config --ldflags
-L/usr/lib/python2.7/config -lpthread -ldl -lutil -lm -lpython2.7
-Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
$ python -c "from distutils import sysconfig as sc;
> print(sc.get_config_var('CFLAGS'))"
-fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
ew@arrakis:~/gcc-python-plugin/gcc-python-plugin$
Its the default from ubuntu. I've not changed anything.
Thanks for the
information. It looks to me like those defaults are
broken: both the --cflags and CFLAGS ought to contain '-fPIC'
themselves. I'd argue that this is a bug in Ubuntu's python builds, but
in any case, we have the workaround for the missing -fPIC in our
Makefile now.
Do you still need to add the LD_PRELOAD thing you mentioned earlier? It
might be missing a "-shared" in the ldflags.
Hey, I have a question.
How do I create a pass that will run only once after "ira" pass?
Something like an SimpleIpaPass, but after "ira".
Any ideas?
When planning a new pass, I normally look at the "subway map"
here:
http://gcc-python-plugin.readthedocs.org/en/latest/tables-of-passes.html
I see there that "ira" pass happens during the "rest_of_compilation"
activities after the code is in RTL form.
My understanding is that all of those RTL passes are being done
per-function, rather than globally.
I'm not yet sure whether GCC does its passes like this:
for each function:
for each pass:
do pass on function
or like this:
for each pass:
for each function:
do pass on function
[Any gcc experts around?]
My reading of gcc/passes.c:execute_one_pass is that the work of each
pass is done via various do_per_function() calls. Looking there it
seems that rather than a gcc.Pass you could wire up a callback to the
gcc.PLUGIN_PASS_EXECUTION event. This is is called immediately before a
pass begins, so to hook in after "ira", perhaps your callback could take
action on the next pass, which seems to be "*all-postreload".
Alternatively, you could create a gcc.RtlPass that runs after the "ira"
pass, but only have it do anything the first time it's called.
Hope this is helpful
Dave
2:41 p.m.
On Fri, 2012-02-03 at 17:11 -0200, Emílio Wuerges wrote:
Hello, I starting to use the python plugin today.
Hi!
In order to build it, I had to 2 two things:
1) add -fPIC to testcpybuilder.py compile flags. (in the patch)
BTW, what was the
failure?
IIRC, someone emailed me off-list a while back about a similar-sounding
issue, but I can't find the details right now.
2) to use the plugin, I have to add a LD_PRELOAD=libpython2.7.so
I don't know if that was intended, but maybe it would be nice to add a
hint to the README.
That's odd, and unexpected. It's reminiscent of the
problems that
Vinay was reporting here:
https://fedorahosted.org/pipermail/gcc-python-plugin/2011-September/00006...
I'm using ubuntu oneiric ocelot 64bit.
What's the output of the following two commands on your system?
python-config --cflags
python-config --ldflags
python -c "from distutils import sysconfig as sc;
print(sc.get_config_var('CFLAGS'))"
(for reference, on my system:
$ python-config --cflags
-I/usr/include/python2.7 -I/usr/include/python2.7 -fno-strict-aliasing
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC
-fwrapv
$ python-config --ldflags
-lpthread -ldl -lutil -lm -lpython2.7 -Xlinker -export-dynamic
$ python -c "from distutils import sysconfig as sc;
print(sc.get_config_var('CFLAGS'))"
-fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64
-mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC
-fwrapv
Also I got some failures in some tests:
253 successes; 4 failures; 1 skipped
Failed tests:
tests/plugin/gc/_gc_selftest
tests/plugin/gimple-walk-tree/dump-all
tests/plugin/gimple-walk-tree/exceptions
tests/plugin/gimple-walk-tree/find-one
make: *** [test-suite] Error 1
Thanks: it looks I messed up some of the test code, and the problems
show up when compiling with -Wformat.
These should be fixed as of 6ef592d9e473eea205b1fad866bebcac40943006
4467
days inactive
4468
days old
gcc-python-plugin@lists.fedorahosted.org
8 comments
3 participants
participants (3)
-
David Malcolm -
David Narvaez -
Emílio Wuerges