I would personally go with the 2 and get closer to the upstream. I agree with the npm analogy that was made in the conversation.

Furthermore, I don't think that most users, working on Go projects on Fedora, would even know that we provide different Go envars

to the upstream ones. IMO, they would change them to upstream values for the benefit of cloning speed, if they knew about them.

Solution 3 and 4 are far too complex for the given value they provide.

If you decide to keep the envars as they are now, I would also agree with having the original values commented.

On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa <ngompa13@gmail.com> wrote:

On Tue, Dec 19, 2023 at 4:14 PM Brad Smith <bradley.g.smith@gmail.com> wrote:
>
> At a minimum, I recommend that the patch include the original values
> for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it
> easier to change back to default values. At the moment, one has to
> visit the relevant web pages.
>
> I lean towards providing upstream defaults in this case with updated
> content on the developer portal (and elsewhere?) with information on
> why changing these values would be useful. I agree that the comments
> in the thread are persuasive (for me).
>

I agree with this. I'd rather keep the patch than revert to upstream defaults.

--
真実はいつも一つ！/ Always, there's only one truth!
--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

Ondřej Pohořelský

Software Engineer

Red Hat

opohorel@redhat.com