[gssapi/gssproxy] c2484e: Add a hidden debug tool to gssproxy
by Simo Sorce
Branch: refs/heads/main
Home: https://github.com/gssapi/gssproxy
Commit: c2484eed03b97962be86ab1aa7d7bd182e1bdcc9
https://github.com/gssapi/gssproxy/commit/c2484eed03b97962be86ab1aa7d7bd1...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-10 (Thu, 10 Sep 2020)
Changed paths:
M Makefile.am
A src/extract_ccache.c
M src/gp_common.h
M src/gp_export.c
M src/gp_proxy.h
M src/gssproxy.c
M src/mechglue/gpp_creds.c
Log Message:
-----------
Add a hidden debug tool to gssproxy
Sometimes it is really valuable to be able to extract the ccaches that a
client may be storing encrypted.
This special tool allows that and can be used as follow:
KRB5_KTNAME=/path/to/service.keytab ./gssproxy -d --extract-ccache /path/to/encrypted.ccache --into-ccache ~/decryptedccache
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
3 years, 7 months
[gssapi/gssproxy] 0cef2b: Silence gcc on truncation of debug messages
by Simo Sorce
Branch: refs/heads/main
Home: https://github.com/gssapi/gssproxy
Commit: 0cef2b5bbc7c1f4e4ad7a1b5cb727e1e00988d9e
https://github.com/gssapi/gssproxy/commit/0cef2b5bbc7c1f4e4ad7a1b5cb727e1...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M tests/t_utils.h
Log Message:
-----------
Silence gcc on truncation of debug messages
Also improve the DEBUG by reporting that messages were truncated.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: fe52166eceb02907ee4ea2b3bf6fb18dce295b29
https://github.com/gssapi/gssproxy/commit/fe52166eceb02907ee4ea2b3bf6fb18...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/gp_creds.c
Log Message:
-----------
Work around incorrect gcc restrict warning on asprintf
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: edit commit message]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: 182983129c1cbd312b04202480e81652159b34ff
https://github.com/gssapi/gssproxy/commit/182983129c1cbd312b04202480e8165...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/gssproxy.c
M tests/runtests.py
M tests/t_impersonate.py
M tests/t_multi_key.py
M tests/t_program.py
M tests/t_reloading.py
M tests/testlib.py
Log Message:
-----------
Add testlib method to wait for gssproxy reconfiguration
Add a more robust method to wait until gssproxy has reconfigured. This
should work better when tests ar run on slow machines or through tools
like valgrind which can considerably slow down the tooling.
Also increase timeouts to 30 seconds for said slower machines.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: commit message tweaks]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: a3f13b30ef3c90ff7344c3913f6e26e55b82451f
https://github.com/gssapi/gssproxy/commit/a3f13b30ef3c90ff7344c3913f6e26e...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/client/gpm_accept_sec_context.c
M src/client/gpm_common.c
M src/client/gpm_indicate_mechs.c
M src/client/gpm_init_sec_context.c
M src/client/gssapi_gpm.h
M src/mechglue/gss_plugin.c
Log Message:
-----------
Expand use of global static mechs to conform to SPI
GSSAPI requires some specific APIs to return "static" OIDs that the user
does not have to free. The krb5 mechglue in fact requires mechanisms to
also honor this or the mech oid will be irretrievably leaked in some
cases.
To accomodate this, expand use of global mechs structure we already
allocate for the gss_inidicate_mechs case so we can return "static" OIDs
from calls like ISC and ASC.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: commit message fixups]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: 447d5352c2a81e219ccf04348a87b2ff25b7de15
https://github.com/gssapi/gssproxy/commit/447d5352c2a81e219ccf04348a87b2f...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/mechglue/gss_plugin.c
Log Message:
-----------
Initialize interposed mech list without allocation
While we had already fixed the leak here in main, the code performed
unnecessary extra work, so just replacethe whole lot with a function
that does not do any extra allocation or copy.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: commit message]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: e6811347c23b6c62d9f1869da089ab9900f97a84
https://github.com/gssapi/gssproxy/commit/e6811347c23b6c62d9f1869da089ab9...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/client/gpm_release_handle.c
Log Message:
-----------
Make sure to free also the remote ctx struct
The xdr_free() call only frees the contents and not the containing
structure itself.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: a2ffd1230fd572d7fa9099af2365dfb7ac394d07
https://github.com/gssapi/gssproxy/commit/a2ffd1230fd572d7fa9099af2365dfb...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/mechglue/gpp_creds.c
M src/mechglue/gpp_init_sec_context.c
Log Message:
-----------
Use the correct function to free unused creds
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: dc56c86f1dcb1ae4dbc35facf5f50fb21c9d5049
https://github.com/gssapi/gssproxy/commit/dc56c86f1dcb1ae4dbc35facf5f50fb...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M tests/interposetest.c
M tests/t_impersonate.c
M tests/t_init.c
M tests/t_setcredopt.c
Log Message:
-----------
Fix leaks in our test suite itself
These are mostly laziness in freeing since the programs are short-lived.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: rewrote commit message]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: fe9e3c29caab90daf19028fb31ff28622d8708a9
https://github.com/gssapi/gssproxy/commit/fe9e3c29caab90daf19028fb31ff286...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/gp_export.c
Log Message:
-----------
Always free ciphertext data in gp_encrypt_buffer
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: rewrote commit message]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: 6ea8391257e687dfb3981b634c06cf7a55008eb0
https://github.com/gssapi/gssproxy/commit/6ea8391257e687dfb3981b634c06cf7...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/client/gpm_import_and_canon_name.c
M src/client/gpm_indicate_mechs.c
M src/client/gssapi_gpm.h
Log Message:
-----------
Return static oids for naming functions
gss_display_name and gss_inquire_name reteurn "static" oids, that are
generally not freed by callers, so make sure to match and return actual
static OIDs exported by GSSAPI.
Also remove gpm_equal_oids() and use the library provided gss_oid_equal
function instead.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: c0561c078bc22b9523ac25f515ad85b735c26a92
https://github.com/gssapi/gssproxy/commit/c0561c078bc22b9523ac25f515ad85b...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/client/gpm_indicate_mechs.c
Log Message:
-----------
Avoid unnecessary allocation in gpm_inquire_mechs_for_name()
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: clarified commit message]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Commit: 502e448b3b126bf828ed871496dd7520d5075564
https://github.com/gssapi/gssproxy/commit/502e448b3b126bf828ed871496dd752...
Author: Simo Sorce <simo(a)redhat.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/client/gpm_inquire_context.c
Log Message:
-----------
Use static OIDs in gss_inquire_context()
As per other functions gssapi expect a static OID here.
Signed-off-by: Simo Sorce <simo(a)redhat.com>
[rharwood(a)redhat.com: commit message fixup]
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Compare: https://github.com/gssapi/gssproxy/compare/99e42633bd56...502e448b3b12
3 years, 7 months