https://bugzilla.redhat.com/show_bug.cgi?id=715482
Ben Boeckel <fedora(a)me.benboeckel.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Assignee|fedora(a)me.benboeckel.net |petersen(a)redhat.com
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715482
https://bugzilla.redhat.com/show_bug.cgi?id=2262767
--- Comment #5 from Jens Petersen <petersen(a)redhat.com> ---
(In reply to Jens Petersen from comment #4)
> Thanks, overall looks fine to me.
>
> The package complies with the packaging guidelines, builds and installs.
> Spec file is generated with cabal-rpm.
>
> However the license file is MIT, but many of the source files say ISC
> (except .cabal).
> Could you confirm the license with the upstream maintainer, please?
> (I know ISC and MIT are quite similar but we need to be precise in Fedora:
> in the worst case we could possibly go with "MIT AND ISC" as workaround but
> that feels wrong:
> maybe ISC is more correct actually here by the looks of it.)
Indeed: https://github.com/glguy/config-value/issues/13
So either add a link to this issue above the corrected License field,
or update to the newer release if that comes out first and is compatible.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262767
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262772
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
URL|https://hackage.haskell.org |https://hackage.haskell.org
|/package/%{pkg_name} |/package/zenc
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> ---
Looks fine to me
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm.
License is BSD3.
Package APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262772
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262771
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
Flags| |fedora-review+
URL|https://hackage.haskell.org |https://hackage.haskell.org
|/package/%{pkg_name} |/package/versions
Status|NEW |POST
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> ---
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and looks fine to me.
License is BSD3.
You can try turning on the testsuite.
Package APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262771
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262770
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|https://hackage.haskell.org |https://hackage.haskell.org
|/package/%{pkg_name} |/package/s-cargot
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
Flags| |fedora-review+
Status|NEW |POST
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> ---
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and LGTM.
License is BSD3.
You could try enabling the testsuite.
Package APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262770
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262769
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Flags| |fedora-review+
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
--- Comment #2 from Jens Petersen <petersen(a)redhat.com> ---
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and LGTM.
License is MIT.
Package APPROVED
If you wish you could probably enable the testsuite for this package.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262769
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262768
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|https://hackage.haskell.org |https://hackage.haskell.org
|/package/%{pkg_name} |/package/deriving-compat
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
Flags| |fedora-review+
Status|NEW |POST
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> ---
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm.
License is BSD3.
Package APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262768
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262767
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
--- Comment #4 from Jens Petersen <petersen(a)redhat.com> ---
Thanks, overall looks fine to me.
The package complies with the packaging guidelines, builds and installs.
Spec file is generated with cabal-rpm.
However the license file is MIT, but many of the source files say ISC (except
.cabal).
Could you confirm the license with the upstream maintainer, please?
(I know ISC and MIT are quite similar but we need to be precise in Fedora:
in the worst case we could possibly go with "MIT AND ISC" as workaround but
that feels wrong:
maybe ISC is more correct actually here by the looks of it.)
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262767
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…
https://bugzilla.redhat.com/show_bug.cgi?id=2262758
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |petersen(a)redhat.com
Status|NEW |POST
Flags| |fedora-review+
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> ---
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm.
License is BSD3.
Package APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262758
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-sp…