Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request : ghc-mwc-random - Pseudo random number generation library for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Summary: Review Request : ghc-mwc-random - Pseudo random number generation library for Haskell Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lakshminaras2002@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-haskell-list@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec file: http://narasim.fedorapeople.org/package_reviews/ghc-mwc-random.spec
SRPM link : http://narasim.fedorapeople.org/package_reviews/ghc-mwc-random-0.10.0.1-1.fc...
rpmlint -i *.rpm ghc-mwc-random.spec ghc-mwc-random.src: W: spelling-error %description -l en_US mersenne -> Mennen The value of this tag appears to be misspelled. Please double-check.
ghc-mwc-random.x86_64: W: spelling-error %description -l en_US mersenne -> Mennen The value of this tag appears to be misspelled. Please double-check.
ghc-mwc-random-devel.x86_64: W: spelling-error %description -l en_US mersenne -> Mennen The value of this tag appears to be misspelled. Please double-check.
3 packages and 1 specfiles checked; 0 errors, 3 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |Ready
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |736577(ghc-snap-core)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
--- Comment #1 from Jens Petersen petersen@redhat.com 2011-11-20 23:42:38 EST --- I think it is better not to indent the description.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3528845
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |petersen@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request : |Review Request: |ghc-mwc-random - Pseudo |ghc-mwc-random - Pseudo |random number generation |random number generation |library for Haskell |library for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-mwc-random
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|Ready | Flag|fedora-review? |fedora-review+
--- Comment #2 from Jens Petersen petersen@redhat.com 2011-11-23 08:00:37 EST --- Here is the review:
+:ok, NA: not applicable
MUST Items: [+] MUST: rpmlint output [1]
ghc-mwc-random.src: W: spelling-error %description -l en_US mersenne -> Mennen 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ghc-mwc-random.x86_64: W: spelling-error %description -l en_US mersenne -> Mennen 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ghc-mwc-random-devel.x86_64: W: spelling-error %description -l en_US mersenne -> Mennen 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[+] MUST: package named according to Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [2] [+] MUST: meet Packaging Guidelines [+] MUST: Fedora approved license and Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [3] [+] MUST: include license files in %doc if available in source [4] [+] MUST: The spec file must be written in American English [5] and legible. [6] [+] MUST: source md5sum matches upstream release (from upstream URL)
1eb10b9bb760e587a4827cf8e4309ce3 mwc-random-0.10.0.1.tar.gz
[+] MUST: successfully compile and build into binary rpms on a primary arch [7]
[NA] MUST: if necessary use ExcludeArch for other archs [8] [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [9] [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] [+] MUST: Packages must NOT bundle copies of system libraries. [11] [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [12] [+] MUST: A package must own all directories that it creates. [13] [+] MUST: A package must not contain any duplicate files in the %files listing. [14] [+] MUST: Permissions on files must be set properly. [15] [+] MUST: consistently use macros [16] [+] MUST: The package must contain code, or permissable content. [17] [NA] MUST: Large documentation files should go in a doc subpackage. [18] [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [18] [+] MUST: Header files must be in a -devel package. [19] [NA] MUST: Static libraries must be in a -static package. [20] [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [21] [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [20] [NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [22] [+] MUST: Packages must not own files or directories already owned by other packages. [23] [+] MUST: All filenames in rpm packages must be valid UTF-8. [24]
SHOULD Items: [+] SHOULD: If upstream source does not include license text file(s), the packager SHOULD query upstream to include it. [25] [NA] SHOULD: include description and summary translations for supported Non-English languages, if available. [26] [+] SHOULD: The reviewer should test that the package builds in mock. [27] [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [28] [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [29]
Package is APPROVED.
You can normalize the indentation of the description before building please.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-11-26 00:19:30 EST ---
You can normalize the indentation of the description before building please.
Yes. Will do that.
Thanks for the review.
New Package SCM Request ======================= Package Name: ghc-mwc-random Short Description: Pseudo random number generation library for Haskell Owners: narasim Branches: f16 f15 InitialCC: haskell-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2011-11-27 17:07:32 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2011-12-02 23:04:34 EST --- ghc-mwc-random-0.10.0.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-mwc-random-0.10.0.1-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-12-02 23:04:43 EST --- ghc-mwc-random-0.10.0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-mwc-random-0.10.0.1-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|unspecified |medium
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-12-04 19:22:47 EST --- ghc-mwc-random-0.10.0.1-1.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ghc-mwc-random-0.10.0.1-1.f | |c15 Resolution| |ERRATA Last Closed| |2011-12-16 14:51:06
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-12-16 14:51:06 EST --- ghc-mwc-random-0.10.0.1-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-mwc-random-0.10.0.1-1.f |ghc-mwc-random-0.10.0.1-1.f |c15 |c16
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-12-16 14:52:06 EST --- ghc-mwc-random-0.10.0.1-1.fc16 has been pushed to the Fedora 16 stable repository.
haskell-devel@lists.fedoraproject.org