Currently when a package is retired, it sets the eol date to today's
date in pdc, but that enables people to revert the git retirement
commit until the end of the day and that causes a couple of problems
1. When fedpkg retire is called, it sets the eol date in pdc but when
people revert it on the very same day, the eol date is not changed
back.
2. Since the eol date is not change back, the package gets blocked in
koji and people have to request releng to fix it manually and it
causes some confusion.
To fix this issue, we decided to change the retirement date to
yesterday's date and that disables people to revert the commit.
Issues: https://pagure.io/releng/issue/8851 and
https://pagure.io/releng/issue/9169
Fix:
diff --git a/pdcupdater/handlers/retirement.py
b/pdcupdater/handlers/retirement.py
index 3ccda5a..1fbf23b 100644
--- a/pdcupdater/handlers/retirement.py
+++ b/pdcupdater/handlers/retirement.py
@@ -1,5 +1,5 @@
import logging
-from datetime import datetime
+from datetime import datetime, timedelta
import requests
import pdcupdater.services
@@ -189,9 +189,12 @@ def _is_retired_in_dist_git(namespace, repo,
branch, requests_session=None):
@pdcupdater.utils.retry(wait_on=requests.exceptions.ConnectionError)
def _retire_branch(pdc, branch):
""" Internal method for retiring a branch in PDC. """
- today = datetime.utcnow().date()
+ # To disable immediate git reverts
+ # Fixes: https://pagure.io/releng/issue/8851 - Better solution required
+ # Fixes: https://pagure.io/releng/issue/9169 - Not ideal, but works
+ yesterday = datetime.utcnow().date() - timedelta(days=1)
for sla in branch['slas']:
sla_eol = datetime.strptime(sla['eol'], '%Y-%m-%d').date()
- if sla_eol > today:
+ if sla_eol > yesterday:
pdc['component-branch-slas'][sla['id']]._ \
- += {'eol': str(today)}
+ += {'eol': str(yesterday)}
This will be a hotfix in pdc-backend01.phx2.fp.o where pdc-updater is running.
Thanks,
Mohan Boddu.
Hi all,
Badges folks wrapped up our weekly meeting for internship planning.
Outreachy applicants will see the official project list for the first
time on Thursday, 5 March.
NOTE: Future meetings shifted to 15:00 UTC / 10:00 EST on Mondays.
Calendar invites available on request via email or ask in #fedora-badges.
A summary of the conversation is below, also found in the Google Doc:
https://docs.google.com/document/d/1R3VndOLYl9A47s_swC03Tci5LpCb8Via9wghDY3…
* Plan for 5 March: applicants arrive
* Create new “Join Fedora Badges” page in Badges docs based on
existing * page from CommOps docs (register FAS, join IRC/Telegram,
introduce on mailing list, etc.)
* Unify issue tracking to one place
* Discussed Badges Pagure, Tahrir, and forking badgr-server to
fedora-infra on GitHub
* Decided to fork to fedora-infra GitHub and move “story” issues
from Tahrir depending if they are still relevant:
https://github.com/fedora-infra/badgr-server
* Add fedora-messaging onboarding task from fedora-happiness-packets
project last summer to new issue tracker
* Chat with upstream about identifying “good first issue” tasks for
applicants
* Action items:
* Justin
* Open new “How to contribute” docs page for badges
* Follow up with a fedora-infra owner about GitHub permissions
* Open fedora-messaging issue on badgr-server fork
* Marie: Email Concentric Sky/Badgr team
* https://github.com/concentricsky/badgr-server/issues
* March 5th interns show up
* Open “good first issue” bugs/tasks for new contributors
* Can also be docs improvements
* All: Triage and review Tahrir stories for migration to
fedora-infra/badgr-server:
https://github.com/fedora-infra/tahrir/issues?q=is%3Aissue+is%3Aopen+label%…
--
Cheers,
Justin W. Flory (he/him)
justinwflory.com
TZ=America/New_York