Re: Freeze break request: make only fas01 clear sessions, resolving a deadlock

On 11 August 2015 at 04:48, Patrick Uiterwijk puiterwijk@redhat.com wrote:

This has been applied, but it turned out this was NOT what was causing the issues. Should I just reverse this change, as it might be an issue but it's not hitting any users?

I would talk with Kevin but I think a reversal and then a fixed up patch with it being a variable sent to FAS upstream is needed.

With kind regards, Patrick Uiterwijk Fedora Infra

----- Original Message -----

...

On Mon, Aug 10, 2015 at 06:38:32PM -0400, Patrick Uiterwijk wrote:

...

Change in controllers.py is at line 101: "if socket.gethostname()...."

• def clean_up(self, sess):

•    # This is to make sure that only one server cleans up sessions
  

•    if socket.gethostname() != 'fas01.phx2.fedoraproject.org':
  

•        return
  

•    result = SessionTable.delete(
  

•        SessionTable.c.expiration_time.__lt__(datetime.datetime.now())
  

•        ).execute()
  

This is indeed terribly hacky but if it works, +1 for now.

Pierre