-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi all,
Can I get +1s for the underneath patch to fix mediawiki not calling their own API correctly? This breaks creating new pages on the wiki (and I should've fixed it way earlier, but forgot).
- From caa8183ffa572ee6ded823e3d1e895d1dcc6a466 Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk patrick@puiterwijk.org Date: Fri, 31 Aug 2018 19:31:58 +0200 Subject: [PATCH] Fix creating of new wiki pages
This breaks because mediawiki doesn't follow their own documented API[1] and doesn't pass a base revision ID when creating new pages.
Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org
[1]: https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete - --- roles/mediawiki/files/fedmsg-emit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/roles/mediawiki/files/fedmsg-emit.php b/roles/mediawiki/files/fedmsg-emit.php index c62bd3ee7..846d28e8a 100644 - --- a/roles/mediawiki/files/fedmsg-emit.php +++ b/roles/mediawiki/files/fedmsg-emit.php @@ -205,7 +205,7 @@ function article_save( &$flags, $revision, &$status, - - $baseRevId, + $baseRevId=0, $undidRevId ) {
- -- 2.17.1
+1 On Fri, 31 Aug 2018 at 13:42, Kevin Fenzi kevin@scrye.com wrote:
+1.
Note that this is also
https://pagure.io/fedora-infrastructure/issue/7193
kevin
infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro...
infrastructure@lists.fedoraproject.org