I'd like to request a freeze break request for Fedora-Tagger to cut a new release and push it to production. I'm in the process of trying it out in staging now.
The new release includes fixes to 5 bugs:
https://github.com/fedora-infra/fedora-tagger/issues/90 https://github.com/fedora-infra/fedora-tagger/issues/89 https://github.com/fedora-infra/fedora-tagger/issues/84 https://github.com/fedora-infra/fedora-tagger/issues/87 https://github.com/fedora-infra/fedora-tagger/issues/88
They are all frontend/UI/javascript fixes.
On Wed, May 15, 2013 at 04:05:05PM -0400, Ralph Bean wrote:
I'd like to request a freeze break request for Fedora-Tagger to cut a new release and push it to production. I'm in the process of trying it out in staging now.
The new release includes fixes to 5 bugs:
https://github.com/fedora-infra/fedora-tagger/issues/90 https://github.com/fedora-infra/fedora-tagger/issues/89 https://github.com/fedora-infra/fedora-tagger/issues/84 https://github.com/fedora-infra/fedora-tagger/issues/87 https://github.com/fedora-infra/fedora-tagger/issues/88They are all frontend/UI/javascript fixes.
Since tagger is now part of the compose process we probably want to start doing only small, targeted changes.
however, this is only the second day of beta freeze (not final). I've reviewed the first four changes and they seem okay. The last one is larger and more complex. All have already had signoff to merge into the upstream repo.
These are all UI changes, so at worst people wouldn't be able to add and edit tags; it shouldn't affect the ability for tags to be pulled out of tagger for use in the compose process.
So I think updating ASAP would be okay but we should still try not to do this in the future.
-Toshio
On Wed, May 15, 2013 at 01:35:42PM -0700, Toshio Kuratomi wrote:
Since tagger is now part of the compose process we probably want to start doing only small, targeted changes.
however, this is only the second day of beta freeze (not final). I've reviewed the first four changes and they seem okay. The last one is larger and more complex. All have already had signoff to merge into the upstream repo.
These are all UI changes, so at worst people wouldn't be able to add and edit tags; it shouldn't affect the ability for tags to be pulled out of tagger for use in the compose process.
So I think updating ASAP would be okay but we should still try not to do this in the future.
-Toshio
Adding further comment: the change is 'high impact' in the sense that it touches tagger which is now part of the compose process. It is 'low impact' in that it is mostly superficial UI changes.
It is also low-urgency. It doesn't *need* to go in during the freeze. It can wait until after.
I just made the announcement the other day and got an avalanche of bug reports -- this knocks off the low hanging fruit.
On Wed, 15 May 2013 17:00:33 -0400 Ralph Bean rbean@redhat.com wrote:
On Wed, May 15, 2013 at 01:35:42PM -0700, Toshio Kuratomi wrote:
Since tagger is now part of the compose process we probably want to start doing only small, targeted changes.
Yeah, agreed.... although:
[bodhi.metadata] INFO 2013-05-15 16:32:59,099 Downloading https://apps.fedoraproject.org/tagger/api/ v1/tag/sqlitebuildtags/ [bodhi.metadata] ERROR 2013-05-15 16:33:08,801 [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 500 INTERNAL SERVER ERROR" Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/bodhi/metadata.py", line 291, in insert_pkgtags urlgrab(tags_url, filename=local_tags) File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 618, in urlgrab return default_grabber.urlgrab(url, filename, **kwargs) File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 985, in urlgrab return self._retry(opts, retryfunc, url, filename) File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 886, in _retry r = apply(func, (opts,) + args, {}) File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 971, in retryfunc fo = PyCurlFileObject(url, filename, opts) File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1066, in __init__ self._do_open() File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1360, in _do_open self._do_grab() File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1490, in _do_grab self._do_perform() File "/usr/lib/python2.6/site-packages/urlgrabber/grabber.py", line 1347, in _do_perform raise err URLGrabError: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 500 INTERNAL SERVER ERROR" [bodhi.metadata] ERROR 2013-05-15 16:33:08,817 There was a problem injecting pkgtags
So, it doesn't seem like it's actually working right now anyhow. ;(
however, this is only the second day of beta freeze (not final). I've reviewed the first four changes and they seem okay. The last one is larger and more complex. All have already had signoff to merge into the upstream repo.
These are all UI changes, so at worst people wouldn't be able to add and edit tags; it shouldn't affect the ability for tags to be pulled out of tagger for use in the compose process.
So I think updating ASAP would be okay but we should still try not to do this in the future.
-Toshio
Adding further comment: the change is 'high impact' in the sense that it touches tagger which is now part of the compose process. It is 'low impact' in that it is mostly superficial UI changes.
It is also low-urgency. It doesn't *need* to go in during the freeze. It can wait until after.
I just made the announcement the other day and got an avalanche of bug reports -- this knocks off the low hanging fruit.
I'd be ok with the update. Especially if we also could fix the tags for bodhi. ;)
kevin
infrastructure@lists.fedoraproject.org
-
Kevin Fenzi -
Ralph Bean -
Toshio Kuratomi