This one-character typo seems to be preventing commit mail from being sent for all newly-created packages. I've fixed a couple already, but:
$ ls /srv/git/rpms/*/hooks/post.receive|wc -l 92
so I've more to fix. Not sure if I need +1s to make those changes, but I do need +1s to push the following fix through puppet. I'm pretty sure that this script simply lives in puppet; if there's another more upstream repository, please let me know and I'll try to get this fixed there first.
diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package index ebe3165..4b438b2 100755 --- a/modules/gitolite/files/distgit/setup_git_package +++ b/modules/gitolite/files/distgit/setup_git_package @@ -111,7 +111,7 @@ popd >/dev/null # Put our special update hooks in place ln -s /usr/share/gitolite/hooks/common/update $GITROOT/$PACKAGE.git/hooks/ ln -s /usr/share/git-core/mail-hooks/gnome-post-receive-email \ - $GITROOT/$PACKAGE.git/hooks/post.receive + $GITROOT/$PACKAGE.git/hooks/post-receive
- J<
On Thu, 19 Aug 2010, Jason L Tibbitts III wrote:
This one-character typo seems to be preventing commit mail from being sent for all newly-created packages. I've fixed a couple already, but:
$ ls /srv/git/rpms/*/hooks/post.receive|wc -l 92
so I've more to fix. Not sure if I need +1s to make those changes, but I do need +1s to push the following fix through puppet. I'm pretty sure that this script simply lives in puppet; if there's another more upstream repository, please let me know and I'll try to get this fixed there first.
diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package index ebe3165..4b438b2 100755 --- a/modules/gitolite/files/distgit/setup_git_package +++ b/modules/gitolite/files/distgit/setup_git_package @@ -111,7 +111,7 @@ popd >/dev/null # Put our special update hooks in place ln -s /usr/share/gitolite/hooks/common/update $GITROOT/$PACKAGE.git/hooks/ ln -s /usr/share/git-core/mail-hooks/gnome-post-receive-email \
- $GITROOT/$PACKAGE.git/hooks/post.receive
- $GITROOT/$PACKAGE.git/hooks/post-receive
+1 from me, have at it.
-Mike
On Thursday, August 19, 2010 08:13:33 am Mike McGrath wrote:
On Thu, 19 Aug 2010, Jason L Tibbitts III wrote:
This one-character typo seems to be preventing commit mail from being sent for all newly-created packages. I've fixed a couple already, but:
$ ls /srv/git/rpms/*/hooks/post.receive|wc -l 92
so I've more to fix. Not sure if I need +1s to make those changes, but I do need +1s to push the following fix through puppet. I'm pretty sure that this script simply lives in puppet; if there's another more upstream repository, please let me know and I'll try to get this fixed there first.
diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package index ebe3165..4b438b2 100755 --- a/modules/gitolite/files/distgit/setup_git_package +++ b/modules/gitolite/files/distgit/setup_git_package @@ -111,7 +111,7 @@ popd >/dev/null
# Put our special update hooks in place ln -s /usr/share/gitolite/hooks/common/update $GITROOT/$PACKAGE.git/hooks/ ln -s /usr/share/git-core/mail-hooks/gnome-post-receive-email \
- $GITROOT/$PACKAGE.git/hooks/post.receive
- $GITROOT/$PACKAGE.git/hooks/post-receive
+1 from me, have at it.
+1 here also
Thanks; I've pushed the fix, verified that it works, and fixed the 92 other repositories which had this problem.
- J<
infrastructure@lists.fedoraproject.org
-
Dennis Gilmore -
Jason L Tibbitts III -
Mike McGrath