April 2022 - kernel - Fedora Mailing-Lists

[OS-BUILD PATCH] [redhat] arm: turn SPE back on

by Jeremy Linton (via Email Bridge)

From: Jeremy Linton <jlinton(a)redhat.com> [redhat] arm: turn SPE back on While attempting to turn SPE on for all redhat distros except for armv7 builds, the enable/disable was inverted and it was left disabled for everything except for armv7. This was incorrect, lets fix it. Fixes: d76aee99af90 ("[redhat] arm: move SPE to generic") Signed-off-by: Jeremy Linton <jlinton(a)redhat.com> diff --git a/redhat/configs/common/generic/arm/aarch64/CONFIG_ARM_SPE_PMU b/redhat/configs/common/generic/arm/aarch64/CONFIG_ARM_SPE_PMU index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/arm/aarch64/CONFIG_ARM_SPE_PMU +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_ARM_SPE_PMU @@ -1 +1 @@ -# CONFIG_ARM_SPE_PMU is not set +CONFIG_ARM_SPE_PMU=m diff --git a/redhat/configs/common/generic/arm/armv7/CONFIG_ARM_SPE_PMU b/redhat/configs/common/generic/arm/armv7/CONFIG_ARM_SPE_PMU index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/arm/armv7/CONFIG_ARM_SPE_PMU +++ b/redhat/configs/common/generic/arm/armv7/CONFIG_ARM_SPE_PMU @@ -1 +1 @@ -CONFIG_ARM_SPE_PMU=m +# CONFIG_ARM_SPE_PMU is not set -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1745

2 years

1
0
0 / 0

[OS-BUILD PATCH] redhat/configs: enable CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT

by Joel Savitz (via Email Bridge)

From: Joel Savitz <jsavitz(a)redhat.com> redhat/configs: enable CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2026319 Upstream Status: RHEL-only Performance testing has indicated no performance impact to the enablement of kstack offset randomization, so enable it by default. Signed-off-by: Joel Savitz <jsavitz(a)redhat.com> diff --git a/redhat/configs/common/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT b/redhat/configs/common/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT +++ b/redhat/configs/common/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT @@ -1 +1 @@ -# CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT is not set +CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT=y diff --git a/redhat/configs/fedora/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT b/redhat/configs/fedora/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT +++ b/redhat/configs/fedora/generic/CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT @@ -1 +1 @@ -# CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT is not set +CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT=y -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1743

2 years

2
1
0 / 0

[OS-BUILD PATCH] redhat: configs: Enable INTEL_IOMMU_DEBUGFS for debug builds

by Jerry Snitselaar (via Email Bridge)

From: Jerry Snitselaar <jsnitsel(a)redhat.com> redhat: configs: Enable INTEL_IOMMU_DEBUGFS for debug builds Enable INTEL_IOMMU_DEBUGFS in kernel debug builds to aid in debugging iommu issues. Signed-off-by: Jerry Snitselaar <jsnitsel(a)redhat.com> diff --git a/redhat/configs/ark/debug/x86/x86_64/CONFIG_INTEL_IOMMU_DEBUGFS b/redhat/configs/ark/debug/x86/x86_64/CONFIG_INTEL_IOMMU_DEBUGFS new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/debug/x86/x86_64/CONFIG_INTEL_IOMMU_DEBUGFS @@ -0,0 +1 @@ +CONFIG_INTEL_IOMMU_DEBUGFS=y -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1744

2 years

1
0
0 / 0

[OS-BUILD PATCH] redhat: configs: Disable TPM 1.2 specific drivers

by Jerry Snitselaar (via Email Bridge)

From: Jerry Snitselaar <jsnitsel(a)redhat.com> redhat: configs: Disable TPM 1.2 specific drivers TPM 1.2 is not supported in RHEL9, so disable the TPM 1.2 specific drivers. Signed-off-by: Jerry Snitselaar <jsnitsel(a)redhat.com> diff --git a/redhat/configs/ark/generic/CONFIG_TCG_ATMEL b/redhat/configs/ark/generic/CONFIG_TCG_ATMEL new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_TCG_ATMEL @@ -0,0 +1 @@ +# CONFIG_TCG_ATMEL is not set diff --git a/redhat/configs/ark/generic/CONFIG_TCG_INFINEON b/redhat/configs/ark/generic/CONFIG_TCG_INFINEON index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/CONFIG_TCG_INFINEON +++ b/redhat/configs/ark/generic/CONFIG_TCG_INFINEON @@ -1 +1 @@ -CONFIG_TCG_INFINEON=m +# CONFIG_TCG_INFINEON is not set diff --git a/redhat/configs/ark/generic/CONFIG_TCG_NSC b/redhat/configs/ark/generic/CONFIG_TCG_NSC new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_TCG_NSC @@ -0,0 +1 @@ +# CONFIG_TCG_NSC is not set diff --git a/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_ATMEL b/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_ATMEL new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_ATMEL @@ -0,0 +1 @@ +# CONFIG_TCG_TIS_I2C_ATMEL is not set diff --git a/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_INFINEON b/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_INFINEON new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_TCG_TIS_I2C_INFINEON @@ -0,0 +1 @@ +# CONFIG_TCG_TIS_I2C_INFINEON is not set diff --git a/redhat/configs/ark/generic/CONFIG_TCG_TIS_ST33ZP24_I2C b/redhat/configs/ark/generic/CONFIG_TCG_TIS_ST33ZP24_I2C deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/CONFIG_TCG_TIS_ST33ZP24_I2C +++ /dev/null @@ -1 +0,0 @@ -CONFIG_TCG_TIS_ST33ZP24_I2C=m diff --git a/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_ATMEL b/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_ATMEL deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_ATMEL +++ /dev/null @@ -1 +0,0 @@ -CONFIG_TCG_TIS_I2C_ATMEL=y diff --git a/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_INFINEON b/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_INFINEON deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/powerpc/CONFIG_TCG_TIS_I2C_INFINEON +++ /dev/null @@ -1 +0,0 @@ -CONFIG_TCG_TIS_I2C_INFINEON=y diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_TCG_TIS_ST33ZP24_I2C b/redhat/configs/common/generic/CONFIG_TCG_TIS_ST33ZP24_I2C rename from redhat/configs/ark/generic/arm/aarch64/CONFIG_TCG_TIS_ST33ZP24_I2C rename to redhat/configs/common/generic/CONFIG_TCG_TIS_ST33ZP24_I2C index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/arm/aarch64/CONFIG_TCG_TIS_ST33ZP24_I2C +++ b/redhat/configs/common/generic/CONFIG_TCG_TIS_ST33ZP24_I2C diff --git a/redhat/configs/fedora/generic/CONFIG_TCG_TIS_ST33ZP24_I2C b/redhat/configs/fedora/generic/CONFIG_TCG_TIS_ST33ZP24_I2C deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/fedora/generic/CONFIG_TCG_TIS_ST33ZP24_I2C +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_TCG_TIS_ST33ZP24_I2C is not set -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1713

2 years

4
5
0 / 0

[Now Playing] Fedora 36 Test Days

by Sumantro Mukherjee

Hey Fedorans, As most of you might know, we have Fedora testing events happening where you all can participate. As of today, we are running 3 events in parallel. 1. Kernel 5.17 Test Week [0] 2. Fedora 36 CoreOS [1] 3. Fedora Cloud Test Day [2] These are events that are easy to start off if you are new to Fedora and some of them even reward you with a Fedora Badge as token of gratitude and reward for your time and energy that you spent contributing! The wikis below will guide you through the instructions and how to participate. In case of an unlikely event of things not working as intended. File a bug and if you have any questions, reach out to @test list directly. In the coming week, we have two of the most community impacting topics that we will test for the Audio and Upgrade path to Fedora 36 from Fedora 35 and Fedora 34. More details can you found in this Fedora Magazine Article[3] [0] http://fedoraproject.org/wiki/Test_Day:2022-04-03_Kernel_5.17_Test_Week [1] http://fedoraproject.org/wiki/Test_Day:Fedora_36_CoreOS_2022-04-04 [2] http://fedoraproject.org/wiki/Test_Day:2022-04-08_Fedora_36_Cloud_Testday [3] https://fedoramagazine.org/contribute-at-the-fedora-kernel-5-17-coreos-cl... -- //sumantro Fedora QE TRIED AND PERSONALLY TESTED, ERGO TRUSTED

2 years

2
1
0 / 0

[OS-BUILD PATCH] configs: enable CONFIG_RMI4_F3A

by Benjamin Tissoires (via Email Bridge)

From: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> configs: enable CONFIG_RMI4_F3A Upstream: RHEL only Tested: make dist-configs This config is required for supporting the touchpad of the Lenovo T14 and T490 at least. We should not disable it in RHEL. Signed-off-by: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> diff --git a/redhat/configs/common/generic/CONFIG_RMI4_F3A b/redhat/configs/common/generic/CONFIG_RMI4_F3A index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_RMI4_F3A +++ b/redhat/configs/common/generic/CONFIG_RMI4_F3A @@ -1 +1 @@ -# CONFIG_RMI4_F3A is not set +CONFIG_RMI4_F3A=y diff --git a/redhat/configs/fedora/generic/CONFIG_RMI4_F3A b/redhat/configs/fedora/generic/CONFIG_RMI4_F3A deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/fedora/generic/CONFIG_RMI4_F3A +++ /dev/null @@ -1 +0,0 @@ -CONFIG_RMI4_F3A=y -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1670

2 years

2
1
0 / 0

[OS-BUILD PATCHv3 0/9] redhat: Use Makefile variables in scripts

by Prarit Bhargava (via Email Bridge)

From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava <prarit(a)redhat.com> --- redhat/configs/build_configs.sh | 18 ++--- redhat/configs/generate_all_configs.sh | 20 ++---- redhat/configs/process_configs.sh | 11 +-- redhat/scripts/create-tarball.sh | 6 +- redhat/scripts/rh-dist-git.sh | 62 ++++++-------------- redhat/self-test/data/centos-2585cf9dfaad.el7 | 5 +- redhat/self-test/data/centos-2585cf9dfaad.el7.spec | 17 ++--- redhat/self-test/data/centos-2585cf9dfaad.fc25 | 5 +- redhat/self-test/data/centos-2585cf9dfaad.fc25.spec | 17 ++--- redhat/self-test/data/centos-78e36f3b0dae.el7 | 5 +- redhat/self-test/data/centos-78e36f3b0dae.el7.spec | 17 ++--- redhat/self-test/data/centos-78e36f3b0dae.fc25 | 5 +- redhat/self-test/data/centos-78e36f3b0dae.fc25.spec | 17 ++--- redhat/self-test/data/centos-df0cc57e057f.el7 | 5 +- redhat/self-test/data/centos-df0cc57e057f.el7.spec | 17 ++--- redhat/self-test/data/centos-df0cc57e057f.fc25 | 5 +- redhat/self-test/data/centos-df0cc57e057f.fc25.spec | 17 ++--- redhat/self-test/data/centos-fce15c45d3fb.el7 | 5 +- redhat/self-test/data/centos-fce15c45d3fb.el7.spec | 17 ++--- redhat/self-test/data/centos-fce15c45d3fb.fc25 | 5 +- redhat/self-test/data/centos-fce15c45d3fb.fc25.spec | 17 ++--- redhat/self-test/data/create-data.sh | 4 +- redhat/self-test/data/fedora-2585cf9dfaad.el7 | 5 +- redhat/self-test/data/fedora-2585cf9dfaad.el7.spec | 17 ++--- redhat/self-test/data/fedora-2585cf9dfaad.fc25 | 5 +- redhat/self-test/data/fedora-2585cf9dfaad.fc25.spec | 17 ++--- redhat/self-test/data/fedora-78e36f3b0dae.el7 | 5 +- redhat/self-test/data/fedora-78e36f3b0dae.el7.spec | 17 ++--- redhat/self-test/data/fedora-78e36f3b0dae.fc25 | 5 +- redhat/self-test/data/fedora-78e36f3b0dae.fc25.spec | 17 ++--- redhat/self-test/data/fedora-df0cc57e057f.el7 | 5 +- redhat/self-test/data/fedora-df0cc57e057f.el7.spec | 17 ++--- redhat/self-test/data/fedora-df0cc57e057f.fc25 | 5 +- redhat/self-test/data/fedora-df0cc57e057f.fc25.spec | 17 ++--- redhat/self-test/data/fedora-fce15c45d3fb.el7 | 5 +- redhat/self-test/data/fedora-fce15c45d3fb.el7.spec | 17 ++--- redhat/self-test/data/fedora-fce15c45d3fb.fc25 | 5 +- redhat/self-test/data/fedora-fce15c45d3fb.fc25.spec | 17 ++--- redhat/self-test/data/rhel-2585cf9dfaad.el7 | 5 +- redhat/self-test/data/rhel-2585cf9dfaad.el7.spec | 17 ++--- redhat/self-test/data/rhel-2585cf9dfaad.fc25 | 5 +- redhat/self-test/data/rhel-2585cf9dfaad.fc25.spec | 17 ++--- redhat/self-test/data/rhel-78e36f3b0dae.el7 | 5 +- redhat/self-test/data/rhel-78e36f3b0dae.el7.spec | 17 ++--- redhat/self-test/data/rhel-78e36f3b0dae.fc25 | 5 +- redhat/self-test/data/rhel-78e36f3b0dae.fc25.spec | 17 ++--- redhat/self-test/data/rhel-df0cc57e057f.el7 | 5 +- redhat/self-test/data/rhel-df0cc57e057f.el7.spec | 17 ++--- redhat/self-test/data/rhel-df0cc57e057f.fc25 | 5 +- redhat/self-test/data/rhel-df0cc57e057f.fc25.spec | 17 ++--- redhat/self-test/data/rhel-fce15c45d3fb.el7 | 5 +- redhat/self-test/data/rhel-fce15c45d3fb.el7.spec | 17 ++--- redhat/self-test/data/rhel-fce15c45d3fb.fc25 | 5 +- redhat/self-test/data/rhel-fce15c45d3fb.fc25.spec | 17 ++--- redhat/Makefile | 49 +++++++--------- redhat/genspec.sh | 8 ++- redhat/kernel.spec.template | 7 +- 57 files changed, 264 insertions(+), 449 deletions(-)

2 years

1
9
0 / 0

[OS-BUILD PATCHv2 0/8] redhat: Use Makefile variables in scripts

by Prarit Bhargava (via Email Bridge)

From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava <prarit(a)redhat.com> --- redhat/configs/build_configs.sh | 18 ++--- redhat/configs/generate_all_configs.sh | 20 ++---- redhat/configs/process_configs.sh | 11 +-- redhat/scripts/create-tarball.sh | 6 +- redhat/scripts/rh-dist-git.sh | 62 ++++++-------------- redhat/self-test/data/centos-2585cf9dfaad.el7 | 1 - redhat/self-test/data/centos-2585cf9dfaad.el7.spec | 7 +- redhat/self-test/data/centos-2585cf9dfaad.fc25 | 1 - redhat/self-test/data/centos-2585cf9dfaad.fc25.spec | 7 +- redhat/self-test/data/centos-78e36f3b0dae.el7 | 1 - redhat/self-test/data/centos-78e36f3b0dae.el7.spec | 7 +- redhat/self-test/data/centos-78e36f3b0dae.fc25 | 1 - redhat/self-test/data/centos-78e36f3b0dae.fc25.spec | 7 +- redhat/self-test/data/centos-df0cc57e057f.el7 | 1 - redhat/self-test/data/centos-df0cc57e057f.el7.spec | 7 +- redhat/self-test/data/centos-df0cc57e057f.fc25 | 1 - redhat/self-test/data/centos-df0cc57e057f.fc25.spec | 7 +- redhat/self-test/data/centos-fce15c45d3fb.el7 | 1 - redhat/self-test/data/centos-fce15c45d3fb.el7.spec | 7 +- redhat/self-test/data/centos-fce15c45d3fb.fc25 | 1 - redhat/self-test/data/centos-fce15c45d3fb.fc25.spec | 7 +- redhat/self-test/data/fedora-2585cf9dfaad.el7 | 1 - redhat/self-test/data/fedora-2585cf9dfaad.el7.spec | 7 +- redhat/self-test/data/fedora-2585cf9dfaad.fc25 | 1 - redhat/self-test/data/fedora-2585cf9dfaad.fc25.spec | 7 +- redhat/self-test/data/fedora-78e36f3b0dae.el7 | 1 - redhat/self-test/data/fedora-78e36f3b0dae.el7.spec | 7 +- redhat/self-test/data/fedora-78e36f3b0dae.fc25 | 1 - redhat/self-test/data/fedora-78e36f3b0dae.fc25.spec | 7 +- redhat/self-test/data/fedora-df0cc57e057f.el7 | 1 - redhat/self-test/data/fedora-df0cc57e057f.el7.spec | 7 +- redhat/self-test/data/fedora-df0cc57e057f.fc25 | 1 - redhat/self-test/data/fedora-df0cc57e057f.fc25.spec | 7 +- redhat/self-test/data/fedora-fce15c45d3fb.el7 | 1 - redhat/self-test/data/fedora-fce15c45d3fb.el7.spec | 7 +- redhat/self-test/data/fedora-fce15c45d3fb.fc25 | 1 - redhat/self-test/data/fedora-fce15c45d3fb.fc25.spec | 7 +- redhat/self-test/data/rhel-2585cf9dfaad.el7 | 1 - redhat/self-test/data/rhel-2585cf9dfaad.el7.spec | 7 +- redhat/self-test/data/rhel-2585cf9dfaad.fc25 | 1 - redhat/self-test/data/rhel-2585cf9dfaad.fc25.spec | 7 +- redhat/self-test/data/rhel-78e36f3b0dae.el7 | 1 - redhat/self-test/data/rhel-78e36f3b0dae.el7.spec | 7 +- redhat/self-test/data/rhel-78e36f3b0dae.fc25 | 1 - redhat/self-test/data/rhel-78e36f3b0dae.fc25.spec | 7 +- redhat/self-test/data/rhel-df0cc57e057f.el7 | 1 - redhat/self-test/data/rhel-df0cc57e057f.el7.spec | 7 +- redhat/self-test/data/rhel-df0cc57e057f.fc25 | 1 - redhat/self-test/data/rhel-df0cc57e057f.fc25.spec | 7 +- redhat/self-test/data/rhel-fce15c45d3fb.el7 | 1 - redhat/self-test/data/rhel-fce15c45d3fb.el7.spec | 7 +- redhat/self-test/data/rhel-fce15c45d3fb.fc25 | 1 - redhat/self-test/data/rhel-fce15c45d3fb.fc25.spec | 7 +- redhat/Makefile | 43 +++++--------- redhat/genspec.sh | 8 ++- redhat/kernel.spec.template | 7 +- 56 files changed, 135 insertions(+), 232 deletions(-)

2 years

1
9
0 / 0

[OS-BUILD PATCH] Spec fixes for intel-speed-select

by Justin M. Forbes (via Email Bridge)

From: Justin M. Forbes <jforbes(a)fedoraproject.org> Spec fixes for intel-speed-select Now that Herton's patch is in, we still need the includes added to the make commands from the spec. This patch makes intel-speed-select build in current koji. Signed-off-by: Justin M. Forbes <jforbes(a)fedoraproject.org> diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -2246,7 +2246,7 @@ chmod +x tools/power/cpupower/utils/version-gen.sh %{tools_make} popd pushd tools/power/x86/intel-speed-select - %{make} + %{make} CFLAGS+="-D_GNU_SOURCE -Iinclude -I/usr/include/libnl3" popd %endif %endif @@ -2511,7 +2511,7 @@ install -m644 %{SOURCE2001} %{buildroot}%{_sysconfdir}/sysconfig/cpupower %{tools_make} DESTDIR=%{buildroot} install popd pushd tools/power/x86/intel-speed-select - %{tools_make} CFLAGS+="-D_GNU_SOURCE -Iinclude" DESTDIR=%{buildroot} install + %{tools_make} CFLAGS+="-D_GNU_SOURCE -Iinclude -I/usr/include/libnl3" DESTDIR=%{buildroot} install popd %endif pushd tools/thermal/tmon -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1740

2 years

1
0
0 / 0

[OS-BUILD PATCHv2] tools/power/x86/intel-speed-select: fix build failure when using -Wl,--as-needed

by Prarit Bhargava (via Email Bridge)

From: Prarit Bhargava <prarit(a)redhat.com> tools/power/x86/intel-speed-select: fix build failure when using -Wl,--as-needed Upstream Status: https://www.spinics.net/lists/platform-driver-x86/msg31958.html Build of intel-speed-select will fail if you run: $ LDFLAGS="-Wl,--as-needed" /usr/bin/make V=1 ... gcc -O2 -Wall -g -D_GNU_SOURCE -Iinclude -I/usr/include/libnl3 -Wl,--as-needed -lnl-genl-3 -lnl-3 intel-speed-select-in.o -o intel-speed-select /usr/bin/ld: intel-speed-select-in.o: in function `handle_event': (...)/linux/tools/power/x86/intel-speed-select/hfi-events.c:189: undefined reference to `nlmsg_hdr' ... In this case the problem is that order when linking matters when using the flag -Wl,--as-needed, symbols not used at that point are discarded. So since intel-speed-select-in.o comes after, at that point the libraries/symbols are already discarded and then missing/undefined references are reported. To fix this, make sure we specify LDFLAGS after the object file. Signed-off-by: Herton R. Krzesinski <herton(a)redhat.com> Signed-off-by: Prarit Bhargava <prarit(a)redhat.com> diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel-speed-select/Makefile index blahblah..blahblah 100644 --- a/tools/power/x86/intel-speed-select/Makefile +++ b/tools/power/x86/intel-speed-select/Makefile @@ -42,7 +42,7 @@ ISST_IN := $(OUTPUT)intel-speed-select-in.o $(ISST_IN): prepare FORCE $(Q)$(MAKE) $(build)=intel-speed-select $(OUTPUT)intel-speed-select: $(ISST_IN) - $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ + $(QUIET_LINK)$(CC) $(CFLAGS) $< $(LDFLAGS) -o $@ clean: rm -f $(ALL_PROGRAMS) -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721

2 years

1
1
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

kernel April 2022