David Woodhouse schrieb:
On Mon, 2007-04-30 at 20:04 +0200, Thorsten Leemhuis wrote:
> See include/compat.h ; relevant part:
>
> #include <linux/version.h>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,21)
> #define ATH_REGISTER_SYSCTL_TABLE(t) register_sysctl_table(t, 1)
> #else
> #define ATH_REGISTER_SYSCTL_TABLE(t) register_sysctl_table(t)
> #endif
>
> Compiling it against a recent 2.6.21 kernel from rawhide works just fine:
I've spent a _long_ time maintaining modules outside the kernel tree; I
know about compatibility hacks like this. Trust me; you have a hybrid
thing which is neither 2.6.20 nor 2.6.21. Calling it "2.6.21" instead of
calling it "2.6.20" doesn't actually fix any problems; it only moves
them around.
But calling something foo (2.6.20) if upstream calls itself bar (2.6.21)
just created addition problems for Fedora users and contributors (like
in this madwifi case). So why obscure the version number it? Why not
follow upstream, which is afaik one of the goals of Fedora.
CU
thl