From: Jarod Wilson jarod@redhat.com
redhat: indicate HEAD state in tarball/rpm name
For the non-Fedora (RHEL) case, we are looking to move to a setup where we include Merge Requests as soon as they are ready, and thus the head of main may not always be a tagged build. This gives some indication to someone basing a build on main that they're basing their work on the tree at a state between tagged builds.
If HEAD is a tagged build, as usual, you should see: linux-4.18.0-374.el8.tar.xz kernel-4.18.0-374.el8.src.rpm
If HEAD has additional commits, with this change, you should see: linux-4.18.0-374.g797f.el8.tar.xz kernel-4.18.0-374.g797f.el8.src.rpm
The .gSHA field is the first four chars of the HEAD sha of the branch after adding your local changes.
This is directly related to: https://gitlab.com/redhat/rhel/src/kernel/rhel-8/-/merge_requests/2405
Signed-off-by: Jarod Wilson jarod@redhat.com
diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -49,6 +49,7 @@ FLAVOR= CURARCH := $(shell uname -m) ARCHCONFIG := $(shell uname -m | sed -e s/x86_64/X86_64/ \ -e s/s390x/S390/ -e s/ppc.*/PPC/ ) +RHEL_EXTRAVERSION=
# rpm information SPECFILE:=$(PACKAGE_NAME).spec @@ -189,6 +190,13 @@ ifeq ($(VERSION_ON_UPSTREAM),1) endif else SNAPSHOT:=0 + EXACT_TAG:=$(shell $(GIT) describe --exact-match 2>/dev/null) + ifeq ($(EXACT_TAG),) + _TAG:=$(shell $(GIT) describe 2>/dev/null) + ifneq ($(_TAG),) + RHEL_EXTRAVERSION:=$(shell echo $(_TAG) | awk -F- '{ printf(".%s", $$(NF)) }' | cut -c 1-6) + endif + endif endif
KVERSION:=$(RPMKVERSION).$(RPMKPATCHLEVEL).$(RPMKSUBLEVEL) @@ -231,6 +239,7 @@ else # upstream sources and RHEL specific patches. SINGLE_TARBALL:=1 RHDISTGIT_BRANCH:=rhel-$(RHEL_MAJOR).$(RHEL_MINOR).0 + BUILD:=$(BUILD)$(RHEL_EXTRAVERSION) ifndef BUILD_SCRATCH_TARGET BUILD_SCRATCH_TARGET:=rhel-$(RHEL_MAJOR).$(RHEL_MINOR).0-test-pesign endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9018600...
Latest version only brings in the RHEL_EXTRAVERSION in the (not (Fedora or CentOS)) case, and shortens the extra bits to just ".gXXXX". (4-char sha hash of git head).
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9031885...
This time on the right MR:
@jwilsonrh, since this changes the Makefile variables and possibly the spec file, can you run 'make dist-self-test-data', confirm the changes, and commit those changes as well?
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9085224...
@jmflinuxtx does the above scheme work at least for now? This should only affect one-off custom builds people do of a RHEL-based build, so far as I know. :)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9085231...
@prarit I believe you were updating the tests here and on irc said to ignore this, at least until the update was done. Should I be revisiting this now?
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9086109...
It seems that it would work as we do not set SINGLE_TARBALL:=1
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_9193086...
@prarit can you take a look at this again?
kernel@lists.fedoraproject.org