3:46 a.m.
From: Gopal Tiwari <gtiwari(a)redhat.com>
Setting CONFIG_I2C_SMBUS to "m" for ark
This setting is keeping CONFIG_I2C_SMBUS in align to rhel.
Signed-off-by: Gopal Tiwari <gtiwari(a)redhat.com>
diff --git a/redhat/configs/common/generic/CONFIG_I2C_SMBUS
b/redhat/configs/common/generic/CONFIG_I2C_SMBUS
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_I2C_SMBUS
@@ -0,0 +1 @@
+CONFIG_I2C_SMBUS=m
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626
5:52 a.m.
From: Gopal Tiwari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8524...
Pipeline failed for following..
~~~
00:07:38 Processing /builds/2126626317/workdir/redhat/configs/kernel-
aarch64-debug-fedora.config ... Found unset config items, please set them to
an appropriate value
00:07:38 CONFIG_TSNEP_SELFTESTS=n
00:07:38 make[1]: *** [Makefile:140: dist-configs-check] Error 1
~~~
5:53 a.m.
From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8524...
This was automagically taken care of. If you retrigger the pipeline it should
no longer be a problem.
https://gitlab.com/cki-project/kernel-
ark/-/commit/8f57f37bbee14b71e970c75aff1ee317714d799f
6 a.m.
From: Gopal Tiwari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8524...
Sure thanks for the response. I've restarted the failed job.
Gopal
6:41 a.m.
From: perobins on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8524...
You can probably remove the ark/generic/arm/aarch64/CONFIG_I2C_SMBUS option
too as it's now set for aarch64 by the common option.
Reviewed-by: Peter Robinson <pbrobinson(a)redhat.com>
6:53 a.m.
From: Gopal Tiwari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8524...
Sure, thanks
Gopal
7:20 a.m.
From: Ondrej Mosnáček on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8525...
And what about `redhat/configs/common/generic/s390x/CONFIG_I2C_SMBUS`? Is it
needed? Is it intended? The commit message sounds as if the intended result is
to have the config enabled as =m universally. Either the file should be
removed as well or the commit message should explain better what is the
current vs. expected state.
7:27 a.m.
From: Daniel Horak on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8525...
CONFIG_I2C_SMBUS should be disabled on s390x, there is no such thing
accessible :-)
7:35 a.m.
From: perobins on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8525...
Probably should be done with "# CONFIG_I2C is not set" and remove all the
stray CONFIG_I2C* but that's a separate issue to this change.
The s390 config as it stands doesn't change with this change.
7:44 a.m.
From: Gopal Tiwari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8525...
Its already I see redhat/configs/common/generic/s390x/CONFIG_I2C_SMBUS:#
CONFIG_I2C_SMBUS is not set
3:18 a.m.
From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8664...
@gtiwari1 The `os-build` branch is rebased whenever there is an official
release of the upstream kernel. This is expected to next happen this coming
Monday, the 14th. So just be aware if this MR is not ready for merge by then
that it will need to be rebased.
4:05 a.m.
From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8699...
@perobins are you okay with this as-is? This can be merged once this thread is
resolved.
8:23 a.m.
From: perobins on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8703...
Yes, overall I am fine with this, this is enabled in Fedora for both
x86/aarch64 already as I suspect something selects this, so implicitly
enabling it is fine. But there's a minor cleanup that can happen as there's a
ark/generic/arm/aarch64/CONFIG_I2C_SMBUS option too.
8:23 a.m.
From: perobins on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8703...
Reviewed-by: Peter Robinson <pbrobinson(a)redhat.com>
2:57 a.m.
From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_8713...
Thank you @perobins. I am marking this thread as Resolved then.
770
days inactive
786
days old
kernel@lists.fedoraproject.org
14 comments
5 participants
participants (5)
-
Daniel Horak (via Email Bridge) -
Gopal Tiwari (via Email Bridge)
-
Ondrej Mosnáček (via Email Bridge)
-
Patrick Talbert (via Email Bridge)
-
perobins (via Email Bridge)