10:59 a.m.
0) Building an rpm for (vanilla) v3.14, using the origin/f20 branch of
kernel.git, triggers a warning (a couple of times):
.config:5466:warning: override: USB_G_DBGP_SERIAL changes choice state
1) It turns out config-armv7-generic contains both
CONFIG_USB_G_DBGP_PRINTK=y
and
CONFIG_USB_G_DBGP_SERIAL=y
2) But in drivers/usb/gadget/Kconfig we see (summarized):
choice
prompt "EHCI Debug Device mode"
default USB_G_DBGP_SERIAL
config USB_G_DBGP_PRINTK
bool "printk"
config USB_G_DBGP_SERIAL
bool "serial"
endchoice
If I'm reading this correctly, this means that we need to choose between
USB_G_DBGP_PRINTK and USB_G_DBGP_PRINTK.
3) Should we remove one of these two Kconfig macros? Or is the upstream
Kconfig file incorrect and can both symbols be set simultaneously?
Paul Bolle
12:21 p.m.
On Mon, Mar 31, 2014 at 05:59:41PM +0200, Paul Bolle wrote:
0) Building an rpm for (vanilla) v3.14, using the origin/f20 branch
of
kernel.git, triggers a warning (a couple of times):
.config:5466:warning: override: USB_G_DBGP_SERIAL changes choice state
1) It turns out config-armv7-generic contains both
CONFIG_USB_G_DBGP_PRINTK=y
and
CONFIG_USB_G_DBGP_SERIAL=y
Adding Peter. He set both of these as such.
2) But in drivers/usb/gadget/Kconfig we see (summarized):
choice
prompt "EHCI Debug Device mode"
default USB_G_DBGP_SERIAL
config USB_G_DBGP_PRINTK
bool "printk"
config USB_G_DBGP_SERIAL
bool "serial"
endchoice
If I'm reading this correctly, this means that we need to choose between
USB_G_DBGP_PRINTK and USB_G_DBGP_PRINTK.
Correct.
3) Should we remove one of these two Kconfig macros? Or is the
upstream
Kconfig file incorrect and can both symbols be set simultaneously?
No, looking at dbgp.c it definitely seems to be one or the other.
Peter, do you want that going to printk or serial?
josh
2:14 a.m.
Josh,
On Mon, 2014-03-31 at 13:21 -0400, Josh Boyer wrote:
On Mon, Mar 31, 2014 at 05:59:41PM +0200, Paul Bolle wrote:
> 3) Should we remove one of these two Kconfig macros? Or is the upstream
> Kconfig file incorrect and can both symbols be set simultaneously?
No, looking at dbgp.c it definitely seems to be one or the other.
Peter, do you want that going to printk or serial?
Perhaps we should just drop USB_G_DBGP_PRINTK and only leave
USB_G_DBGP_SERIAL (which is the default choice). Peter can always push a
change if the reverse is preferable.
Should I draft the trivial patch to pick USB_G_DBGP_SERIAL?
Paul Bolle
7:13 a.m.
On Fri, Apr 04, 2014 at 09:14:06AM +0200, Paul Bolle wrote:
Josh,
On Mon, 2014-03-31 at 13:21 -0400, Josh Boyer wrote:
> On Mon, Mar 31, 2014 at 05:59:41PM +0200, Paul Bolle wrote:
> > 3) Should we remove one of these two Kconfig macros? Or is the upstream
> > Kconfig file incorrect and can both symbols be set simultaneously?
>
> No, looking at dbgp.c it definitely seems to be one or the other.
>
> Peter, do you want that going to printk or serial?
Perhaps we should just drop USB_G_DBGP_PRINTK and only leave
USB_G_DBGP_SERIAL (which is the default choice). Peter can always push a
change if the reverse is preferable.
Agreed.
Should I draft the trivial patch to pick USB_G_DBGP_SERIAL?
No need. I'll just change it with the next commit I do. Thank you for
the offer.
josh
1:59 a.m.
On 4 Apr 2014 20:14, "Josh Boyer" <jwboyer(a)fedoraproject.org> wrote:
On Fri, Apr 04, 2014 at 09:14:06AM +0200, Paul Bolle wrote:
> Josh,
>
> On Mon, 2014-03-31 at 13:21 -0400, Josh Boyer wrote:
> > On Mon, Mar 31, 2014 at 05:59:41PM +0200, Paul Bolle wrote:
> > > 3) Should we remove one of these two Kconfig macros? Or is the
upstream
> > > Kconfig file incorrect and can both symbols be set
simultaneously?
> >
> > No, looking at dbgp.c it definitely seems to be one or the other.
> >
> > Peter, do you want that going to printk or serial?
>
> Perhaps we should just drop USB_G_DBGP_PRINTK and only leave
> USB_G_DBGP_SERIAL (which is the default choice). Peter can always push a
> change if the reverse is preferable.
Agreed.
Fine by me, sorry been AFK, thanks for picking this up.
P
3667
days inactive
3676
days old
kernel@lists.fedoraproject.org
4 comments
3 participants
participants (3)
-
Josh Boyer -
Paul Bolle -
Peter Robinson