Hello Kairui,
On Mon, Nov 5, 2018 at 2:49 PM Dave Young <dyoung(a)redhat.com> wrote:
On 11/05/18 at 03:34am, Bhupesh Sharma wrote:
> Resolves: bz1561837
> Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1561837
>
> Currently 'kdump.conf' and 'kdump.conf MAN page' entries state that
the
> local dump path should be:
>
> <fs type> <partition>
> - Will mount -t <fs type> <partition> <mnt>, and copy
> /proc/vmcore to <mnt>/<path>/%DATE/.
>
> The correct vmcore path instead should be:
> <mnt>/<path>/%HOST_IP-%DATE/
>
> Signed-off-by: Bhupesh Sharma <bhsharma(a)redhat.com>
> ---
> kdump.conf | 2 +-
> kdump.conf.5 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kdump.conf b/kdump.conf
> index 57af7b6ca52a..286ad275ce02 100644
> --- a/kdump.conf
> +++ b/kdump.conf
> @@ -32,7 +32,7 @@
> #
> # <fs type> <partition>
> # - Will mount -t <fs type> <partition> <mnt>, and
copy
> -# /proc/vmcore to <mnt>/<path>/%DATE/.
> +# /proc/vmcore to <mnt>/<path>/%HOST_IP-%DATE/.
> # NOTE: <partition> can be a device node, label or uuid.
> # It's recommended to use persistent device names
> # such as /dev/vg/<devname>.
> diff --git a/kdump.conf.5 b/kdump.conf.5
> index 11b1fad559b4..990076e9da6e 100644
> --- a/kdump.conf.5
> +++ b/kdump.conf.5
> @@ -55,7 +55,7 @@ The default value is /root/.ssh/kdump_id_rsa.
> .B <fs type> <partition>
> .RS
> Will mount -t <fs type> <partition> <mnt>, and copy /proc/vmcore
to
> -<mnt>/<path>/%DATE/. NOTE: <partition> can be a device node,
label
> +<mnt>/<path>/%HOST_IP-%DATE/. NOTE: <partition> can be a device
node, label
> or uuid. It's recommended to use persistent device names such as
> /dev/vg/<devname>. Otherwise it's suggested to use label or uuid.
> .RE
> --
> 2.7.4
>
Good catch!
Acked-by: Dave Young <dyoung(a)redhat.com>
Thanks, can we pick this for fedora kexec-tools?
Regards,
Bhupesh