On 12/07/2016:03:37:24 PM, Dave Young wrote:
Hi, Pratyush
>>>>>
>>>>> #raw /dev/vg/lv_kdump
>>>>> #ext4 /dev/vg/lv_kdump
>>>>> @@ -158,6 +171,7 @@ core_collector makedumpfile -l --message-level 1
-d 31
>>>>> #extra_modules gfs2
>>>>> #default shell
>>>>> #force_rebuild 1
>>>>> +#nowdt 1
>>>>
>>>> 1 should means true because it is not a shell script. So it conflicts
>>>> with our design?
>>>
>>> Yes, 1 means true, so when nowdt is true then do not include watchdog
module,
>>> right?
>>
>> Right, but the default behavior is including wdt module, so the comment
>> should be "nowdt 0"?
>
> OK, now going with dracut_argas, nowdt will not be used, but just for my
> knowledge, I was not knowing that we need to provide default option in comment.
> I thought, default is already there, so I should add a comment which one will
> need to change the default behavior.
>
Hmm, apologize that I did not notice that they are not consistent, some
of them use default value, other of them do not use default value. Just
like force_rebuild above it uses 1 so please ignore the comment.
But I still think dracut_args is better than a new option.
Yes, yes, I agreed on that. I will modify accordingly in my next revision.
~Pratyush