On 05/31/2017 at 03:21 AM, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma
<bhsharma(a)redhat.com> wrote:
> Resolves: BZ1433852
>
https://bugzilla.redhat.com/show_bug.cgi?id=1433852
>
> This patchset fixes a couple of issues reported by rpmlint
> when it is run on kexec-tools:
>
> 1. Patch 1 fixes several instances of hardcoded-library-path errors.
> 2. Patch 2 fixes a couple of whitespace errors.
>
> Bhupesh Sharma (2):
> kexec-tools.spec: Fix hardcoded-library-path errors
> kexec-tools.spec: Fix whitespace errors
>
> kexec-tools.spec | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.7.4
>
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there
are no further comments.
Hi Bhupesh,
I still got the following warnings/errors by rpmlint after applying your patches:
# fedpkg lint
No srpm found
No rpm found
/root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes
diskdumputils
/root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump
/root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes
kexec-tools-eppic
/root/git/kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR
/root/git/kexec-tools/kexec-tools.spec:1519: W: macro-in-%changelog %dir
/root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source23:
kdump-anaconda-addon-005-25-g2a4398f.tar.gz
/root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz
0 packages and 1 specfiles checked; 1 errors, 6 warnings.
Could not execute lint: Command 'rpmlint /root/git/kexec-tools/kexec-tools.spec'
returned non-zero exit status 64
Regards,
Xunlei