Hi Sourabh,
I can not figure out a better way at present, just a trick, see the
comment inline.
On 1/6/21 11:40 AM, piliu wrote:
On 12/21/20 12:16 AM, Sourabh Jain wrote:
> Tested the above patch successfully on PowerPC and x86 architecture
> with different memory configuration. The new script is able to
> return/print recommended memory values based on the system memory.
>
> Although the script works fine in most of the cases but I have found
> two cases where I am not sure whether the script behaviour is
> intentional or random.
>
> 1) for non-root user the System RAM in /proc/iomem is
> 00000000-00000000 so the script always returns the very first entry in
> ck_cmdline.
Yes, it is a challenge.
I had thought about something like "lsmem", but hesitate because
reserve_crashkernel() evaluates memory size by ioresource, which is
present to user space through /proc/iomem.
This is the core of the problem, which can not be stepped around easily.
But what about let kdump service runs the script and save the result in
a tmp file. Then later FFDC can read from the tmp file.
Or if FFDC can ask users to run as root?
Thanks,
Pingfan
While lsmem has a coarse grain, and can not realize the actual memory
size of non full populated memory block. Also it does not work on RHEL8
arm64 platform. (this API library is not only for FFDC, so we also want
it can run on other platforms )
>
> 2) There is no defined path for unsupported architectures. Can we
> avoid callingĀ get_recommend_size function if system architecture is
> not supported.
>
/proc/iomem is supported on arm64/s390x/powerpc/x86. For other
platforms, we just omit them.
Thanks,
Pingfan
> Thanks,
> Sourabh Jain
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
>
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
>
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
>
>
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org