On 11/08/16 at 05:20pm, Dave Young wrote:

On 11/08/16 at 02:42pm, Hari Bathini wrote:

Hi Dave,


Thanks for the review..

On Friday 04 November 2016 11:35 AM, Dave Young wrote:

Hi Hari,

Thanks for the update, except one nitpick see the inline comment
otherwise it looks good to me.

On 11/04/16 at 12:16am, Hari Bathini wrote:

When fadump mode is enabled, the default initrd is rebuilt with kdump
dracut module. As the default initrd is altered, the original default
initrd is backed up. But we are not restoring it when fadump mode is
disabled. This patch tries to restore the backed up default initrd on
disabling fadump mode.

Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>
---

Changes from v3:
* Added checksum verification while restoring initrd.
* Moved backup/restore logic under mode switch check.
* Moved mode switch check up to not miss restore while switching back
   to kdump (in case of a missing kdump initrd).


  kdumpctl |  105 +++++++++++++++++++++++++++++++++++++++++++++++++-------------
  1 file changed, 83 insertions(+), 22 deletions(-)

diff --git a/kdumpctl b/kdumpctl
index d0bbb55..6153f96 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -8,7 +8,10 @@ KDUMP_CONFIG_FILE="/etc/kdump.conf"
  MKDUMPRD="/sbin/mkdumprd -f"
  SAVE_PATH=/var/crash
  SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
+INITRD_CHECKSUM_LOCATION="/root/.fadump_initrd_checksum"

Can we use /boot/ instead of /root/ for the checksum?

Yeah. I am ok with that too. You want me to re-spin with that change?

No need, will wait about one week, if no other comments I will merge it
in Fedora.

Hari, applied the patches in Fedora rawhide, please feel free to do a test with
below build:

http://koji.fedoraproject.org/koji/buildinfo?buildID=817006

Hi Dave,