On 12/16/14 at 11:23am, Prarit Bhargava wrote:
On 11/17/2014 03:48 PM, Vivek Goyal wrote:
> On Mon, Nov 17, 2014 at 11:13:50AM -0500, Prarit Bhargava wrote:
>> With the inclusion of 'panic_on_warn',
>>
>>
http://marc.info/?l=linux-api&m=141570937328528&w=2
>>
>> and which is now staged in Andrew Morton's tree, we need to remove
>> 'panic_on_warn' from the 2nd kernel's cmdline. If it is included it
is
>> possible a non-fatal warning could panic the second kernel.
>
> This patch looks good to me. I think we can commit it once it show
> up in Linus tree.
>
> Acked-by: Vivek Goyal <vgoyal(a)redhat.com>
Dave and Vivek (who is on PTO),
The panic_on_warn patch has been committed into linux.git as
9e3961a0979817c612b10b2da4f3045ec9faa779 ("kernel: add panic_on_warn").
Thanks Prarit. I'll merge this one.
Thanks
WANG Chao
P.
>
> Thanks
> Vivek
>
>>
>> Before:
>>
>> [ 0.000000] Kernel command line: BOOT_IMAGE=/vmlinuz-3.10.0+
>> root=/dev/mapper/rhel_intel--canoepass--05-root ro
>> rd.lvm.lv=rhel_intel-canoepass-05/root
>> rd.lvm.lv=rhel_intel-canoepass-05/swap console=ttyS0,115200n81
>> LANG=en_US.UTF-8 systemd.debug panic_on_warn=1 irqpoll nr_cpus=1
>> reset_devices cgroup_disable=memory mce=off numa=off udev.children-max=2
>> panic=10 rootflags=nofail acpi_no_memhotplug disable_cpu_apicid=0
>> elfcorehdr=839092K
>>
>> After:
>>
>> [ 0.000000] Kernel command line: BOOT_IMAGE=/vmlinuz-3.10.0+
>> root=/dev/mapper/rhel_intel--canoepass--05-root ro
>> rd.lvm.lv=rhel_intel-canoepass-05/root
>> rd.lvm.lv=rhel_intel-canoepass-05/swap console=ttyS0,115200n81
>> LANG=en_US.UTF-8 systemd.debug irqpoll nr_cpus=1 reset_devices
>> cgroup_disable=memory mce=off numa=off udev.children-max=2 panic=10
>> rootflags=nofail acpi_no_memhotplug disable_cpu_apicid=0
>> elfcorehdr=839092K
>>
>> Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
>> ---
>> kdumpctl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kdumpctl b/kdumpctl
>> index ee3214a..a9e5d2e 100755
>> --- a/kdumpctl
>> +++ b/kdumpctl
>> @@ -105,7 +105,7 @@ prepare_cmdline()
>> else
>> cmdline=${KDUMP_COMMANDLINE}
>> fi
>> - cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages
hugepagesz`
>> + cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages
hugepagesz panic_on_warn`
>>
>>
>> cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
>> --
>> 1.7.9.3
>>
>> _______________________________________________
>> kexec mailing list
>> kexec(a)lists.fedoraproject.org
>>
https://lists.fedoraproject.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec