Hi Philipp,
Thanks for reviewing the patch!
On Tue, Jan 25, 2022 at 02:30:30PM +0100, Philipp Rudo wrote:
Hi Coiby,
On Tue, 25 Jan 2022 16:25:48 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
> This patch makes the default crashkernel value consistent with previous
> one.
>
> Fixes: 105c016 ("factor out kdump_get_arch_recommend_crashkernel")
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
> ---
> kdump-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kdump-lib.sh b/kdump-lib.sh
> index 0e64f22..79f7248 100755
> --- a/kdump-lib.sh
> +++ b/kdump-lib.sh
> @@ -861,7 +861,6 @@ kdump_get_arch_recommend_crashkernel()
> fi
> fi
>
> - _ck_cmdline=${_ck_cmdline//-:/-102400T:}
> echo -n "$_ck_cmdline"
> }
>
> @@ -877,6 +876,7 @@ kdump_get_arch_recommend_size()
> fi
> sys_mem=$(get_system_size)
> _ck_cmdline=$(kdump_get_arch_recommend_crashkernel)
> + _ck_cmdline=${_ck_cmdline//-:/-102400T:}
> get_recommend_size "$sys_mem" "$ck_cmdline"
> }
looks good
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
--
Best regards,
Coiby