On Thu, Jan 20, 2022 at 04:59:37PM +0800, Tao Liu wrote:
Hi Coiby,
On Thu, Jan 20, 2022 at 4:06 PM Coiby Xu <coxu(a)redhat.com> wrote:
>
> Hi Tao,
>
> Thanks for the patch!
>
> If we use wait, could the test hang because server VM somehow refuses to
> quit?
>
I think it won't hang if VM refuses to quit. You can see the process
tree of $(jobs -p):
run-test.sh,172455 /root/kexec-tools/tests/scripts/run-test.sh
--console nfs-early-kdump
└─run-test.sh,172457 /root/kexec-tools/tests/scripts/run-test.sh --console...
└─timeout,172480 --foreground 10m
/root/kexec-tools/tests/scripts/run-qemu...
└─qemu-system-x86,172481 -enable-kvm -cpu host -nodefaults...
├─{qemu-system-x86},172489
├─{qemu-system-x86},172492
├─{qemu-system-x86},172493
├─{qemu-system-x86},172628
└─{qemu-system-x86},172629
The qemu cmdline is wrapped by timeout. So even if the VM won't exit
itself, it will be killed by timeout 10m later.
So I think waiting for this process group won't hang.
Oh, I forgot the timeout wrapper. Thanks for the explanation!
Acked-by: Coiby Xu <coxu(a)redhat.com>