From: "Vivek Goyal" <vgoyal(a)redhat.com>
To: "Martin Perina" <mperina(a)redhat.com>
Cc: kexec(a)lists.fedoraproject.org
Sent: Thursday, March 27, 2014 8:51:59 PM
Subject: Re: [PATCH 3/6] fence_kdump for generic clusters v3: Move fence_kdump nodes
filtering into separate function
On Wed, Mar 26, 2014 at 10:24:09AM +0100, Martin Perina wrote:
> Move fence_kdump nodes filtering (they cannot contain `hostname`) into
> separate function get_list_of_nodes_to_notify. This will be also used by
> generic cluster fence_kdump configuration introduced in following patch.
>
> Bug-Url:
https://bugzilla.redhat.com/1079821
> Signed-off-by: Martin Perina <mperina(a)redhat.com>
> ---
> dracut-module-setup.sh | 27 ++++++++++++++++++++-------
> 1 file changed, 20 insertions(+), 7 deletions(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index 0ce3885..4aef4f8 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -415,6 +415,19 @@ kdump_check_iscsi_targets () {
> }
> }
>
> +# filter node list not to contain hostname
> +get_list_of_nodes_to_notify() {
> + local nodes
> +
> + for node in $1; do
> + if [ "$node" = `hostname` ]; then
> + continue
> + fi
> + nodes="$nodes $node"
> + done
> +
> + echo "$nodes"
> +}
>
> # setup fence_kdump in cluster
> # setup proper network and install needed files
> @@ -431,14 +444,14 @@ kdump_check_fence_kdump () {
> for node in ${nodelist}; do
> # convert $node from 'uname="nodeX"' to 'nodeX'
> eval $node
> - nodename=$uname
> - # Skip its own node name
> - if [ "$nodename" = `hostname` ]; then
> - continue
> - fi
> - nodes="$nodes $nodename"
> + nodes="$nodes $uname"
> + done
> +
> + nodes=$( get_list_of_nodes_to_notify "$nodes" )
A minor nit. Don't give spaces after bracket. Use.
nodes=$(get_list_of_nodes_to_notify "$nodes")
Otherwise patch looks good to me.
Vivek
>
> - kdump_install_net $nodename
> + # setup network to reach each node
> + for node in ${nodes}; do
> + kdump_install_net $node
> done
> echo
>
> --
> 1.8.3.1