On Wed, Mar 26, 2014 at 10:24:07AM +0100, Martin Perina wrote:
Bug-Url:
https://bugzilla.redhat.com/1079821
Signed-off-by: Martin Perina <mperina(a)redhat.com>
Can you provide changelog explaining what this patch is doing. We put
appropriate changelog for every patch in the series.
Also in general, have you tested it? Last time you mentioned that from
vdsm side you folks are still debating which method to use. I am assuming
that means vdsm code is not ready yet and that probably means this
patchset might be untested?
[..]
-FENCE_KDUMP_CONFIG="/etc/sysconfig/fence_kdump"
+FENCE_KDUMP_CONFIG_FILE="/etc/sysconfig/fence_kdump"
FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send"
FENCE_KDUMP_NODES="/etc/fence_kdump_nodes"
diff --git a/kdumpctl b/kdumpctl
index 8d5498a..24fb988 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -249,8 +249,8 @@ function check_rebuild()
EXTRA_BINS="$EXTRA_BINS $CHECK_FILES"
files="$KDUMP_CONFIG_FILE $kdump_kernel $EXTRA_BINS"
- if [ -f $FENCE_KDUMP_CONFIG ]; then
- files="$files $FENCE_KDUMP_CONFIG"
+ if [ -f $FENCE_KDUMP_CONFIG_FILE ]; then
+ files="$files $FENCE_KDUMP_CONFIG_FILE"
fi
why don't we get rid of this fence kdump config file. I thought we agreed
that fence_kdump_send options will be specified in /etc/kdump.conf using
a new option.
No package owns /etc/sysconfig/fence_kdump_send. So trying to retain
it does not make sense.
Thanks
Vivek