Re: [PATCH v5 1/2] Introduce kdump error handling service
On Wed, Jul 30, 2014 at 05:26:57PM +0800, WANG Chao wrote:
[..]
> > +dump_to_rootfs()
> > +{
> > +
> > + echo "Kdump: trying to bring up rootfs device"
> > + systemctl start dracut-initqueue
> > + echo "Kdump: waiting for rootfs mount, will timeout after 90
seconds"
> > + systemctl start sysroot.mount
>
> Will this ever try to enter emergency shell again (in case of failure?)
sysroot.mount wouldn't, only time out after 90 seconds.
But dracut-initqueue would enter kdump error handler again. I'm not sure
which is the best way to deal with dump_to_rootfs case.
a). Calling dracut-initqueue in kdump error handler, would cause a loop of
emergency -> dracut-initqueue -> emergency -> dracut-initqueue ... ,
if something's wrong within dracut-initqueue.
Can we drop a temporary file somewhere which indicates that we already
entered the kdump error hanlder. And if another invocation happens,
simply exit and do nothing?
So if dracut-initqueue fails and it tries to call kdump error handler,
that instance will simply exit.
Thanks
Vivek