Sure, the limit can instead be added in vmcore-dmesg.c too as long as it is sufficient to
defend kdump servers. Assert only may not be sufficient coz it needs to capture run-time
error in production version not just to exist in program debugging phase.
Thanks,
Jun
> On 08/09/19 at 06:33am, Jun Wang wrote:
>
> It is easy to add some assert in vmcore-dmesg.c to limit the write fd
> size and assert, so that do not add extra things in distribution.
>
> Also for the size 100M is not necessarily a good value, it would be good
> to keep same max as kernel is using. Even if it is corrupted thing, it
> is still not good to have a 100M limitation.
>
> Thanks
> Dave