On Wed, Feb 26, 2014 at 02:21:52PM +0800, WANG Chao wrote:
On s390x, RTC or hardware clock doesn't exist. So we don't
need
/etc/adjtime to adjust time to UTC or localtime.
AFAIK, s390 uses a more precise time source which is storing time in
UTC. But we still need /etc/localtime to determine the system-wide time
zone.
Chao, can you please explain a bit more in changelog.
What's the problem you are solving and how this change is going to solve
this problem. And also possibly explain why x86 does not have the same
problem.
Just above description does not tell me enough to be able to review the
patch.
Thanks
Vivek
Signed-off-by: WANG Chao <chaowang(a)redhat.com>
---
dracut-module-setup.sh | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 4e7d5dc..37a5fa5 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -460,6 +460,16 @@ kdump_install_random_seed() {
bs=$poolsize count=1 2> /dev/null
}
+# /etc/adjtime is used to determine RTC time format (UTC or localtime)
+# /etc/localtime is used to set system timezone
+kdump_install_time() {
+ # RTC doesn't exist on s390
+ if [ `uname -m` != "s390x" ]; then
+ dracut_install -o /etc/adjtime
+ fi
+ dracut_install -o /etc/localtime
+}
+
install() {
kdump_install_conf
>"$initdir/lib/dracut/no-emergency-shell"
@@ -467,7 +477,7 @@ install() {
if is_ssh_dump_target; then
kdump_install_random_seed
fi
- dracut_install -o /etc/adjtime /etc/localtime
+ kdump_install_time
inst "$moddir/monitor_dd_progress"
"/kdumpscripts/monitor_dd_progress"
chmod +x ${initdir}/kdumpscripts/monitor_dd_progress
inst "/bin/dd" "/bin/dd"
--
1.8.5.3
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec