On Fri, Dec 31, 2021 at 4:15 PM Coiby Xu <coxu(a)redhat.com> wrote:
On Fri, Dec 31, 2021 at 03:48:25PM +0800, Coiby Xu wrote:
>On Fri, Dec 31, 2021 at 02:42:17PM +0800, Tao Liu wrote:
>>Hi Coiby,
[...]
>>>>As for the file size of kdump.img, zstd makes a smaller size, which is
>>>>benificial for kdump kernel limited memory.
>>>>
>>>>As for the time consumption for compression when making kdump.img, zstd
>>>>doesn't show a clear advance than zlib.
>>> ^^^^^^^^^^^^^^^^^^
>>>Should it be "an obvious advantage over"?
>>
>>For bare metal x86_64 machine, zstd user time decrease for ~1s, sys
>>time increase for ~0.03s
>>For PowerVM hosted ppc64le VM, zstd user time varies for +1s ~ -7s,
>>sys time increase for ~0.03s
>>
>>I say "doesn't show a clear advance", meaning the time 1s may not
be
>>obviously observable to users.
>
>Thanks for the explanation. I haven't seen this phrase "a clear
advance"
>before. Maybe a different phrase should be used.
How about "the users may be oblivious to the change"?
OK, I will rephrase it in the v5 patch.
Thanks,
Tao Liu
--
Best regards,
Coiby