Since kdump-lib-initramfs.sh is included by kdump-lib.sh, and FENCE_KDUMP_SEND is used by both 1st and 2nd kernel, moving FENCE_KDUMP_SEND from kdump-lib.sh to kdump-lib-initramfs.sh.
Signed-off-by: Pingfan Liu piliu@redhat.com --- kdump-lib-initramfs.sh | 1 + kdump-lib.sh | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index c1fd75f..e309ed2 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -5,6 +5,7 @@
DEFAULT_PATH="/var/crash/" KDUMP_CONFIG_FILE="/etc/kdump.conf" +FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send"
# Read kdump config in well formated style kdump_read_conf() diff --git a/kdump-lib.sh b/kdump-lib.sh index ca086d7..8581650 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -6,7 +6,6 @@ . /usr/lib/kdump/kdump-lib-initramfs.sh
FENCE_KDUMP_CONFIG_FILE="/etc/sysconfig/fence_kdump" -FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send" FADUMP_ENABLED_SYS_NODE="/sys/kernel/fadump_enabled"
is_fadump_capable()
Hi Pingfan,
On Wed, Jan 12, 2022 at 7:23 PM Pingfan Liu piliu@redhat.com wrote:
Since kdump-lib-initramfs.sh is included by kdump-lib.sh, and FENCE_KDUMP_SEND is used by both 1st and 2nd kernel, moving FENCE_KDUMP_SEND from kdump-lib.sh to kdump-lib-initramfs.sh.
Signed-off-by: Pingfan Liu piliu@redhat.com
kdump-lib-initramfs.sh | 1 + kdump-lib.sh | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index c1fd75f..e309ed2 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -5,6 +5,7 @@
DEFAULT_PATH="/var/crash/" KDUMP_CONFIG_FILE="/etc/kdump.conf" +FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send"
# Read kdump config in well formated style kdump_read_conf() diff --git a/kdump-lib.sh b/kdump-lib.sh index ca086d7..8581650 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -6,7 +6,6 @@ . /usr/lib/kdump/kdump-lib-initramfs.sh
FENCE_KDUMP_CONFIG_FILE="/etc/sysconfig/fence_kdump" -FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send" FADUMP_ENABLED_SYS_NODE="/sys/kernel/fadump_enabled"
FENCE_KDUMP_CONFIG_FILE and FENCE_KDUMP_SEND are fence related constants. Though FENCE_KDUMP_CONFIG_FILE is not used in the 2nd kernel, I think it is not harmful to keep the fence related constants together for better maintenance. What do you think?
Thanks, Tao Liu
is_fadump_capable()
2.31.1
On Fri, Jan 14, 2022 at 10:42 AM Tao Liu ltao@redhat.com wrote:
Hi Pingfan,
On Wed, Jan 12, 2022 at 7:23 PM Pingfan Liu piliu@redhat.com wrote:
Since kdump-lib-initramfs.sh is included by kdump-lib.sh, and FENCE_KDUMP_SEND is used by both 1st and 2nd kernel, moving FENCE_KDUMP_SEND from kdump-lib.sh to kdump-lib-initramfs.sh.
Signed-off-by: Pingfan Liu piliu@redhat.com
kdump-lib-initramfs.sh | 1 + kdump-lib.sh | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index c1fd75f..e309ed2 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -5,6 +5,7 @@
DEFAULT_PATH="/var/crash/" KDUMP_CONFIG_FILE="/etc/kdump.conf" +FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send"
# Read kdump config in well formated style kdump_read_conf() diff --git a/kdump-lib.sh b/kdump-lib.sh index ca086d7..8581650 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -6,7 +6,6 @@ . /usr/lib/kdump/kdump-lib-initramfs.sh
FENCE_KDUMP_CONFIG_FILE="/etc/sysconfig/fence_kdump" -FENCE_KDUMP_SEND="/usr/libexec/fence_kdump_send" FADUMP_ENABLED_SYS_NODE="/sys/kernel/fadump_enabled"
FENCE_KDUMP_CONFIG_FILE and FENCE_KDUMP_SEND are fence related constants. Though FENCE_KDUMP_CONFIG_FILE is not used in the 2nd kernel, I think it is not harmful to keep the fence related constants together for better maintenance. What do you think?
Yeah, I had a similar idea originally. I will send out V2.
Thanks
Thanks, Tao Liu
is_fadump_capable()
2.31.1
-
Pingfan Liu -
Tao Liu