On 05/06/14 at 03:40pm, Vivek Goyal wrote:
Thanks for bringing this up. I never really looked into these problems.
I have few questions.
- What is makedumpfile-1.4.2.tar.gz ? IIUC, kexec-tools.spec seem to
suggest that during build following tar file needs to be downloaded.
I don't see makedumpfile-1.4.2.tar.gz. In fact, you can see all the
files in our repo through:
Another thing is I think makedumpfile-1.5.6 (or any source file) is
downloaded from the lookaside cache which is uploaded manually, not
directly downloaded from upstream source.
Does that mean makedumpfile-1.4.2.tar.gz is redundant?
- Should we maintain a cache of makedumpfile tar file on fedora server
(like kexec-tools tar file), instead of relying on download.sourceforge.net
I feel it is better to maintain one on fedora server cache.
Yes, rigtht. Upstream server could be broken or invalid and that's why we need
to upload our source to fedora lookaside server.
- I see one entry for makedumpfile in "sources" file. So does that mean
we are already maintaining makedumpfile with said hash. If yes, does
that mean entry in spec file is redundant?
I don't think that upstream entry is redundant. It can tell people where
the source file originally comes from.
I find this:
- We have tons of entries in .gitignore file. Should we remove entry for
older version of kexec-tools and makedumpfile from the file. Why should
we continue to ignore older versions of these?
File ".gitignore" and "source" is automatically updated when uploading
new source to fedora server. I deleted the old entry in file "source"
but I never did that for file ".gitignore". I guess you're right, I
should delelte them too.
I'll clean up the old entries in .gitignore later.
- Similarly why are we carrying kexec-tools-2.0.3.tar.bz2 in the tree?
- What about kexec-tools-po.tar.gz?
.gitignore contains lots of old entries. Probably that's why you can
still see these old kexec-tools, makedumpfile after "fedpkg clean".