Hi Coiby,
On Mon, Dec 27, 2021 at 9:35 AM Coiby Xu <coxu(a)redhat.com> wrote:
On Fri, Dec 24, 2021 at 05:32:35PM +0800, Tao Liu wrote:
>Hi Coiby,
>
>On Thu, Dec 23, 2021 at 3:50 PM Coiby Xu <coxu(a)redhat.com> wrote:
>>
>> Hi Tao,
>>
>> Thanks for the patch!
>>
>> On Sat, Dec 18, 2021 at 04:14:44PM +0800, Tao Liu wrote:
>> >For earlykdump, kdump-lib-initramfs.sh is sourced by kdump-lib.sh,
>> >however it is not installed in dracut-early-kdump-module-setup.sh. Same
>> >as xargs, which is used by kdump-lib.sh. Otherwise earlykdump will report
>> >file not found errors.
>>
>> Should we install /usr/bin/xargs in dracut-module-setup.sh as well since
>> it also sources kdump-lib.sh
>>
>I think it is not needed.
>
>As for earlykdump, kdump-lib.sh/xargs are used both for making
>initramfs-kdump.img in 1st kernel, and the runtime in 2nd kernel, so
>xargs/kdump-lib.sh must be installed in initramfs-kdump.img. However,
>as for non-earlykdump, kdump-lib.sh/xargs are used only for making
>initramfs-kdump.img in the 1st kernel, and can both be accessed
>locally, needn't to be installed in initramfs-kdump.img for 2nd kernel
>runtime use.
Thanks for the explanation! Patch has been merged with a small change
about the format of "Fixes:" tag,
Fixes: a5faa052d4969cb66719d0b795d746449d3c71b7
("kdump-lib-initramfs.sh: prepare to be a POSIX compatible lib")
Fixes: 4f01cb1b0a4e1ea9467e9ace34d14dcb2fbe135a
("kdump-lib.sh: fix variable quoting issue")
Acked-by: Coiby Xu <coxu(a)redhat.com>
>
OK, thanks for the info.
Thanks,
Tao Liu
>Thanks,
>Tao Liu
>> >
>> >Fixes ("a5faa052d4969cb66719d0b795d746449d3c71b7") for
kdump-lib-initramfs.sh
>> > kdump-lib-initramfs.sh: prepare to be a POSIX compatible lib
>> >And ("4f01cb1b0a4e1ea9467e9ace34d14dcb2fbe135a") for xargs
>> > kdump-lib.sh: fix variable quoting issue
>> >
>> >Signed-off-by: Tao Liu <ltao(a)redhat.com>
>> >---
>> > dracut-early-kdump-module-setup.sh | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> >diff --git a/dracut-early-kdump-module-setup.sh
b/dracut-early-kdump-module-setup.sh
>> >index 0e46823..0451118 100755
>> >--- a/dracut-early-kdump-module-setup.sh
>> >+++ b/dracut-early-kdump-module-setup.sh
>> >@@ -50,7 +50,9 @@ install() {
>> > inst_binary "/usr/bin/gawk" "/usr/bin/awk"
>> > inst_binary "/usr/bin/logger" "/usr/bin/logger"
>> > inst_binary "/usr/bin/printf" "/usr/bin/printf"
>> >+ inst_binary "/usr/bin/xargs" "/usr/bin/xargs"
>> > inst_script "/lib/kdump/kdump-lib.sh"
"/lib/kdump-lib.sh"
>> >+ inst_script "/lib/kdump/kdump-lib-initramfs.sh"
"/lib/kdump/kdump-lib-initramfs.sh"
>> > inst_script "/lib/kdump/kdump-logger.sh"
"/lib/kdump-logger.sh"
>> > inst_hook cmdline 00 "$moddir/early-kdump.sh"
>> > inst_binary "$KDUMP_KERNEL"
>> >--
>> >2.33.1
>> >
>>
>> --
>> Best regards,
>> Coiby
>>
>
--
Best regards,
Coiby