Hello Kairui,
On Fri, Apr 16, 2021 at 07:31:04PM +0800, Kairui Song wrote:
On Fri, Apr 16, 2021 at 6:42 PM Tao Liu <ltao(a)redhat.com>
wrote:
>
> dracut-squash is not a must-have component for kexec, nor essential for
> minimal host installations as BaseOS or CoreOS. Link [1][2] has already
> changed dracut-squash dependency from "Requires" to
"Recommends". As quoting
> the RHEL 9 Content Structure and Guidelines: "Weak dependencies are allowed,
> but discouraged." Let's drop the dependency.
>
> [1]:
https://github.com/coreos/fedora-coreos-config/pull/708
> [2]:
https://src.fedoraproject.org/rpms/kexec-tools/pull-request/4#
>
> Signed-off-by: Tao Liu <ltao(a)redhat.com>
> ---
> kexec-tools.spec | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kexec-tools.spec b/kexec-tools.spec
> index 91bc0f3..dafb672 100644
> --- a/kexec-tools.spec
> +++ b/kexec-tools.spec
> @@ -61,7 +61,6 @@ Requires(postun): systemd-units
> Requires(pre): coreutils sed zlib
> Requires: dracut >= 050
> Requires: dracut-network >= 050
> -Recommends: dracut-squash >= 050
> Requires: ethtool
> BuildRequires: make
> BuildRequires: zlib-devel elfutils-devel glib2-devel bzip2-devel ncurses-devel
bison flex lzo-devel snappy-devel
> --
> 2.29.2
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
> Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Hmm, I'm afraid this may result in a lot of OOMs on most machines with
default crashkernel value, and we'll have crashkernel=auto, it's value
will be assuming the initramfs will not consume a lot of memory, which
is not very achievable without the squash module.
Thanks for pointing it out, I haven't considered this case.
Some distro like CoreOS really don't need the squash module, so we
made it a recommandation, but for Fedora/RHEL it's really needed. I
think we can have an exception here as a weak dependency. Just my
personal idea...
Looks like dracut-squash is a must-have component for BaseOS of Fedora/RHEL,
but optional for CoreOS.
The existence of dracut-squash is to make Fedora/RHEL to run properly, in case
we are in memory shortage. But the absence of dracut-squash doesn't break any
function of kexec. So will it be better to remove the dracut-squash dependency
from kexec, and make dracut-squash listed in the @core group of BaseOS of
Fedora/RHEL?
From link [3] I can get the package list of rhel8 BaseOS, which shows
dracut-squash is already on the list. But I need to double check that.
[3]:
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/...
Thanks,
Tao Liu
--
Best Regards,
Kairui Song