Bond options in ifcfg is space separated, dracut expected it to be comma separated, so it have to be parsed and converted during initramfs building.
The currently parsing and convert pattern is flawed, for example: " downdelay=0 miimon=100 mode=802.3ad updelay=0 "
is converted to : ":,downdelay=0 miimon=100 mode=802.3ad updelay=0 "
should be: ":downdelay=0,miimon=100,mode=802.3ad,updelay=0"
So fix this issue by using more simple but robust method for processing the options.
Signed-off-by: Kairui Song kasong@redhat.com --- dracut-module-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 3fa696d..abf56c7 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -264,7 +264,7 @@ kdump_setup_bond() {
source_ifcfg_file $_netdev
- bondoptions="$(echo :$BONDING_OPTS | sed 's/\s+/,/')" + bondoptions=":$(echo $BONDING_OPTS | tr " " ",")" echo "$bondoptions" >> ${initdir}/etc/cmdline.d/42bond.conf }
On Thu, Aug 22, 2019 at 3:28 PM Kairui Song kasong@redhat.com wrote:
Bond options in ifcfg is space separated, dracut expected it to be comma separated, so it have to be parsed and converted during initramfs building.
The currently parsing and convert pattern is flawed, for example: " downdelay=0 miimon=100 mode=802.3ad updelay=0 "
is converted to : ":,downdelay=0 miimon=100 mode=802.3ad updelay=0 "
should be: ":downdelay=0,miimon=100,mode=802.3ad,updelay=0"
So fix this issue by using more simple but robust method for processing the options.
Signed-off-by: Kairui Song kasong@redhat.com
dracut-module-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 3fa696d..abf56c7 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -264,7 +264,7 @@ kdump_setup_bond() {
source_ifcfg_file $_netdev
- bondoptions="$(echo :$BONDING_OPTS | sed 's/\s+/,/')"
- bondoptions=":$(echo $BONDING_OPTS | tr " " ",")" echo "$bondoptions" >> ${initdir}/etc/cmdline.d/42bond.conf
}
-- 2.21.0
V2 is sent, self-nak this one.