----- Original Message -----
From: "Ziyue Yang" <ziyang(a)redhat.com>
To: "Pingfan Liu" <piliu(a)redhat.com>
Cc: "Dave Young" <dyoung(a)redhat.com>, kexec(a)lists.fedoraproject.org
Sent: Wednesday, July 26, 2017 3:10:27 PM
Subject: Re: [PATCH] kdump-lib.sh: support dump ssh via local ipv6 address
Hi,
On Wed, Jul 26, 2017 at 2:36 PM, Pingfan Liu <piliu(a)redhat.com> wrote:
> Hi,
>
> I had two comments like the following
>
>
>
> ----- Original Message -----
> > From: "Dave Young" <dyoung(a)redhat.com>
> > To: "Ziyue Yang" <ziyang(a)redhat.com>
> > Cc: kexec(a)lists.fedoraproject.org
> > Sent: Tuesday, July 25, 2017 2:56:46 PM
> > Subject: Re: [PATCH] kdump-lib.sh: support dump ssh via local ipv6
> address
> >
> > Hi Ziyue,
> > On 07/18/17 at 12:48pm, Ziyue Yang wrote:
> > > When dumping to ssh via local ipv6 address, the ssh parameter
> > > in kdump.conf is supposed to have the form like
> > >
> > > ssh user@fe80::cc1:8bff:fe90:b95f%eth0
> > >
>
> Shall we use "[]" for ipv6 addr? I.e user@[fe80::cc1:8bff:fe90:b95f%eth0]
> ?
>
"[]" is not required here, using "[]" would cause "name or
service unknown"
error.
Ah, this is not the real cmd to execute ssh, just the format in kdump.conf.
I guess this based on the following commit:
commit c994a80698b6b12e50791b36fe40ae36485098d0
Author: Minfei Huang <mhuang(a)redhat.com>
Date: Thu Jul 23 18:29:24 2015 +0800
dracut-module-setup: Support the network for ipv6 protocol
> > > where "%eth0" is an existing network interface supporting ipv6.
> > >
> > > However, the get_remote_host function in kdump-lib.sh currently
> > > doesn't remove the network interface in the ipv6 address,
> > > causing the ip command in kdump_install_net function to fail,
> > > leading to a "Bad kdump location" message.
> > >
> > > This patch supports dumping ssh via local ipv6 address by enabling
> > > get_remote_host function to remove network interface in ipv6 addresses
> > > if there are any.
> >
> > The patch looks good, but I still want to defer this until Pingfan
> > get the ipv6 test cases passed.
> >
>
> During my test, the dump failed, since in 2nd kernel, the eth0 is renamed
> as kdump-eth0, but the kdump still use the ipaddr
> fe80::cc1:8bff:fe90:b95f%eth0.
>
I used "ens3" in my QEMU instance, and the following is the kdump log:
[ 2.393800] e1000: Intel(R) PRO/1000 Network Driver - version
7.3.21-k8-NAPI
[ 2.394700] e1000: Copyright (c) 1999-2006 Intel Corporation.
[ 2.407918] ata_id (261) used greatest stack depth: 12528 bytes left
[ 2.841918] ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 11
[ 3.224831] e1000 0000:00:03.0 eth0: (PCI:33MHz:32-bit) 52:54:00:12:34:56
[ 3.226226] e1000 0000:00:03.0 eth0: Intel(R) PRO/1000 Network Connection
[ 3.232991] e1000 0000:00:03.0 ens3: renamed from eth0
[ 3.386730] IPv6: ADDRCONF(NETDEV_UP): ens3: link is not ready
[ 3.392806] ip (301) used greatest stack depth: 11584 bytes left
[ 3.411737] dracut-initqueue[251]: RTNETLINK answers: Network is
unreachable
[ 5.409269] e1000: ens3 NIC Link is Up 1000 Mbps Full Duplex, Flow
Control: RX
[ 5.412466] IPv6: ADDRCONF(NETDEV_CHANGE): ens3: link becomes ready
Seems once it renames eth0 to ens3, the dumping process is good to go
Yes, this is caused by kdump_setup_ifname(). So a way is required to survive the
case eth*
>
> >
> > Regards,
> > Pingfan
> > > >
> > > > Signed-off-by: Ziyue Yang <ziyang(a)redhat.com>
> > > > ---
> > > > kdump-lib.sh | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/kdump-lib.sh b/kdump-lib.sh
> > > > index 3f0af91..cca68e5 100755
> > > > --- a/kdump-lib.sh
> > > > +++ b/kdump-lib.sh
> > > > @@ -323,6 +323,10 @@ get_remote_host()
> > > > _config_val=${_config_val%:/*}
> > > > _config_val=${_config_val#[}
> > > > _config_val=${_config_val%]}
> > > > + # factor out network inteface segment in local ipv6 address
> > > > + if is_ipv6_address $_config_val; then
> > > > + _config_val=${_config_val%%%*}
> > > > + fi
> > > > echo $_config_val
> > > > }
> > > >
> > > > --
> > > > 2.9.3
> > > > _______________________________________________
> > > > kexec mailing list -- kexec(a)lists.fedoraproject.org
> > > > To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> > >
> > > Thanks
> > > Dave
> > > _______________________________________________
> > > kexec mailing list -- kexec(a)lists.fedoraproject.org
> > > To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> > >
> >
>