On Thu, May 5, 2022 at 9:30 AM Coiby Xu <coxu(a)redhat.com> wrote:
On Fri, Apr 29, 2022 at 03:37:40PM +0800, Pingfan Liu wrote:
>s390x implements zlib/dfltcc dedicated instruction to improve
>compression speed and ratio. Switching from 'makedumpfile -l' to
>'makedumpfile -c' to benifit from this feature.
>
>Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
>---
> kexec-tools.spec | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/kexec-tools.spec b/kexec-tools.spec
>index 6673000..9f1ba34 100644
>--- a/kexec-tools.spec
>+++ b/kexec-tools.spec
>@@ -275,6 +275,10 @@ fi
> %systemd_post kdump.service
>
> touch /etc/kdump.conf
As a side question, why do we run "touch /etc/kdump.conf" since we
have already installed /etc/kdump.conf?
Sorry that I can not answer this question. I search the history, in
rhel-6.9 branch,
It is introduced by the following commit, without why.
commit 74ba561a519b813424693bcf13f77ad7cacc02ee
Author: nhorman <nhorman(a)redhat.com>
Date: Thu Jul 20 03:36:18 2006 +0000
adding kexec frontend
SKIPPED:
Makefile
Makefile.kcp
kexec-tools-1.101-Makefile-kcp.patch
>+# s390 uses zlib/dfltcc as default to improve compression speed
and ratio
>+%ifarch s390x
>+sed -i 's/makedumpfile -l/makedumpfile -c/' /etc/kdump.conf
>+%endif
Does this change contradict the RPM config policy as defined in
%config(noreplace,missingok) %verify(not mtime) %{_sysconfdir}/kdump.conf?
For 'noreplace', I see the contradiction as Philipp pointed out.
Thanks,
Pingfan