By default, NetworkManger will manage all the network interfaces and try to set interface IFF_UP to get carrier state. Regardless of whether the network interface is connected to a cable or not, the NIC driver will allocate memory resources for e.g. ring buffers when setting IFF_UP. This could be a waste of memory. For example it's found i40e consumes ~15GB on a power machine. On this machine, i40e manages four interfaces but only one interface is valid. This patch use "managed=false" to tell NetworkManager to not manage network interfaces that are not needed by kdump by putting /etc/NetworkManager/conf.d/10-kdump-netif.conf in the initramfs. Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; --- dracut-module-setup.sh | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 75f82af..d6ad3ba 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -348,7 +348,7 @@ kdump_setup_ifname() { kdump_copy_nmconnection_file() { local _dev _nmconnection_file_path _nmconnection_name _initrd_nmconnection_file_path - local _cloned_nmconnection_file_path _uniq_name _old_uuid _old_name _uuid + local _cloned_nmconnection_file_path _uniq_name _old_uuid _old_name _uuid _per_mac _dev="$1" @@ -377,9 +377,31 @@ kdump_copy_nmconnection_file() { # user's custom value could overwrite it sed -i -E 's/(\[connection\])/\1\nwait-device-timeout=60000/' "${initdir}/$_initrd_nmconnection_file_path" + _per_mac=$(kdump_get_perm_addr "$_dev") + if [[ "$_per_mac" != 'not set' ]]; then + echo -n "except:mac:$_per_mac," >> "/tmp/$$-netif_allowlist"

+ else + echo -n "except:interface-name:$_dev," >> "/tmp/$$-netif_allowlist" + fi + nmcli connection del "$_uuid" } +kdump_install_nm_netif_allowlist() { + local _netif_allowlist + + _netif_allowlist=$(cat "/tmp/$$-netif_allowlist") + cat <<- EOF > "/tmp/$$-10-kdump-netif.conf" + [device-others] + match-device=${_netif_allowlist}

+ managed=false + EOF + + inst "/tmp/$$-10-kdump-netif.conf" "/etc/NetworkManager/conf.d/10-kdump-netif.conf" + rm -f "/tmp/$$-10-kdump-netif.conf" + rm -f "/tmp/$$-netif_allowlist" +} + kdump_setup_bridge() { local _netdev=$1 local _brif _dev _mac _kdumpdev

NetworkManager defaults to use keyfile i.e. .nmconnnection file but still supports reading ifcfg-* file [1]. Make use of "nmcli connection clone --temporary" to automatically convert a ifcfg-* file to a .nmconnection file. [1] https://fedoraproject.org/wiki/Changes/NetworkManager_keyfile_instead_of_... Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; --- dracut-module-setup.sh | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 3b6b1c3..91bebcb 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -348,12 +348,30 @@ kdump_setup_ifname() { kdump_copy_nmconnection_file() { local _dev _nmconnection_file_path _nmconnection_name _initrd_nmconnection_file_path + local _cloned_nmconnection_file_path _uniq_name _old_uuid _old_name _uuid

+ _dev="$1" _nmconnection_file_path=${nmconnection_map[$_dev]} _nmconnection_name=$(basename "$_nmconnection_file_path") _initrd_nmconnection_file_path="/etc/NetworkManager/system-connections/$_nmconnection_name" - inst "$_nmconnection_file_path" "$_initrd_nmconnection_file_path" + + _old_uuid=$(nmcli --get-values connection.uuid c show "$_nmconnection_file_path") + _old_name=$(nmcli --get-values connection.id c show "$_nmconnection_file_path") + _uniq_name=$(cat /proc/sys/kernel/random/uuid) + + nmcli connection clone --temporary "$_nmconnection_file_path" "$_uniq_name" + _uuid=$(nmcli --get-values connection.uuid c show "$_uniq_name") + # change back connection.id for the sake of readibility + nmcli connection modify --temporary "$_uuid" connection.id "$_old_name" + + _cloned_nmconnection_file_path=$(nmcli -g UUID,FILENAME connection show | sed -n "s/^${_uuid}://p")

+ inst "$_cloned_nmconnection_file_path" "$_initrd_nmconnection_file_path" + # change uuid back to old value in case it's refered by other connection + # profile e.g. connection.master could be Interface name of the master + # device or UUID of the master connection. + sed -i -r "s/(^uuid=).*$/\1${_old_uuid}/g" "${initdir}/$_initrd_nmconnection_file_path" + nmcli connection del "$_uuid" } kdump_setup_bridge() {

Hi Coiby, On Sat, 2 Apr 2022 11:23:45 +0800 Coiby Xu <coxu(a)redhat.com&gt; wrote: > Each network interface is manged by a NM connection. Given a network > interface name, this function will be used to copy a NetworkManager (NM) > connection profile i.e. a .nmconnection file to the kdump initramfs. > > Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; > --- > dracut-module-setup.sh | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh > index 02e7334..3b6b1c3 100755 > --- a/dracut-module-setup.sh > +++ b/dracut-module-setup.sh > @@ -346,6 +346,16 @@ kdump_setup_ifname() { > echo "$_ifname" > } > > +kdump_copy_nmconnection_file() { > + local _dev _nmconnection_file_path _nmconnection_name _initrd_nmconnection_file_path > + _dev="$1" > + > + _nmconnection_file_path=${nmconnection_map[$_dev]} > + _nmconnection_name=$(basename "$_nmconnection_file_path") > + _initrd_nmconnection_file_path="/etc/NetworkManager/system-connections/$_nmconnection_name" > + inst "$_nmconnection_file_path" "$_initrd_nmconnection_file_path" > +} in the end this function gets quite large and (at least for me as a network simpleton) quite hard to read. Is there a way to split it up in multiple functions?

> + > kdump_setup_bridge() { > local _netdev=$1 > local _brif _dev _mac _kdumpdev > @@ -534,6 +544,12 @@ kdump_install_net() { > local _destaddr _srcaddr _route _netdev _conpath kdumpnic > local _static _proto _ip_conf _ip_opts _ifname_opts > local _znet_netdev _znet_conpath > + # each netowrk interface is managed by a NM connection profile > + declare -A nmconnection_map > + > + while read -r _ifname _nmconn; do > + nmconnection_map[$_ifname]="$_nmconn" > + done <<< "$(nmcli -f device,filename connection show --active | tail -n +2)" nmcli has the -t, --terse option to suppress printing of the header line.

Thanks Philipp > > _destaddr=$(kdump_get_remote_ip "$1") > _route=$(kdump_get_ip_route "$_destaddr")

Hi Coiby, On Sat, 2 Apr 2022 11:23:47 +0800 Coiby Xu <coxu(a)redhat.com&gt; wrote: > During boot, it may take some time for a device driver to detect the > its devices. By default, NetworkManager doesn't wait for the device to > be available (this is not an issue for the 1st kernel because NM keeps > running in the 1st kernel). So we need to set > connection.wait-device-timeout=60000 [1] as the same to nm-initrd-generator > to tell NM to wait for 6s. Otherwise dracut-kdump-capture.service would > fail because network isn't ready. Note the user's custom value for > wait-device-timeout is respected. > > Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; > --- > dracut-module-setup.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh > index 91bebcb..75f82af 100755 > --- a/dracut-module-setup.sh > +++ b/dracut-module-setup.sh > @@ -371,6 +371,12 @@ kdump_copy_nmconnection_file() { > # profile e.g. connection.master could be Interface name of the master > # device or UUID of the master connection. > sed -i -r "s/(^uuid=).*$/\1${_old_uuid}/g" "${initdir}/$_initrd_nmconnection_file_path" > + > + # Ask NM to wait 60s for the network device to be available > + # wait-device-timeout=60000 is inserted after "[connection]" so the > + # user's custom value could overwrite it > + sed -i -E 's/(\[connection\])/\1\nwait-device-timeout=60000/' "${initdir}/$_initrd_nmconnection_file_path" you can use sed -i '/\[connection\]/a wait-device-timeout=60000/' $file to add a line after a match

Thanks Philipp > + > nmcli connection del "$_uuid" > } >

Coiby Xu <coxu(a)redhat.com&gt; 于2022年4月2日周六 11:24写道： > > kexec-tools depends on dracut's 35network-manager module which will > call nm-initrd-generator. We don't want nm-initrd-generator to generate > connection profiles since we will copy them from 1st kernel to > kdump kernel initramfs. NetworkManager >= 1.35.2 won't generate connection > profiles if there's a connection dir with rd.neednet. For Fedora/RHEL, > this connection dir is /etc/NetworkManager/system-connections. For the > details, please refer to the NetworkManager commit 79885656d3 > ("initrd: don't add a connection if there's a connection dir with > rd.neednet") [1]. Before the release of NetworkManager >= 1.35.2, we > need to mask /usr/libexec/nm-initrd-generator. > > [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requ... > > Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; > --- > dracut-module-setup.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh > index d6ad3ba..afeac3c 100755 > --- a/dracut-module-setup.sh > +++ b/dracut-module-setup.sh > @@ -655,6 +655,11 @@ kdump_install_net() { > echo "rd.neednet" >> "${initdir}/etc/cmdline.d/50neednet.conf" > fi > > + # Stop dracut 35network-manger to calling nm-initrd-generator. > + # Note this line of code can be removed after NetworkManager >= 1.35.2 > + # gets released. > + echo > "${initdir}/usr/libexec/nm-initrd-generator" > + initramfs for local dump won't include this file, so maybe only mask it only when it exists?

> # Save netdev used for kdump as cmdline > # Whoever calling kdump_install_net() is setting up the default gateway, > # ie. bootdev/kdumpnic. So don't override the setting if calling > -- > 2.34.1 > _______________________________________________ > kexec mailing list -- kexec(a)lists.fedoraproject.org > To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org > Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

On Sat, Apr 23, 2022 at 10:47:57PM +0800, Kairui Song wrote: >Coiby Xu <coxu(a)redhat.com&gt; 于2022年4月2日周六 11:25写道： >> >> A NIC may get a different name in the kdump kernel from 1st kernel >> in cases like, >> - kernel assigned network interface names are not persistent e.g. [1] >> - there is an udev rule to rename the NIC in the 1st kernel but the >> kdump initrd may not have that rule e.g. [2] >> >> If NM tries to match a NIC with a connection profile based on NIC name >> i.e. connection.interface-name, it will fail the above bases. So we >> should remove the line connection.interface-name=XX from the connection >> file. With this line deleted, multiple NICs may be matched by a >> connection profile but we don't need to worry about a wrong NIC is >> brought up by NM since we have explicitly asked NM to only bring up the >> NICs needed by kdump via /etc/NetworkManager/conf.d/10-kdump-netif.conf. >> Note we don't need to do this for user created NIC like vlan, bridge and >> bond. >> >> An remaining issue is passing the name of a NIC via the kdumpnic dracut >> command line parameter which requires passing ifname=<interface>:<MAC> to >> have fixed NIC name. But we can simply drop this requirement. kdumpnic >> is needed because kdump needs to get the IP by NIC name and use the IP >> to created a dumping folder named "{IP}-{DATE}". We can simply pass the >> IP to the kdump kernel directly via a new dracut command line parameter >> kdumpip instead. In addition to the benefit of simplifying the code, >> there are other three benefits brought by this approach, >> - make use of whatever network to transfer the vmcore. Because as long >> as we have the network to we don't care which NIC is active. >> - if obtained IP in the kdump kernel is different from the one in the >> 1st kernel. "{IP}-{DATE}" would better tell where the dumped vmcore >> comes from. >> - without passing ifname=<interface>:<MAC> to to kdump initrd, the >> issue of there are two interfaces with the same MAC address for >> Azure Hyper-V NIC SR-IOV [3] is resolved automatically. >> >> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1121778 >> [2] https://bugzilla.redhat.com/show_bug.cgi?id=810107 >> [3] https://bugzilla.redhat.com/show_bug.cgi?id=1962421 >> >> Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; >> --- >> dracut-kdump.sh | 18 ++++-------------- >> dracut-module-setup.sh | 38 ++++++++++++++------------------------ >> 2 files changed, 18 insertions(+), 38 deletions(-) >> >> diff --git a/dracut-kdump.sh b/dracut-kdump.sh >> index b69bc98..e27be61 100755 >> --- a/dracut-kdump.sh >> +++ b/dracut-kdump.sh >> @@ -475,22 +475,12 @@ save_vmcore_dmesg_ssh() >> get_host_ip() >> { >> if is_nfs_dump_target || is_ssh_dump_target; then >> - kdumpnic=$(getarg kdumpnic=) >> - if [ -z "$kdumpnic" ]; then >> - derror "failed to get kdumpnic!" >> + kdumpip=$(getarg kdumpip=) >> + if [ -z "$kdumpip" ]; then >> + derror "failed to get kdumpip!" >> return 1 >> fi >> - if ! kdumphost=$(ip addr show dev "$kdumpnic" | grep '[ ]*inet'); then >> - derror "wrong kdumpnic: $kdumpnic" >> - return 1 >> - fi >> - kdumphost=$(echo "$kdumphost" | head -n 1 | awk '{print $2}') >> - kdumphost="${kdumphost%%/*}" >> - if [ -z "$kdumphost" ]; then >> - derror "wrong kdumpnic: $kdumpnic" >> - return 1 >> - fi >> - HOST_IP=$kdumphost >> + HOST_IP=$kdumpip >> fi >> return 0 >> } >> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh >> index c05666e..8b28141 100755 >> --- a/dracut-module-setup.sh >> +++ b/dracut-module-setup.sh >> @@ -210,26 +210,6 @@ kdump_get_perm_addr() { >> fi >> } >> >> -# Prefix kernel assigned names with "kdump-". EX: eth0 -> kdump-eth0 >> -# Because kernel assigned names are not persistent between 1st and 2nd >> -# kernel. We could probably end up with eth0 being eth1, eth0 being >> -# eth1, and naming conflict happens. >> -kdump_setup_ifname() { >> - local _ifname >> - >> - # If ifname already has 'kdump-' prefix, we must be switching from >> - # fadump to kdump. Skip prefixing 'kdump-' in this case as adding >> - # another prefix may truncate the ifname. Since an ifname with >> - # 'kdump-' is already persistent, this should be fine. >> - if [[ $1 =~ eth* ]] && [[ ! $1 =~ ^kdump-* ]]; then >> - _ifname="kdump-$1" >> - else >> - _ifname="$1" >> - fi >> - >> - echo "$_ifname" >> -} >> - >> kdump_copy_nmconnection_file() { >> local _dev _nmconnection_file_path _nmconnection_name _initrd_nmconnection_file_path >> local _cloned_nmconnection_file_path _uniq_name _old_uuid _old_name _uuid _per_mac >> @@ -264,6 +244,8 @@ kdump_copy_nmconnection_file() { >> _per_mac=$(kdump_get_perm_addr "$_dev") >> if [[ "$_per_mac" != 'not set' ]]; then >> echo -n "except:mac:$_per_mac," >> "/tmp/$$-netif_allowlist" >> + # Ask NM to not match a connection profile based on interface-name >> + sed -i -E "s/^interface-name=.*$//g" "${initdir}/$_initrd_nmconnection_file_path" >> else >> echo -n "except:interface-name:$_dev," >> "/tmp/$$-netif_allowlist" >> fi >> @@ -428,7 +410,7 @@ kdump_get_remote_ip() { >> # initramfs accessing giving destination >> # $1: destination host >> kdump_install_net() { >> - local _destaddr _route _netdev _conpath kdumpnic >> + local _destaddr _route _netdev _conpath _kdumpip >> local _znet_netdev _znet_conpath >> # each netowrk interface is managed by a NM connection profile >> declare -A nmconnection_map >> @@ -441,9 +423,16 @@ kdump_install_net() { >> _route=$(kdump_get_ip_route "$_destaddr") >> _netdev=$(kdump_get_ip_route_field "$_route" "dev") >> _conpath=$(get_nmcli_connection_apath_by_ifname "$_netdev") >> - kdumpnic=$(kdump_setup_ifname "$_netdev") >> >> + if ! _kdumpip=$(ip addr show dev "$_netdev" | grep '[ ]*inet'); then >> + derror "Failed to get IP of $_netdev" >> + return 1 >> + fi >> + >> + _kdumpip=$(echo "$_kdumpip" | head -n 1 | awk '{print $2}') >> + _kdumpip="${_kdumpip%%/*}" >> _znet_netdev=$(find_online_znet_device) >> + >> if [[ -n $_znet_netdev ]]; then >> _znet_conpath=$(get_nmcli_connection_apath_by_ifname "$_znet_netdev") >> if ! (kdump_setup_znet "$_znet_netdev" "$_znet_conpath"); then >> @@ -463,6 +452,7 @@ kdump_install_net() { >> elif kdump_is_vlan "$_netdev"; then >> kdump_setup_vlan "$_netdev" >> fi >> + >> kdump_copy_nmconnection_file "$_netdev" >> kdump_install_nm_netif_allowlist >> >> @@ -483,8 +473,8 @@ kdump_install_net() { >> # the default gate way for network dump, eth1 in the fence kdump path will >> # call kdump_install_net again and we don't want eth1 to be the default >> # gateway. >> - if [[ ! -f ${initdir}/etc/cmdline.d/60kdumpnic.conf ]]; then >> - echo "kdumpnic=$kdumpnic" > "${initdir}/etc/cmdline.d/60kdumpnic.conf" >> + if [[ ! -f ${initdir}/etc/cmdline.d/60kdumpip.conf ]]; then >> + echo "kdumpip=$_kdumpip" > "${initdir}/etc/cmdline.d/60kdumpip.conf" >> fi >> } >> >> -- >> 2.34.1 > >Great idea! Thanks! > >Just one concern, could there be any wired DHCP corner case? Like if >the kdump kernel took a longer time to boot, eg. 5 min, and then your >DHCP IP just expired during that time window, the kdump kernel will be >using an expired IP and conflict with other machines. The minimal >lease time of DHCP address is 1 hr, could be a rare corner case, but >in-theory possible. It seems I don't fully understand you. In the kdump kernel, we still use DHCP to have a IP so there should be conflict. kdumpip is only used to create to a dumping folder named "{IP}-{DATE}" and we don't assign kdumpip to a NIC.

Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; --- dracut-module-setup.sh | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 64f9141..4e64872 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -429,23 +429,10 @@ kdump_setup_bond() { kdump_setup_team() { local _netdev=$1 - local _dev _mac _slaves _kdumpdev + local _dev for _dev in $(teamnl "$_netdev" ports | awk -F':' '{print $2}'); do

- _mac=$(kdump_get_perm_addr "$_dev") - _kdumpdev=$(kdump_setup_ifname "$_dev") - echo -n " ifname=$_kdumpdev:$_mac" >> "${initdir}/etc/cmdline.d/44team.conf" - _slaves+="$_kdumpdev," + kdump_copy_nmconnection_file "$_dev" done - echo " team=$_netdev:${_slaves%,}" >> "${initdir}/etc/cmdline.d/44team.conf" - #Buggy version teamdctl outputs to stderr! - #Try to use the latest version of teamd. - if ! teamdctl "$_netdev" config dump > "${initdir}/tmp/$$-$_netdev.conf"; then - derror "teamdctl failed." - exit 1 - fi - inst_dir /etc/teamd - inst_simple "${initdir}/tmp/$$-$_netdev.conf" "/etc/teamd/$_netdev.conf" - rm -f "${initdir}/tmp/$$-$_netdev.conf" } kdump_setup_vlan() { @@ -463,6 +450,7 @@ kdump_setup_vlan() { kdump_copy_nmconnection_file "$_parent_netif" elif kdump_is_team "$_parent_netif"; then (kdump_setup_team "$_parent_netif") || exit 1 + kdump_copy_nmconnection_file "$_parent_netif" else echo -n "except:interface-name:$_parent_netif," >> "/tmp/$$-netif_allowlist" fi

On Fri, Apr 22, 2022 at 05:29:41PM +0200, Philipp Rudo wrote: >Hi Coiby, > >On Sat, 2 Apr 2022 11:23:47 +0800 >Coiby Xu <coxu(a)redhat.com&gt; wrote: > >>During boot, it may take some time for a device driver to detect the >>its devices. By default, NetworkManager doesn't wait for the device to >>be available (this is not an issue for the 1st kernel because NM keeps >>running in the 1st kernel). So we need to set >>connection.wait-device-timeout=60000 [1] as the same to nm-initrd-generator >>to tell NM to wait for 6s. Otherwise dracut-kdump-capture.service would >>fail because network isn't ready. Note the user's custom value for >>wait-device-timeout is respected. >> >>Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; >>--- >> dracut-module-setup.sh | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >>diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh >>index 91bebcb..75f82af 100755 >>--- a/dracut-module-setup.sh >>+++ b/dracut-module-setup.sh >>@@ -371,6 +371,12 @@ kdump_copy_nmconnection_file() { >> # profile e.g. connection.master could be Interface name of the master >> # device or UUID of the master connection. >> sed -i -r "s/(^uuid=).*$/\1${_old_uuid}/g" "${initdir}/$_initrd_nmconnection_file_path" >>+ >>+ # Ask NM to wait 60s for the network device to be available >>+ # wait-device-timeout=60000 is inserted after "[connection]" so the >>+ # user's custom value could overwrite it >>+ sed -i -E 's/(\[connection\])/\1\nwait-device-timeout=60000/' "${initdir}/$_initrd_nmconnection_file_path" > >you can use > >sed -i '/\[connection\]/a wait-device-timeout=60000/' $file > >to add a line after a match Great, thanks for the tip!

> >Thanks >Philipp > >>+ >> nmcli connection del "$_uuid" >> } >> > -- Best regards, Coiby

Hi Coiby, one more thing On Sat, 2 Apr 2022 11:23:54 +0800 Coiby Xu <coxu(a)redhat.com&gt; wrote: > Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt; > --- > dracut-module-setup.sh | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh > index 64f9141..4e64872 100755 > --- a/dracut-module-setup.sh > +++ b/dracut-module-setup.sh > @@ -429,23 +429,10 @@ kdump_setup_bond() { > > kdump_setup_team() { > local _netdev=$1 > - local _dev _mac _slaves _kdumpdev > + local _dev > for _dev in $(teamnl "$_netdev" ports | awk -F':' '{print $2}'); do as you are basically rewriting this function you could also switch from a for-loop to the preferred while-read-loop [1]. Same for kdump_setup_{bridge,bond}.

Thanks Philipp [1] https://github.com/koalaman/shellcheck/wiki/SC2013 > - _mac=$(kdump_get_perm_addr "$_dev") > - _kdumpdev=$(kdump_setup_ifname "$_dev") > - echo -n " ifname=$_kdumpdev:$_mac" >> "${initdir}/etc/cmdline.d/44team.conf" > - _slaves+="$_kdumpdev," > + kdump_copy_nmconnection_file "$_dev" > done > - echo " team=$_netdev:${_slaves%,}" >> "${initdir}/etc/cmdline.d/44team.conf" > - #Buggy version teamdctl outputs to stderr! > - #Try to use the latest version of teamd. > - if ! teamdctl "$_netdev" config dump > "${initdir}/tmp/$$-$_netdev.conf"; then > - derror "teamdctl failed." > - exit 1 > - fi > - inst_dir /etc/teamd > - inst_simple "${initdir}/tmp/$$-$_netdev.conf" "/etc/teamd/$_netdev.conf" > - rm -f "${initdir}/tmp/$$-$_netdev.conf" > } > > kdump_setup_vlan() { > @@ -463,6 +450,7 @@ kdump_setup_vlan() { > kdump_copy_nmconnection_file "$_parent_netif" > elif kdump_is_team "$_parent_netif"; then > (kdump_setup_team "$_parent_netif") || exit 1 > + kdump_copy_nmconnection_file "$_parent_netif" > else > echo -n "except:interface-name:$_parent_netif," >> "/tmp/$$-netif_allowlist" > fi