Looks good to me,
Acked-by: Kairui Song <kasong(a)redhat.com>
On Wed, Jul 15, 2020 at 5:28 PM Pingfan Liu <piliu(a)redhat.com> wrote:
Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
---
dracut-kdump.sh | 1 +
kdump.conf | 2 +-
kdump.conf.5 | 2 +-
kexec-kdump-howto.txt | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/dracut-kdump.sh b/dracut-kdump.sh
index c74c4b7..6f948fc 100755
--- a/dracut-kdump.sh
+++ b/dracut-kdump.sh
@@ -41,6 +41,7 @@ do_kdump_pre()
fi
fi
+ # if any script fails, it just raises warning and continues
if [ -d /etc/kdump/pre.d ]; then
for file in /etc/kdump/pre.d/*; do
"$file"
diff --git a/kdump.conf b/kdump.conf
index ed78507..9f35e31 100644
--- a/kdump.conf
+++ b/kdump.conf
@@ -89,7 +89,7 @@
# after the dump process, runs immediately before it.
# Exit status of this binary is interpreted as follows:
# 0 - continue with dump process as usual
-# non 0 - reboot the system
+# non 0 - run the final action (reboot/poweroff/halt)
# If /etc/kdump/pre.d directory exists, all files in
# the directory are collectively sorted and executed in
# lexical order, after binary or script specified
diff --git a/kdump.conf.5 b/kdump.conf.5
index 9f2b2b6..c362963 100644
--- a/kdump.conf.5
+++ b/kdump.conf.5
@@ -127,7 +127,7 @@ as follows:
.PP
0 - continue with dump process as usual
.PP
-non 0 - reboot the system
+non 0 - run the final action (reboot/poweroff/halt)
.PP
If /etc/kdump/pre.d directory exists, all files in
the directory are collectively sorted and executed in
diff --git a/kexec-kdump-howto.txt b/kexec-kdump-howto.txt
index 9b0fee2..2209e5a 100644
--- a/kexec-kdump-howto.txt
+++ b/kexec-kdump-howto.txt
@@ -553,7 +553,7 @@ Kdump Pre-Capture Executable
It is possible to specify a custom script or binary you wish to run before
capturing a vmcore. Exit status of this binary is interpreted:
0 - continue with dump process as usual
-non 0 - reboot the system
+non 0 - run the final action (reboot/poweroff/halt)
If /etc/kdump/pre.d directory exists, all files in the directory are collectively
sorted and executed in lexical order, after binary or script specified
kdump_pre parameter is executed.
--
2.7.5
--
Best Regards,
Kairui Song