So, over the years we addressed the int overflow problem in different ways. Initially, we had some targeted code that would convert integers over the limit into strings. The was done only in a few places that were known to return large ints.

The most recent case of overflow was a bit messier, and we went with a more systematic approach. We also discovered the i8 tag, which was had not previously known about (and may not have existed when we first implemented the earlier solution).

When we started using the i8 tags, it was late in our release cycle, and we didn't want to break
existing code that might rely on those values being strings. So, we opted to leave those older parts alone for the time being.

If you want a quick test, the echo call will give you whatever data you pass in.

$ koji --noauth call echo 9223372036854775807
[9223372036854775807]



On Wed, Dec 13, 2017 at 1:58 PM, Ken Dreyer <ktdreyer@ktdreyer.com> wrote:
On Wed, Dec 13, 2017 at 11:30 AM, Ken Dreyer <ktdreyer@ktdreyer.com> wrote:
 I can't find a live Koji instance where
> we've overflowed the 32-bit int yet to verify, though!

Now I'm confused. https://pagure.io/koji/issue/464 mentions the
webkitgtk4-debuginfo RPMs, but when I check one with getRPM(10230453),
the size is a string, not i8:

$ cat xmlrpc
<?xml version="1.0"?>
 <methodCall>
 <methodName>getRPM</methodName>
 <params>
 <param>
 <value>
   <int>10230453</int>
 </value>
 </param>
 </params>
 </methodCall>

$ curl -d @xmlrpc https://koji.fedoraproject.org/kojihub | tidy -q -xml -i -
...
<member>
<name>size</name>
<value><string>2753783486</string></value>
</member>
...

- Ken
_______________________________________________
koji-devel mailing list -- koji-devel@lists.fedorahosted.org
To unsubscribe send an email to koji-devel-leave@lists.fedorahosted.org