3:33 p.m.
Hi folks,
All the scripts in https://pagure.io/koji have #!/usr/bin/python2.
There is some code in the Makefiles and koji.spec file that transforms
some (or all?) of these lines to #!/usr/bin/python3.
I would like to reverse this and make #!/usr/bin/python3 the default.
While I am working on this code, I see there are a lot of conditionals
in koji.spec and the Makefiles that have built up over time. It would
be great to drop python2 entirely so that it's easier to read the code
and contribute.
Which parts of Koji must support RHEL 6 (Python 2.6) in Koji's master branch?
- Ken
3:41 p.m.
On Mon, Nov 4, 2019 at 4:33 PM Ken Dreyer <ktdreyer(a)ktdreyer.com> wrote:
Hi folks,
All the scripts in https://pagure.io/koji have #!/usr/bin/python2.
There is some code in the Makefiles and koji.spec file that transforms
some (or all?) of these lines to #!/usr/bin/python3.
I would like to reverse this and make #!/usr/bin/python3 the default.
While I am working on this code, I see there are a lot of conditionals
in koji.spec and the Makefiles that have built up over time. It would
be great to drop python2 entirely so that it's easier to read the code
and contribute.
Which parts of Koji must support RHEL 6 (Python 2.6) in Koji's master branch?
Wouldn't it be easier to just use #!/usr/bin/python and just sed it
either way to Py2 or Py3? That's what I do for Pagure and a few other
projects...
--
真実はいつも一つ！/ Always, there's only one truth!
3:12 a.m.
Dne 04. 11. 19 v 22:41 Neal Gompa napsal(a):
Wouldn't it be easier to just use #!/usr/bin/python and just sed
it
either way to Py2 or Py3?
I think it is time to move on. Let's pretend that there is no py2 :)
I think the question should stand differently. Is anyone running latest Koji code on
RHEL6?
--
Miroslav Suchy, RHCA
Red Hat, Associate Manager ABRT/Copr, #brno, #fedora-buildsys
6:45 a.m.
út 5. 11. 2019 v 4:13 odesílatel Miroslav Suchý <msuchy(a)redhat.com> napsal:
Dne 04. 11. 19 v 22:41 Neal Gompa napsal(a):
> Wouldn't it be easier to just use #!/usr/bin/python and just sed it
> either way to Py2 or Py3?
It would mean, that git checkout will not work in Fedora - /usr/bin/python
exists no more, if you've no python-unversioned-command installed. I'm more
+1 to default python3
I think it is time to move on. Let's pretend that there is no py2
:)
I think the question should stand differently. Is anyone running latest
Koji code on RHEL6?
Yes,
the biggest problem is still imagefactory/oz which were not sufficiently
ported to py3. Same reason leads us to running py2 version on RHEL7.
Second is, that a lot of people still wants to use CLI on RHEL6.
Maybe Brendan can shed some light on imagefactory/oz py3 readiness?
--
Miroslav Suchy, RHCA
Red Hat, Associate Manager ABRT/Copr, #brno, #fedora-buildsys
_______________________________________________
koji-devel mailing list -- koji-devel(a)lists.fedorahosted.org
To unsubscribe send an email to koji-devel-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/koji-devel@lists.fedorahoste...
--
Tomas Kopecek <tkopecek(a)redhat.com>
Release Engineering Development, RedHat
8:53 a.m.
On Tue, Nov 5, 2019 at 7:46 AM Tomas Kopecek <tkopecek(a)redhat.com> wrote:
út 5. 11. 2019 v 4:13 odesílatel Miroslav Suchý <msuchy(a)redhat.com> napsal:
>
> Dne 04. 11. 19 v 22:41 Neal Gompa napsal(a):
> > Wouldn't it be easier to just use #!/usr/bin/python and just sed it
> > either way to Py2 or Py3?
It would mean, that git checkout will not work in Fedora - /usr/bin/python exists no
more, if you've no python-unversioned-command installed. I'm more +1 to default
python3
It is generally installed by default, so this is not a case to worry about.
>
> I think it is time to move on. Let's pretend that there is no py2 :)
>
> I think the question should stand differently. Is anyone running latest Koji code on
RHEL6?
Yes,
the biggest problem is still imagefactory/oz which were not sufficiently ported to py3.
Same reason leads us to running py2 version on RHEL7.
Second is, that a lot of people still wants to use CLI on RHEL6.
Maybe Brendan can shed some light on imagefactory/oz py3 readiness?
There were some parts ported to Python 3 for Fedora infrastructure.
I'm not sure if all the plugins were ported, though (maybe they were
since April?).
--
真実はいつも一つ！/ Always, there's only one truth!
8:04 a.m.
On 11/5/19 9:53 AM, Neal Gompa wrote:
On Tue, Nov 5, 2019 at 7:46 AM Tomas Kopecek
<tkopecek(a)redhat.com> wrote:
>
> út 5. 11. 2019 v 4:13 odesílatel Miroslav Suchý <msuchy(a)redhat.com> napsal:
>>
>> Dne 04. 11. 19 v 22:41 Neal Gompa napsal(a):
>>> Wouldn't it be easier to just use #!/usr/bin/python and just sed it
>>> either way to Py2 or Py3?
>
>
> It would mean, that git checkout will not work in Fedora - /usr/bin/python exists no
more, if you've no python-unversioned-command installed. I'm more +1 to default
python3
>
It is generally installed by default, so this is not a case to worry about.
>>
>> I think it is time to move on. Let's pretend that there is no py2 :)
>>
>> I think the question should stand differently. Is anyone running latest Koji code
on RHEL6?
>
>
> Yes,
> the biggest problem is still imagefactory/oz which were not sufficiently ported to
py3. Same reason leads us to running py2 version on RHEL7.
> Second is, that a lot of people still wants to use CLI on RHEL6.
>
> Maybe Brendan can shed some light on imagefactory/oz py3 readiness?
>
imagefactory/oz is py3 compatible at this point, minus some dependency
needed for the EC2 plugin I believe.
There were some parts ported to Python 3 for Fedora infrastructure.
I'm not sure if all the plugins were ported, though (maybe they were
since April?).
11:29 a.m.
On Wed, Nov 06, 2019 at 09:04:10AM -0500, Brendan Reilly wrote:
On 11/5/19 9:53 AM, Neal Gompa wrote:
> On Tue, Nov 5, 2019 at 7:46 AM Tomas Kopecek <tkopecek(a)redhat.com> wrote:
> >
> > út 5. 11. 2019 v 4:13 odesílatel Miroslav Suchý <msuchy(a)redhat.com>
napsal:
> > >
> > > Dne 04. 11. 19 v 22:41 Neal Gompa napsal(a):
> > > > Wouldn't it be easier to just use #!/usr/bin/python and just sed
it
> > > > either way to Py2 or Py3?
> >
> >
> > It would mean, that git checkout will not work in Fedora - /usr/bin/python
exists no more, if you've no python-unversioned-command installed. I'm more +1 to
default python3
> >
>
> It is generally installed by default, so this is not a case to worry about.
>
> > >
> > > I think it is time to move on. Let's pretend that there is no py2 :)
> > >
> > > I think the question should stand differently. Is anyone running latest
Koji code on RHEL6?
> >
> >
> > Yes,
> > the biggest problem is still imagefactory/oz which were not sufficiently ported
to py3. Same reason leads us to running py2 version on RHEL7.
> > Second is, that a lot of people still wants to use CLI on RHEL6.
> >
> > Maybe Brendan can shed some light on imagefactory/oz py3 readiness?
> >
imagefactory/oz is py3 compatible at this point, minus some dependency
needed for the EC2 plugin I believe.
yes, these are both python3 for a while now. (aside that plugin dep)
kevin
11:32 a.m.
On Mon, Nov 04, 2019 at 02:33:32PM -0700, Ken Dreyer wrote:
Hi folks,
All the scripts in https://pagure.io/koji have #!/usr/bin/python2.
There is some code in the Makefiles and koji.spec file that transforms
some (or all?) of these lines to #!/usr/bin/python3.
I would like to reverse this and make #!/usr/bin/python3 the default.
+1
While I am working on this code, I see there are a lot of
conditionals
in koji.spec and the Makefiles that have built up over time. It would
be great to drop python2 entirely so that it's easier to read the code
and contribute.
I fear there's some places using at least rhel7/python2. (we are for our
hubs actually).
I wonder if it would make sense to split the spec and such into 2?
a koji.spec (default) thats just python3 all around and a
koji-rhel7.spec that is python2 all around. Then for the Fedora/EPEL
packages we could at least use the python3 one for all Fedora's and
EPEL8 and the python2 one for EPEL7.
Which parts of Koji must support RHEL 6 (Python 2.6) in Koji's master branch?
Nothing in Fedora for a long time, but there might be people out there
that still need this? Perhaps it's worth moving it to just 'client
only'?
kevin
10:22 a.m.
Dne 06. 11. 19 v 18:32 Kevin Fenzi napsal(a):
I wonder if it would make sense to split the spec and such into 2?
a koji.spec (default) thats just python3 all around and a
koji-rhel7.spec that is python2 all around. Then for the Fedora/EPEL
packages we could at least use the python3 one for all Fedora's and
EPEL8 and the python2 one for EPEL7.
EPEL7 has python3 as well. It just require subtle change of spec file.
I already moved Mock code to Python3. Even on EPEL 7.
--
Miroslav Suchy, RHCA
Red Hat, Associate Manager ABRT/Copr, #brno, #fedora-buildsys
10:47 a.m.
On Thu, Nov 07, 2019 at 05:22:17PM +0100, Miroslav Suchý wrote:
Dne 06. 11. 19 v 18:32 Kevin Fenzi napsal(a):
> I wonder if it would make sense to split the spec and such into 2?
> a koji.spec (default) thats just python3 all around and a
> koji-rhel7.spec that is python2 all around. Then for the Fedora/EPEL
> packages we could at least use the python3 one for all Fedora's and
> EPEL8 and the python2 one for EPEL7.
EPEL7 has python3 as well. It just require subtle change of spec file.
I already moved Mock code to Python3. Even on EPEL 7.
Sure, it does now. I am not sure if the entire stack of needed by koji
packages is available there tho. If it is, that may indeed be a way to
go.
kevin
7:21 a.m.
I've been playing with py3 builder and it seems that everything works in
Fedora now except for pycdio. On the other hand, pycdio is generally
running on py3, but it is still packaged as py2-only. So, it should be only
a matter of fixing spec there. Only @Jay Greguske <jgreguske(a)redhat.com> is
listed as maintainer in pkgdb and I'm not sure if he will find some time to
do that. Is there any volunteer?
čt 7. 11. 2019 v 17:47 odesílatel Kevin Fenzi <kevin(a)scrye.com> napsal:
On Thu, Nov 07, 2019 at 05:22:17PM +0100, Miroslav Suchý wrote:
> Dne 06. 11. 19 v 18:32 Kevin Fenzi napsal(a):
> > I wonder if it would make sense to split the spec and such into 2?
> > a koji.spec (default) thats just python3 all around and a
> > koji-rhel7.spec that is python2 all around. Then for the Fedora/EPEL
> > packages we could at least use the python3 one for all Fedora's and
> > EPEL8 and the python2 one for EPEL7.
>
> EPEL7 has python3 as well. It just require subtle change of spec file.
> I already moved Mock code to Python3. Even on EPEL 7.
Sure, it does now. I am not sure if the entire stack of needed by koji
packages is available there tho. If it is, that may indeed be a way to
go.
kevin
_______________________________________________
koji-devel mailing list -- koji-devel(a)lists.fedorahosted.org
To unsubscribe send an email to koji-devel-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/koji-devel@lists.fedorahoste...
--
Tomas Kopecek <tkopecek(a)redhat.com>
Release Engineering Development, RedHat
7:34 a.m.
On Tue, Nov 19, 2019 at 8:22 AM Tomas Kopecek <tkopecek(a)redhat.com> wrote:
I've been playing with py3 builder and it seems that everything works in Fedora now
except for pycdio. On the other hand, pycdio is generally running on py3, but it is still
packaged as py2-only. So, it should be only a matter of fixing spec there. Only @Jay
Greguske is listed as maintainer in pkgdb and I'm not sure if he will find some time
to do that. Is there any volunteer?
I could probably help here.
--
真実はいつも一つ！/ Always, there's only one truth!
1618
days inactive
1633
days old
koji-devel@lists.fedorahosted.org
12 comments
6 participants
participants (6)
-
Brendan Reilly -
Ken Dreyer -
Kevin Fenzi -
Miroslav Suchý -
Neal Gompa -
Tomas Kopecek