5:31 a.m.
This flag is documented and parsed, but not acted upon.
---
imgcreate/creator.py | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/imgcreate/creator.py b/imgcreate/creator.py
index 909f616..4deb49e 100644
--- a/imgcreate/creator.py
+++ b/imgcreate/creator.py
@@ -23,6 +23,7 @@ import sys
import tempfile
import shutil
import logging
+import subprocess
import selinux
import yum
@@ -702,11 +703,17 @@ class ImageCreator(object):
script = "/tmp/" + os.path.basename(path)
try:
- subprocess.call([s.interp, script],
- preexec_fn = preexec, env = env)
+ subprocess.check_call([s.interp, script],
+ preexec_fn = preexec, env = env)
except OSError, (err, msg):
raise CreatorError("Failed to execute %%post script "
"with '%s' : %s" % (s.interp, msg))
+ except subprocess.CalledProcessError, err:
+ if s.errorOnFail:
+ raise CreatorError("%%post script failed with code %d "
+ % err.returncode)
+ logging.warning("ignoring %%post failure (code %d)"
+ % err.returncode)
finally:
os.unlink(path)
--
1.6.2.5
7:39 a.m.
On Thu, 2009-12-24 at 11:31 +0000, Daniel Drake wrote:
This flag is documented and parsed, but not acted upon.
bump... Any further comments on this patch?
imgcreate/creator.py | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/imgcreate/creator.py b/imgcreate/creator.py
index 909f616..4deb49e 100644
--- a/imgcreate/creator.py
+++ b/imgcreate/creator.py
@@ -23,6 +23,7 @@ import sys
import tempfile
import shutil
import logging
+import subprocess
import selinux
import yum
@@ -702,11 +703,17 @@ class ImageCreator(object):
script = "/tmp/" + os.path.basename(path)
try:
- subprocess.call([s.interp, script],
- preexec_fn = preexec, env = env)
+ subprocess.check_call([s.interp, script],
+ preexec_fn = preexec, env = env)
except OSError, (err, msg):
raise CreatorError("Failed to execute %%post script "
"with '%s' : %s" % (s.interp,
msg))
+ except subprocess.CalledProcessError, err:
+ if s.errorOnFail:
+ raise CreatorError("%%post script failed with code %d "
+ % err.returncode)
+ logging.warning("ignoring %%post failure (code %d)"
+ % err.returncode)
finally:
os.unlink(path)
10:13 a.m.
On 3 January 2010 10:39, Daniel Drake <dsd(a)laptop.org> wrote:
On Thu, 2009-12-24 at 11:31 +0000, Daniel Drake wrote:
> This flag is documented and parsed, but not acted upon.
bump... Any further comments on this patch?
bump...4 months on...can this be applied?
> imgcreate/creator.py | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/imgcreate/creator.py b/imgcreate/creator.py
> index 909f616..4deb49e 100644
> --- a/imgcreate/creator.py
> +++ b/imgcreate/creator.py
> @@ -23,6 +23,7 @@ import sys
> import tempfile
> import shutil
> import logging
> +import subprocess
>
> import selinux
> import yum
> @@ -702,11 +703,17 @@ class ImageCreator(object):
> script = "/tmp/" + os.path.basename(path)
>
> try:
> - subprocess.call([s.interp, script],
> - preexec_fn = preexec, env = env)
> + subprocess.check_call([s.interp, script],
> + preexec_fn = preexec, env = env)
> except OSError, (err, msg):
> raise CreatorError("Failed to execute %%post script "
> "with '%s' : %s" % (s.interp,
msg))
> + except subprocess.CalledProcessError, err:
> + if s.errorOnFail:
> + raise CreatorError("%%post script failed with code %d
"
> + % err.returncode)
> + logging.warning("ignoring %%post failure (code %d)"
> + % err.returncode)
> finally:
> os.unlink(path)
>
4:40 p.m.
On Tue, May 4, 2010 at 5:13 PM, Daniel Drake <dsd(a)laptop.org> wrote:
On 3 January 2010 10:39, Daniel Drake <dsd(a)laptop.org> wrote:
> On Thu, 2009-12-24 at 11:31 +0000, Daniel Drake wrote:
>> This flag is documented and parsed, but not acted upon.
>
> bump... Any further comments on this patch?
bump...4 months on...can this be applied?
I'm a bit lost here.
There are probably five or more patches now waiting to be reviewed and
applied and even after CC'ing a couple of people who *do* definitely
have commit access according to FAS nothing has happened.
Ping?
--Sebastian
>> imgcreate/creator.py | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/imgcreate/creator.py b/imgcreate/creator.py
>> index 909f616..4deb49e 100644
>> --- a/imgcreate/creator.py
>> +++ b/imgcreate/creator.py
>> @@ -23,6 +23,7 @@ import sys
>> import tempfile
>> import shutil
>> import logging
>> +import subprocess
>>
>> import selinux
>> import yum
>> @@ -702,11 +703,17 @@ class ImageCreator(object):
>> script = "/tmp/" + os.path.basename(path)
>>
>> try:
>> - subprocess.call([s.interp, script],
>> - preexec_fn = preexec, env = env)
>> + subprocess.check_call([s.interp, script],
>> + preexec_fn = preexec, env = env)
>> except OSError, (err, msg):
>> raise CreatorError("Failed to execute %%post script "
>> "with '%s' : %s" %
(s.interp, msg))
>> + except subprocess.CalledProcessError, err:
>> + if s.errorOnFail:
>> + raise CreatorError("%%post script failed with code %d
"
>> + % err.returncode)
>> + logging.warning("ignoring %%post failure (code %d)"
>> + % err.returncode)
>> finally:
>> os.unlink(path)
>>
>
>
--
livecd mailing list
livecd(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/livecd
4:51 p.m.
On Wed, May 05, 2010 at 23:40:45 +0200,
Sebastian Dziallas <sebastian(a)when.com> wrote:
On Tue, May 4, 2010 at 5:13 PM, Daniel Drake <dsd(a)laptop.org>
wrote:
> On 3 January 2010 10:39, Daniel Drake <dsd(a)laptop.org> wrote:
>> On Thu, 2009-12-24 at 11:31 +0000, Daniel Drake wrote:
>>> This flag is documented and parsed, but not acted upon.
>>
>> bump... Any further comments on this patch?
>
> bump...4 months on...can this be applied?
I'm a bit lost here.
There are probably five or more patches now waiting to be reviewed and
applied and even after CC'ing a couple of people who *do* definitely
have commit access according to FAS nothing has happened.
Ping?
I suspect that the issue has to do with Jeremy Katz no longer working for
Redhat. I think he still wants to work on things like this, but doesn't
have as much time. (That may not be an accurate understanding though.)
Probably someone else needs to step up to own livecd-tools. If you really
want to do this, you should be able to apply for membership in the group
that controls access.
8:18 p.m.
Looking at the pkg database katzj is still the current owner, with
davidz and huff as group members who can commit.
If you or the other patch submitters do not have the time to babysit
this package, I can volunteer myself.
I suspect that the issue has to do with Jeremy Katz no longer working for
Redhat. I think he still wants to work on things like this, but doesn't
have as much time. (That may not be an accurate understanding though.)
Probably someone else needs to step up to own livecd-tools. If you really
want to do this, you should be able to apply for membership in the group
that controls access.
--
livecd mailing list
livecd(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/livecd
11:37 p.m.
On Wed, May 05, 2010 at 18:18:49 -0700,
Jasper Hartline <jasper.hartline(a)gmail.com> wrote:
Looking at the pkg database katzj is still the current owner, with
davidz and huff as group members who can commit.
If you or the other patch submitters do not have the time to babysit
this package, I can volunteer myself.
You'll probably also want access to the livecd project at fedorahosted,
since we (Fedora) are upstream for that project.
10:11 a.m.
Huff they are needing patches pushed upstream could you do this for them?
ThXXXX <3
( adam stokes ) || ( adam.stokes(a)gmail.com )
On Thu, May 6, 2010 at 12:37 AM, Bruno Wolff III <bruno(a)wolff.to> wrote:
On Wed, May 05, 2010 at 18:18:49 -0700,
Jasper Hartline <jasper.hartline(a)gmail.com> wrote:
> Looking at the pkg database katzj is still the current owner, with
> davidz and huff as group members who can commit.
> If you or the other patch submitters do not have the time to babysit
> this package, I can volunteer myself.
You'll probably also want access to the livecd project at fedorahosted,
since we (Fedora) are upstream for that project.
--
livecd mailing list
livecd(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/livecd
4:30 p.m.
New subject: Status livecd
Hey guys,
In response to the recent threads, I am going to try and take a more
active role with the livecd project. I know the code pretty well,
however may need some help when the discussion gets low level.
I'll look into changing package ownership to myself in pkgdb, and if
anyone one wants to volunteer to help as coe-maintainer I would
appreciate it, I think stokes and jasper just volunteered :)
Taking a quick look at the list I see 5 patches that have not been
reviewed, however there may be more, if so please re-post!!
1. Implement %post --erroronfail - Daniel Drake
2. SELinux Enabled Images on SELinux Disabled Hosts - Jay Greguske
3. livecd-creator ignores device directive - Alan Pevec
4. livecd-iso-to-disk --format fails with existing LV on USB - David Huff
5. Destructive behavior in --skipcopy option of livecd-iso-to-disk -
Frederick Grose
I'll try and review the patches above today and tomorrow, as well as
take a look at the open BZ's and get everything rolling again.
-D
On 05/06/2010 11:11 AM, Adam Stokes wrote:
Huff they are needing patches pushed upstream could you do this for
them?
ThXXXX<3
( adam stokes ) || ( adam.stokes(a)gmail.com )
On Thu, May 6, 2010 at 12:37 AM, Bruno Wolff III<bruno(a)wolff.to> wrote:
> On Wed, May 05, 2010 at 18:18:49 -0700,
> Jasper Hartline<jasper.hartline(a)gmail.com> wrote:
>> Looking at the pkg database katzj is still the current owner, with
>> davidz and huff as group members who can commit.
>> If you or the other patch submitters do not have the time to babysit
>> this package, I can volunteer myself.
>
> You'll probably also want access to the livecd project at fedorahosted,
> since we (Fedora) are upstream for that project.
> --
> livecd mailing list
> livecd(a)lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/livecd
>
--
livecd mailing list
livecd(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/livecd
4:54 p.m.
New subject: Status livecd
On Thu, May 6, 2010 at 5:30 PM, David Huff <dhuff(a)redhat.com> wrote:
...
Taking a quick look at the list I see 5 patches that have not been
reviewed, however there may be more, if so please re-post!!
1. Implement %post --erroronfail - Daniel Drake
2. SELinux Enabled Images on SELinux Disabled Hosts - Jay Greguske
3. livecd-creator ignores device directive - Alan Pevec
4. livecd-iso-to-disk --format fails with existing LV on USB - David Huff
5. Destructive behavior in --skipcopy option of livecd-iso-to-disk -
Frederick Grose
https://bugzilla.redhat.com/buglist.cgi?component=livecd-tools&produc...
<https://bugzilla.redhat.com/buglist.cgi?component=livecd-tools&produc...
the open bugs.
I have a 'modified_livecd-iso-to-disk' prototype in this ticket,
https://bugzilla.redhat.com/show_bug.cgi?id=448030
<https://bugzilla.redhat.com/show_bug.cgi?id=448030>It adds --copy-overlay
--copy-home and --help options and greatly expands the usage section to
support stand-alone help.
I thought I would enter smaller patches once we got going on reviews.
This is a bug I discovered while reviewing LV --format failure:
Bug 587411 <https://bugzilla.redhat.com/show_bug.cgi?id=587411> -
livecd-iso-to-disk
--format fails with SD/MMC partitions
--Fred
7:35 p.m.
New subject: Status livecd
I'll start reviewing once I get commit access
On May 6, 2010, at 5:30 PM, David Huff <dhuff(a)redhat.com> wrote:
Hey guys,
In response to the recent threads, I am going to try and take a more
active role with the livecd project. I know the code pretty well,
however may need some help when the discussion gets low level.
I'll look into changing package ownership to myself in pkgdb, and if
anyone one wants to volunteer to help as coe-maintainer I would
appreciate it, I think stokes and jasper just volunteered :)
Taking a quick look at the list I see 5 patches that have not been
reviewed, however there may be more, if so please re-post!!
1. Implement %post --erroronfail - Daniel Drake
2. SELinux Enabled Images on SELinux Disabled Hosts - Jay Greguske
3. livecd-creator ignores device directive - Alan Pevec
4. livecd-iso-to-disk --format fails with existing LV on USB - David
Huff
5. Destructive behavior in --skipcopy option of livecd-iso-to-disk -
Frederick Grose
I'll try and review the patches above today and tomorrow, as well as
take a look at the open BZ's and get everything rolling again.
-D
On 05/06/2010 11:11 AM, Adam Stokes wrote:
> Huff they are needing patches pushed upstream could you do this for
> them?
>
> ThXXXX<3
> ( adam stokes ) || ( adam.stokes(a)gmail.com )
>
>
>
> On Thu, May 6, 2010 at 12:37 AM, Bruno Wolff III<bruno(a)wolff.to>
> wrote:
>> On Wed, May 05, 2010 at 18:18:49 -0700,
>> Jasper Hartline<jasper.hartline(a)gmail.com> wrote:
>>> Looking at the pkg database katzj is still the current owner, with
>>> davidz and huff as group members who can commit.
>>> If you or the other patch submitters do not have the time to
>>> babysit
>>> this package, I can volunteer myself.
>>
>> You'll probably also want access to the livecd project at
>> fedorahosted,
>> since we (Fedora) are upstream for that project.
>> --
>> livecd mailing list
>> livecd(a)lists.fedoraproject.org
>> https://admin.fedoraproject.org/mailman/listinfo/livecd
>>
> --
> livecd mailing list
> livecd(a)lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/livecd
2:30 p.m.
On 05/04/2010 11:13 AM, Daniel Drake wrote:
On 3 January 2010 10:39, Daniel Drake<dsd(a)laptop.org> wrote:
> On Thu, 2009-12-24 at 11:31 +0000, Daniel Drake wrote:
>> This flag is documented and parsed, but not acted upon.
>
> bump... Any further comments on this patch?
bump...4 months on...can this be applied?
>> imgcreate/creator.py | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/imgcreate/creator.py b/imgcreate/creator.py
>> index 909f616..4deb49e 100644
>> --- a/imgcreate/creator.py
>> +++ b/imgcreate/creator.py
>> @@ -23,6 +23,7 @@ import sys
>> import tempfile
>> import shutil
>> import logging
>> +import subprocess
>>
>> import selinux
>> import yum
>> @@ -702,11 +703,17 @@ class ImageCreator(object):
>> script = "/tmp/" + os.path.basename(path)
>>
>> try:
>> - subprocess.call([s.interp, script],
>> - preexec_fn = preexec, env = env)
>> + subprocess.check_call([s.interp, script],
>> + preexec_fn = preexec, env = env)
>> except OSError, (err, msg):
>> raise CreatorError("Failed to execute %%post script
"
>> "with '%s' : %s" %
(s.interp, msg))
>> + except subprocess.CalledProcessError, err:
>> + if s.errorOnFail:
>> + raise CreatorError("%%post script failed with code %d
"
>> + % err.returncode)
>> + logging.warning("ignoring %%post failure (code %d)"
>> + % err.returncode)
>> finally:
>> os.unlink(path)
>>
>
>
--
livecd mailing list
livecd(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/livecd
committed!!
11:49 a.m.
On 10 May 2010 16:30, David Huff <dhuff(a)redhat.com> wrote:
committed!!
Thanks!
Would it be OK for me to push this patch in a F11 package update?
OLPC are using imgcreate in our olpc-os-builder app, which builds the
OS images for the XO laptops.
http://wiki.laptop.org/go/OSBuilder
It is now being used in various countries to create OS builds
customized for local requirements. It makes extensive use of %post
scripts and catching errors is important.
Thanks,
Daniel
5082
days inactive
5229
days old
livecd@lists.fedoraproject.org
13 comments
8 participants
participants (8)
-
Adam Stokes -
Alan Pevec -
Bruno Wolff III -
Daniel Drake -
David Huff -
Frederick Grose -
Jasper Hartline -
Sebastian Dziallas