On Wed, 2007-08-08 at 12:53 +0200, Jeroen van Meeuwen wrote:
Jeremy Katz wrote:
> On Tue, 2007-08-07 at 00:20 +0200, Jeroen van Meeuwen wrote:
>> Jeremy Katz wrote:
>>> On Mon, 2007-08-06 at 23:09 +0200, Jeroen van Meeuwen wrote:
>>>> Jeremy Katz wrote:
>>>>> On Wed, 2007-08-01 at 14:16 +0200, Jeroen van Meeuwen wrote:
>>>>>> livecd-creator's InstallationTarget.install() seems to run
>>>>>> self.configureSystem(), then run self.configureNetwork(),
possible
>>>>>> overriding some configuration files generated with %post.
>>>>> Hmm, the question is when is the best point at which to do this.
After
>>>>> configuring the network or really as last as possible? The latter
seems
>>>>> to fit better with when its run on an install
>>>> +1
>>> Want to send a revised patch? :-)
>> Well, as it is now it does apply at the very last moment, exactly the
>> way the installer works, right?
>
> There are a few steps (relabeling, prelinking, making the initrd) that
> are happening after runPost() of your patch. If the %post is going to
> be the absolute last thing, it should probably be after all of these
It'd be plausible to have relabeling, prelinking and making the initrd
occur after %post, but %post should apply to whatever else we do with
kickstart information, right? I think where it is now, it fits perfectly.
Yeah, I can see it being plausible basically anywhere. That's why the
position of %post has moved around from "right after packages installed"
to "at the very end" to "at the very end, minus the CD eject" in
anaconda over time. Hence, I lean towards at the very end just for
consistency with current anaconda behavior
Jeremy