Re: [Matahari] [PATCH] - Raise Exception on NULL in sysconfig agent

On Fri, 26 Aug 2011 07:41:34 -0400 Russell Bryant rbryant@redhat.com wrote:

On 08/25/2011 11:51 PM, Adam Stokes wrote:

...

• qmf/qpid doesn't allow null as an acceptable return argument so raising an exception to alert end user of possible status conflicts resolves rhbz 733384, 733451

...

  } else if (methodName == "is_configured") {
      status =

mh_sysconfig_is_configured(args["key"].asString().c_str());

•    if (!status) {
  

•        goto bail;
  

•    }
  

What does a NULL return from mh_sysconfig_is_configured() really mean? Is it just that a configuration request with this key hasn't been attempted? I don't think we should raise an exception on these cases. I think we should just handle it gracefully.

 addReturnArgument("status", status ? status : "unknown");

I did try this but an exception was still occuring telling me null is not valid.