[Bug 491758] Review Request: mingw32-opensc - MingGW Windows OpenSC library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491758
Thomas Sailer <t.sailer(a)alumni.ethz.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |t.sailer(a)alumni.ethz.ch
--- Comment #4 from Thomas Sailer <t.sailer(a)alumni.ethz.ch> 2009-04-17 09:24:57 EDT ---
Fedora review mingw32-libxml++-2.26.0-1.fc11.src.rpm 2008-04-17
Another scratch build:
http://koji.fedoraproject.org/koji/getfile?taskID=1303992
rpmlint output:
$ rpmlint mingw32-opensc-0.11.7-2.fc12.src.rpm
mingw32-opensc-0.11.7-2.fc12.noarch.rpm mingw32-opensc.spec
mingw32-opensc.noarch: E: file-in-usr-marked-as-conffile
/usr/i686-pc-mingw32/sys-root/mingw/etc/opensc.conf
mingw32-opensc.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/sbin/opensc-install.bat
mingw32-opensc.noarch: E: wrong-script-end-of-line-encoding
/usr/i686-pc-mingw32/sys-root/mingw/sbin/opensc-install.bat
mingw32-opensc.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/bin/cardos-info.bat
mingw32-opensc.noarch: E: wrong-script-end-of-line-encoding
/usr/i686-pc-mingw32/sys-root/mingw/bin/cardos-info.bat
2 packages and 1 specfiles checked; 5 errors, 0 warnings.
As per Packaging/MinGW, these errors can be ignored (counting .bat files as
"windows executables").
+ OK
! needs attention
+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ License meets guidelines and is acceptable to Fedora
LGPLv2+
+ License matches the actual package license
It is also the same as in the corresponding Fedora libxml++ package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
419e9be372c2f9bbb3ce9704c929d5ec opensc-0.11.7.tar.gz
419e9be372c2f9bbb3ce9704c929d5ec ../SOURCES/opensc-0.11.7.tar.gz
n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! use %global instead of %define
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 11 months
rpms/mingw32-glib2/devel .cvsignore, 1.3, 1.4 mingw32-glib2.spec, 1.5, 1.6 sources, 1.3, 1.4
by sailer
Author: sailer
Update of /cvs/extras/rpms/mingw32-glib2/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv16868/devel
Modified Files:
.cvsignore mingw32-glib2.spec sources
Log Message:
update to 2.20.1
Index: .cvsignore
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/devel/.cvsignore,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- .cvsignore 5 Mar 2009 20:46:31 -0000 1.3
+++ .cvsignore 16 Apr 2009 12:15:13 -0000 1.4
@@ -1 +1,2 @@
glib-2.19.10.tar.bz2
+glib-2.20.1.tar.bz2
Index: mingw32-glib2.spec
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/devel/mingw32-glib2.spec,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- mingw32-glib2.spec 5 Mar 2009 20:46:31 -0000 1.5
+++ mingw32-glib2.spec 16 Apr 2009 12:15:13 -0000 1.6
@@ -5,14 +5,14 @@
%define __find_provides %{_mingw32_findprovides}
Name: mingw32-glib2
-Version: 2.19.10
+Version: 2.20.1
Release: 1%{?dist}
Summary: MinGW Windows GLib2 library
License: LGPLv2+
Group: Development/Libraries
URL: http://www.gtk.org
-Source0: http://download.gnome.org/sources/glib/2.19/glib-%{version}.tar.bz2
+Source0: http://download.gnome.org/sources/glib/2.20/glib-%{version}.tar.bz2
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
@@ -179,6 +179,9 @@
%{_mingw32_libdir}/libgthread-2.0.a
%changelog
+* Thu Apr 16 2009 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.20.1-1
+- Update to 2.20.1
+
* Thu Mar 5 2009 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 2.19.10-1
- Update to 2.19.10
- Dropped the gtk-doc documentation as it's identical to the base glib2 package
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/devel/sources,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- sources 5 Mar 2009 20:46:31 -0000 1.3
+++ sources 16 Apr 2009 12:15:13 -0000 1.4
@@ -1 +1 @@
-2cec449d5593835b6080d662a17078ca glib-2.19.10.tar.bz2
+d7ef53c7b65827a1baa4bad1c6893fa3 glib-2.20.1.tar.bz2
14 years, 11 months
rpms/mingw32-glib2/F-11 .cvsignore, 1.3, 1.4 mingw32-glib2.spec, 1.5, 1.6 sources, 1.3, 1.4
by sailer
Author: sailer
Update of /cvs/extras/rpms/mingw32-glib2/F-11
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv16868/F-11
Modified Files:
.cvsignore mingw32-glib2.spec sources
Log Message:
update to 2.20.1
Index: .cvsignore
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/F-11/.cvsignore,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- .cvsignore 5 Mar 2009 20:46:31 -0000 1.3
+++ .cvsignore 16 Apr 2009 12:15:12 -0000 1.4
@@ -1 +1,2 @@
glib-2.19.10.tar.bz2
+glib-2.20.1.tar.bz2
Index: mingw32-glib2.spec
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/F-11/mingw32-glib2.spec,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- mingw32-glib2.spec 5 Mar 2009 20:46:31 -0000 1.5
+++ mingw32-glib2.spec 16 Apr 2009 12:15:12 -0000 1.6
@@ -5,14 +5,14 @@
%define __find_provides %{_mingw32_findprovides}
Name: mingw32-glib2
-Version: 2.19.10
+Version: 2.20.1
Release: 1%{?dist}
Summary: MinGW Windows GLib2 library
License: LGPLv2+
Group: Development/Libraries
URL: http://www.gtk.org
-Source0: http://download.gnome.org/sources/glib/2.19/glib-%{version}.tar.bz2
+Source0: http://download.gnome.org/sources/glib/2.20/glib-%{version}.tar.bz2
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
@@ -179,6 +179,9 @@
%{_mingw32_libdir}/libgthread-2.0.a
%changelog
+* Thu Apr 16 2009 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.20.1-1
+- Update to 2.20.1
+
* Thu Mar 5 2009 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 2.19.10-1
- Update to 2.19.10
- Dropped the gtk-doc documentation as it's identical to the base glib2 package
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/mingw32-glib2/F-11/sources,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- sources 5 Mar 2009 20:46:31 -0000 1.3
+++ sources 16 Apr 2009 12:15:12 -0000 1.4
@@ -1 +1 @@
-2cec449d5593835b6080d662a17078ca glib-2.19.10.tar.bz2
+d7ef53c7b65827a1baa4bad1c6893fa3 glib-2.20.1.tar.bz2
14 years, 11 months