[Bug 613993] Review Request: mingw32-celt051 - An audio codec for use in low-delay speech and audio communication
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613993
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2010-07-25 17:33:48 EDT ---
$ rpmlint mingw32-celt051.spec
mingw32-celt051.spec: W: no-cleaning-of-buildroot %install
mingw32-celt051.spec: W: no-cleaning-of-buildroot %clean
mingw32-celt051.spec: W: no-buildroot-tag
mingw32-celt051.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
- Please fix the rpmlint warnings mentioned above
- Please use %global instead of %define for all the macros at the top of the
.spec file
- Please add a comment about the purpose of the patch
- Please use 'make %{?_smp_mflags}' instead of just 'make'
- Please use a complete file list instead of %{_mingw32_libdir}/libcelt051* as
the * masks the fact that only a static library is bundled
- Is it correct that this package only provides a static library and no shared
library (DLL)? Shared libraries are preferred in Fedora. If shared libraries
aren't supported by upstream (and upstream doesn't want to support this),
please move all files to a -static subpackage and make the main package require
the -static subpackage
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 9 months
[Bug 614047] Review Request: mingw32-spice-protocol - Spice protocol header files
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=614047
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2010-07-25 16:35:00 EDT ---
One other thing, the BuildRequires: autoconf automake can be dropped as the
configure script doesn't need to be rebuilt.
The BuildRequires: mingw32-binutils and mingw32-gcc can also be dropped as
nothing gets compiled in this package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 9 months
[Bug 614047] Review Request: mingw32-spice-protocol - Spice protocol header files
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=614047
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?
--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2010-07-25 16:20:32 EDT ---
$ rpmlint mingw32-spice-protocol.spec
mingw32-spice-protocol.spec: W: no-cleaning-of-buildroot %install
mingw32-spice-protocol.spec: W: no-cleaning-of-buildroot %clean
mingw32-spice-protocol.spec: W: no-buildroot-tag
mingw32-spice-protocol.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
- Please fix the rpmlint warnings mentioned above
- Please use %global instead of %define for all the macros at the top of the
.spec file
- Please use %defattr(,-,root,root,-) instead of %defattr(-,root,root)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 9 months
dllimport and initialization issue
by Michael Cronenworth
This code compiles with no errors or warnings:
__attribute__ ((dllimport)) int _fmode;
This code does not compile:
__attribute__ ((dllimport)) int _fmode = _O_BINARY;
foo.c:123: error: variable '_fmode' definition is marked dllimport
foo.c:123: warning: '_fmode' redeclared without dllimport attribute:
previous dllimport ignored
Am I doing something horribly wrong or is this a gcc bug?
rpm -q mingw32-gcc
mingw32-gcc-4.4.2-2.fc13.x86_64
Thanks,
Michael
13 years, 9 months