[Bug 700815] Review Request: mingw32-gtk3 - MinGW Windows GTK+ library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700815
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
Flag| |fedora-review?
--- Comment #3 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2011-04-29 14:08:29 EDT ---
Looks like you beat me to it in putting this package up for review :)
In your spec you're using a libtool hack to make this package build. In my
attempt I've used a different approach for this issue which is a more generic
solution to this problem and also is upstreamable:
http://svn.openftd.org/svn/fedora_cross/mingw-gtk3/gtk3-win32-libtool-fix...
Please consider using this patch
Is the PATH override really necessary to get this package build?
There's one file being placed in %{_mingw32_datadir}/glib-2.0/schemas/. This
folder should be owned by the mingw32-glib2 package but I suspect this ain't
the case at this moment. I'll look into this and push a new update if necessary
The other directory ownerships look good
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 11 months
[mingw32-cairo] Really rebuild without proxy-libintl
by Kalev Lember
commit 7c94195351c02e56f34df4e5fc6afabfbd774dc3
Author: Kalev Lember <kalev(a)smartlink.ee>
Date: Thu Apr 28 14:13:31 2011 +0300
Really rebuild without proxy-libintl
mingw32-cairo.spec | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/mingw32-cairo.spec b/mingw32-cairo.spec
index 6513493..f931414 100644
--- a/mingw32-cairo.spec
+++ b/mingw32-cairo.spec
@@ -7,7 +7,7 @@
Name: mingw32-cairo
Version: 1.10.2
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: MinGW Windows Cairo library
License: LGPLv2 or MPLv1.1
@@ -118,6 +118,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Thu Apr 28 2011 Kalev Lember <kalev(a)smartlink.ee> - 1.10.2-3
+- Really rebuild without proxy-libintl
+
* Wed Apr 27 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 1.10.2-2
- Dropped the proxy-libintl pieces
12 years, 11 months
[mingw32-glib2/f15/master: 2/2] Merge branch 'master' into f15
by Erik van Pienbroek
commit ca891458452752eabe67779a2f39a1898a2dd972
Merge: d2752af 8e8b351
Author: Erik van Pienbroek <epienbro(a)fedoraproject.org>
Date: Thu Apr 28 12:18:16 2011 +0200
Merge branch 'master' into f15
mingw32-glib2.spec | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
---
12 years, 11 months
[mingw32-glib2] Own the folders %{_mingw32_libdir}/gio and %{_mingw32_libdir}/gio/modules
by Erik van Pienbroek
commit 8e8b351bbb0a3849d4ba143bd25cecdebe158485
Author: Erik van Pienbroek <epienbro(a)fedoraproject.org>
Date: Thu Apr 28 12:07:14 2011 +0200
Own the folders %{_mingw32_libdir}/gio and %{_mingw32_libdir}/gio/modules
- Own the folders %{_mingw32_libdir}/gio and %{_mingw32_libdir}/gio/modules
- Dropped the .def files as they aren't useful for other binaries
mingw32-glib2.spec | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
---
diff --git a/mingw32-glib2.spec b/mingw32-glib2.spec
index 33257dc..81aea75 100644
--- a/mingw32-glib2.spec
+++ b/mingw32-glib2.spec
@@ -7,7 +7,7 @@
Name: mingw32-glib2
Version: 2.28.6
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: MinGW Windows GLib2 library
License: LGPLv2+
@@ -135,6 +135,9 @@ rm -rf $RPM_BUILD_ROOT%{_mingw32_datadir}/gtk-doc
# Bash-completion files aren't interesting for mingw32
rm -rf $RPM_BUILD_ROOT%{_mingw32_sysconfdir}/bash_completion.d
+# The .def files are also of no use to other binaries
+rm -f $RPM_BUILD_ROOT%{_mingw32_libdir}/*.def
+
%find_lang glib20
@@ -161,12 +164,9 @@ rm -rf $RPM_BUILD_ROOT
%{_mingw32_bindir}/libgthread-2.0-0.dll
%{_mingw32_includedir}/glib-2.0/
%{_mingw32_includedir}/gio-win32-2.0/
-%{_mingw32_libdir}/gio-2.0.def
-%{_mingw32_libdir}/glib-2.0.def
%{_mingw32_libdir}/glib-2.0/
-%{_mingw32_libdir}/gmodule-2.0.def
-%{_mingw32_libdir}/gobject-2.0.def
-%{_mingw32_libdir}/gthread-2.0.def
+%dir %{_mingw32_libdir}/gio/
+%dir %{_mingw32_libdir}/gio/modules/
%{_mingw32_libdir}/libgio-2.0.dll.a
%{_mingw32_libdir}/libgio-2.0.la
%{_mingw32_libdir}/libglib-2.0.dll.a
@@ -200,6 +200,10 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Thu Apr 28 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 2.28.6-3
+- Own the folders %%{_mingw32_libdir}/gio and %%{_mingw32_libdir}/gio/modules
+- Dropped the .def files as they aren't useful for other binaries
+
* Wed Apr 27 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 2.28.6-2
- Dropped the proxy-libintl pieces
12 years, 11 months