mingw June 2011

mingw@lists.fedoraproject.org

11 participants
87 discussions

Start a nNew thread

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 --- Comment #7 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2011-06-02 15:33:52 EDT --- Okay, next round: Spec URL: http://ftd4linux.nl/contrib/mingw-libjpeg-turbo.spec SRPM URL: http://ftd4linux.nl/contrib/mingw-libjpeg-turbo-1.1.1-3.fc15.src.rpm * Thu Jun 2 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 1.1.1-3 - Moved the obsoletes/provides to the right location - Bundle the licence and other %doc's - Fixed a small rpmlint warning -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 --- Comment #6 from Kalev Lember <kalev(a)smartlink.ee> 2011-06-02 15:22:14 EDT --- Fedora review mingw-libjpeg-turbo-1.1.1-2.fc15.src.rpm 2011-06-02 + OK ! needs attention rpmlint output: $ rpmlint mingw32-libjpeg-turbo \ mingw32-libjpeg-turbo-static \ mingw32-libjpeg-turbo-debuginfo \ mingw-libjpeg-turbo-1.1.1-2.fc16.src.rpm mingw32-libjpeg-turbo-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libturbojpeg.a mingw32-libjpeg-turbo-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libjpeg.a mingw32-libjpeg-turbo-static.noarch: W: no-documentation mingw32-libjpeg-turbo-debuginfo.noarch: E: debuginfo-without-sources mingw-libjpeg-turbo.src:94: W: macro-in-comment %{_mingw32_libdir} mingw-libjpeg-turbo.src:96: W: macro-in-comment %{_mingw32_libdir} 4 packages and 0 specfiles checked; 3 errors, 3 warnings. ! rpmlint doesn't like the commented out lines in %files section; I guess these can be safely removed to make rpmlint happy. Other errors and warnings are harmless. + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package ! The package doesn't contain the license files (LICENSE.txt and LGPL.txt) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 03b9c1406c7bfdc204313c2917ce6962 libjpeg-turbo-1.1.1.tar.gz 03b9c1406c7bfdc204313c2917ce6962 Download/libjpeg-turbo-1.1.1.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package + Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 Issues: ! Would be nice to clean up the rpmlint warnings about macro-in-comment. ! License files (LICENSE.txt and LGPL.txt) are not packaged up; I guess the README file that's duplicating native docs can be removed. ! Obsoletes and Provides should be defined for the mingw32- binary subpackage, not for the source package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 679060] Review Request: mingw-antlr - MinGW Windows ANTLR C++ run-time library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679060 --- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> 2011-06-02 15:06:35 EDT --- mingw-antlr-2.7.7-5.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 701112] Review Request: mingw-wxWidgets - C++ cross-platform GUI library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701112 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-wxWidgets-2.8.12-3.fc |mingw-wxWidgets-2.8.12-3.fc |15 |14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 701112] Review Request: mingw-wxWidgets - C++ cross-platform GUI library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701112 --- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> 2011-06-02 14:59:24 EDT --- mingw-wxWidgets-2.8.12-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 --- Comment #5 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2011-06-02 14:44:38 EDT --- I just updated the package to use the CMake based build system as that looks like the most Win32-friendly method to get this package built Spec URL: http://ftd4linux.nl/contrib/mingw-libjpeg-turbo.spec SRPM URL: http://ftd4linux.nl/contrib/mingw-libjpeg-turbo-1.1.1-2.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3106615 * Thu Jun 2 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 1.1.1-2 - Use CMake to build this package as it creates a more mingw-friendly version of the library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 --- Comment #4 from Kalev Lember <kalev(a)smartlink.ee> 2011-06-02 14:26:44 EDT --- I think the CMake build system is there mostly for Windows (it can generate Visual Studio projects) and upstream haven't yet properly tested Windows support with the autotools based build system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 --- Comment #3 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2011-06-02 14:18:00 EDT --- That's really surprising! This would mean that the ABI will be different based on the build system used. I don't know if that's really how upstream has meant this to work.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
by Red Hat Bugzilla 02 Jun '11

02 Jun '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 Kalev Lember <kalev(a)smartlink.ee> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalev(a)smartlink.ee AssignedTo|nobody(a)fedoraproject.org |kalev(a)smartlink.ee Flag| |fedora-review? --- Comment #2 from Kalev Lember <kalev(a)smartlink.ee> 2011-06-02 14:12:46 EDT --- Taking for review. I'm looking at the installed public headers and jmorecfg.h still has: typedef int boolean; This is going to cause trouble because Windows headers (in particular rpcndr.h) define boolean as 'unsigned char'. libjpeg-turbo has two different build systems. In addition to the autotools-based one you've used, there's also a CMake based build system. It would appear that there's at least one important difference for MinGW builds: the cmake build system uses win/jconfig.h.in, which in turn defines: /* Define "boolean" as unsigned char, not int, per Windows custom */ #ifndef __RPCNDR_H__ /* don't conflict if rpcndr.h already read */ typedef unsigned char boolean; #endif #define HAVE_BOOLEAN /* prevent jmorecfg.h from redefining it */ So in the light of this, I can suggest two options: 1) Fix up the autotools build system to also typedef boolean as 'unsigned char' 2) Switch to CMake build system -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

mingw June 2011