[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=820729
--- Comment #5 from Marc-Andre Lureau <marcandre.lureau(a)redhat.com> ---
(In reply to comment #4)
> Please bump the release tag in the .spec file every time you make a change
> instead of replacing the old version. This makes it harder to compare
> revisions
ok, didn't know about that
> I just took a look at the debug issue. It seems to be caused by the fact
> that some RPM variables aren't set automatically as you don't have a %setup
> tag in the %prep section. It is possible to use this tag without having it
> trying to extract source files. You can try to add these lines just after
> the 7za command:
> cd ..
> %setup -q -T -D -n %{name}-%{version}
>
> With this change, some of the 'cd' calls in other sections can be removed as
> they're unneeded
Indeed, works, thanks
>
> In your original .spec file you tried to install the .dll files to libdir
> and name it .dll.a, but that isn't going to work. In your latest .spec file
> you already seem to have resolved this issue and also made it generate an
> import library which is good. Your original .spec file also missed an
> %{?mingw_debug_package} line, but you seem to have added this in your latest
> spec file. Again, please bump the release tag and publish a new .src.rpm
> every time you make a change
hmm, I guess that was an outdated srpm.
Fixed ones uploaded:
http://elmarco.fedorapeople.org/mingw-cximage.spec
http://elmarco.fedorapeople.org/mingw-cximage-600-4.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 10 months
[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=820729
--- Comment #4 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
Please bump the release tag in the .spec file every time you make a change
instead of replacing the old version. This makes it harder to compare revisions
I just took a look at the debug issue. It seems to be caused by the fact that
some RPM variables aren't set automatically as you don't have a %setup tag in
the %prep section. It is possible to use this tag without having it trying to
extract source files. You can try to add these lines just after the 7za
command:
cd ..
%setup -q -T -D -n %{name}-%{version}
With this change, some of the 'cd' calls in other sections can be removed as
they're unneeded
In your original .spec file you tried to install the .dll files to libdir and
name it .dll.a, but that isn't going to work. In your latest .spec file you
already seem to have resolved this issue and also made it generate an import
library which is good. Your original .spec file also missed an
%{?mingw_debug_package} line, but you seem to have added this in your latest
spec file. Again, please bump the release tag and publish a new .src.rpm every
time you make a change
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 10 months
[Bug 823623] Review Request: mingw-libusbx - MinGW library which allows userspace access to USB devices
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823623
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |erik-fedora(a)vanpienbroek.nl
--- Comment #4 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
(In reply to comment #3)
> - Does not own all directories that it creates!
> The mingw32-* and mingw64-* packages install files under
> /usr/i686-w64-mingw32 resp /usr/x86_64-w64-mingw32 And subdirs under these
> dirs which no packages own, therefor the mingw32-* and mingw64-* packages
> should have a Requires on mingw32-filesystem resp mingw64-filesystem. This
> seems to be an oversight in the mingw packaging guidelines which are missing
> these requires in their example specfile too. Can you please discuss this
> with the other mingw packaging folks?
Hi Hans,
The Requires tags for mingw32-filesystem and mingw64-filesystem are added
automatically by the %{?mingw_package_header} macro. This macro overrides the
default RPM find requires script with /usr/lib/rpm/mingw-find-requires.sh which
automatically adds the proper requires tags for mingw packages
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 10 months
[Bug 823623] Review Request: mingw-libusbx - MinGW library which allows userspace access to USB devices
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823623
Hans de Goede <hdegoede(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Hans de Goede <hdegoede(a)redhat.com> ---
Full review done:
Good:
--------
- rpmlint checks return:
mingw32-libusbx-debuginfo.noarch: E: debuginfo-without-sources
mingw32-libusbx-static.noarch: W: no-documentation
mingw64-libusbx-debuginfo.noarch: E: debuginfo-without-sources
mingw64-libusbx-static.noarch: W: no-documentation
^^These are all expected for mingw packages, so no problem here ^^
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales properly handled
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Should fix:
---------------
- rpmlint checks return:
mingw-libusbx.src: W: strange-permission libusbx-1.0.11.tar.bz2 0640L
Please fix before import
- rpmlint checks return:
mingw32-libusbx.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw32-libusbx-1.0.11/ChangeLog
mingw64-libusbx.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw64-libusbx-1.0.11/ChangeLog
The ChangeLog file is not that interesting anyways, it says: "For the latest
change log, please visit:
http://libusbx.git.sourceforge.net/git/gitweb.cgi?p=libusbx/libusbx;a=log"
So I suggest just dropping it.
- There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed with
modern rpm versions, and
should not be there unless you also manually specify a buildroot and have a
manual %clean section
- Does not own all directories that it creates!
The mingw32-* and mingw64-* packages install files under /usr/i686-w64-mingw32
resp /usr/x86_64-w64-mingw32 And subdirs under these dirs which no packages
own, therefor the mingw32-* and mingw64-* packages should have a Requires on
mingw32-filesystem resp mingw64-filesystem. This seems to be an oversight in
the mingw packaging guidelines which are missing these requires in their
example specfile too. Can you please discuss this with the other mingw
packaging folks?
No blockers -> Approved!
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 10 months