[Bug 835686] Review Request: wine-mono - Mono library required for Wine
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=835686
--- Comment #9 from Michael Cronenworth <mike(a)cchtml.com> ---
Even though you are not packaging a traditional MinGW package, you are using
the MinGW toolkit to build it so I feel it should try to follow the MinGW
packaging guidelines.
$ md5sum Downloads/wine-mono-0.0.4.tar.gz
61c5ee49b8847c4dccfdab1fbc0706ae Downloads/wine-mono-0.0.4.tar.gz
$ md5sum rpmbuild/SOURCES/wine-mono-0.0.4.tar.gz
61c5ee49b8847c4dccfdab1fbc0706ae rpmbuild/SOURCES/wine-mono-0.0.4.tar.gz
$ rpmlint rpmbuild/SPECS/wine-mono.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint Downloads/wine-mono-0.0.4-6.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint /home/michael/rpmbuild/RPMS/noarch/wine-mono-0.0.4-6.fc17.noarch.rpm
wine-mono.noarch: E: incorrect-fsf-address
/usr/share/doc/wine-mono-0.0.4/mono-COPYING.LIB
wine-mono.noarch: E: incorrect-fsf-address
/usr/share/doc/wine-mono-0.0.4/mono-mcs-LICENSE.GPL
wine-mono.noarch: E: incorrect-fsf-address
/usr/share/doc/wine-mono-0.0.4/mono-mcs-LICENSE.LGPL
1 packages and 0 specfiles checked; 3 errors, 0 warnings.
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[/] Source package name is prefixed with 'mingw-'
[!] Spec file starts with %{?mingw_package_header}
[!] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[!] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[/] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[/] Spec file contains %{?mingw_debug_package} after the %description section
[/] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
to configure the package
[/] Uses the macro %mingw_make to build the package
[/] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[/] No binary package named mingw-$pkgname is generated
[/] Libtool .la files are not bundled
[/] .def files are not bundled
[/] Man pages which duplicate native package are not bundled
[/] Info files which duplicate native package are not bundled
[/] Provides of the binary mingw32 and mingw64 packages are equal
[/] Requires of the binary mingw32 and mingw64 packages are equal
The incorrect-fsf-address rpmlint warning should be reported upstream.
Please check the items I marked that need looking into before I pass the
review:
-%?mingw_package_header should be %{?mingw_package_header}
-The BRs for the filesystem packages are missing.
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 9 months
[Bug 819670] Review Request: mingw-llvm - MinGW LLVM libraries
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819670
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #12 from Michael Cronenworth <mike(a)cchtml.com> ---
$ md5sum Downloads/llvm-3.0.tar.gz
a8e5f5f1c1adebae7b4a654c376a6005 Downloads/llvm-3.0.tar.gz
$ md5sum rpmbuild/SOURCES/llvm-3.0.tar.gz
a8e5f5f1c1adebae7b4a654c376a6005 rpmbuild/SOURCES/llvm-3.0.tar.gz
$ rpmlint rpmbuild/SPECS/mingw-llvm.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint Downloads/mingw-llvm-3.0-3.fc17.src.rpm
mingw-llvm.src: W: spelling-error %description -l en_US runtime -> run time,
run-time, rudiment
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint /home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm
mingw32-llvm.noarch: W: no-manual-page-for-binary i686-w64-mingw32-llvm-config
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint
/home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-static-3.0-3.fc17.noarch.rpm
mingw32-llvm-static.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpm -qp --requires
/home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm
/usr/bin/perl
mingw32(advapi32.dll)
mingw32(imagehlp.dll)
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libstdc++-6.dll)
mingw32(llvm-3.0.dll)
mingw32(msvcrt.dll)
mingw32(psapi.dll)
mingw32(shell32.dll)
mingw32-crt
mingw32-filesystem >= 83
perl >= 0:5.006
perl(Cwd)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -qp --provides
/home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm
mingw32(bugpointpasses.dll)
mingw32(llvm-3.0.dll)
mingw32(lto.dll)
mingw32-llvm = 3.0-3.fc17
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[/] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[/] Libtool .la files are not bundled
[/] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[/] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
The description and man page rpmlint warnings can be ignored.
The no-documentation rpmlint warnings in the -static subpackage can be ignored
as the documentation is already part of the regular mingw32 package.
However, I could not build your package on my x86_64 F17 system at first. The
configure steps succeed but building fails during the make step:
checking tool compatibility... configure: error: g++|clang++|icc required but
not found
make[1]: Entering directory
`/home/michael/rpmbuild/BUILD/llvm-3.0.src/build_win32/BuildTools'
make[1]: *** No targets specified and no makefile found. Stop.
make[1]: Leaving directory
`/home/michael/rpmbuild/BUILD/llvm-3.0.src/build_win32/BuildTools'
make: *** [cross-compile-build-tools] Error 1
It seems when it runs make it is throwing out all of the MinGW environment
variables and running configure again. I do not have g++ installed on the
system I am reviewing on. After installing it (as a koji buildroot would have
it) building succeeded. You might ask upstream why the "make" process wants
native compilers when we specified a cross-compiler (MinGW) during configure.
In any case it seems to build Windows binaries.
================================================
The package mingw-llvm is APPROVED by mooninite
================================================
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 9 months
[Bug 819670] Review Request: mingw-llvm - MinGW LLVM libraries
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819670
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mike(a)cchtml.com
Assignee|nobody(a)fedoraproject.org |mike(a)cchtml.com
Flags| |fedora-review?
--- Comment #11 from Michael Cronenworth <mike(a)cchtml.com> ---
Taking for review.
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 9 months
Version Discrepancy Report
by Michael Cronenworth
32-bit is at the top and 64-bit is at the bottom.
MinGW 32-bit packages version discrepancies
-------------------------------------------
Fedora N Matches Found: 31
Fedora Rawhide Matches Found: 50
+-------------------------------+
| f17 | rawhide |
+-------------------------+---------------+---------------+
| atk | | 2.5.3 |
| mingw32-atk | | 2.4.0 |
+-------------------------+---------------+---------------+
| binutils | 2.22.52.0.1 | 2.22.52.0.4 |
| mingw32-binutils | 2.22.52 | 2.22.52.0.3 |
+-------------------------+---------------+---------------+
| cairo | | 1.12.2 |
| mingw32-cairo | | 1.10.2 |
+-------------------------+---------------+---------------+
| cpp | | 4.7.1 |
| mingw32-cpp | | 4.7.0 |
+-------------------------+---------------+---------------+
| curl | 7.24.0 | 7.26.0 |
| mingw32-curl | 7.25.0 | 7.25.0 |
+-------------------------+---------------+---------------+
| dbus | 1.4.10 | 1.6.0 |
| mingw32-dbus | 1.4.16 | 1.4.16 |
+-------------------------+---------------+---------------+
| fontconfig | | 2.9.92 |
| mingw32-fontconfig | | 2.9.0 |
+-------------------------+---------------+---------------+
| freetype | | 2.4.9 |
| mingw32-freetype | | 2.4.8 |
+-------------------------+---------------+---------------+
| gcc | | 4.7.1 |
| mingw32-gcc | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-c++ | | 4.7.1 |
| mingw32-gcc-c++ | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-gfortran | | 4.7.1 |
| mingw32-gcc-gfortran | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-objc | | 4.7.1 |
| mingw32-gcc-objc | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-objc++ | | 4.7.1 |
| mingw32-gcc-objc++ | | 4.7.0 |
+-------------------------+---------------+---------------+
| gdbm | 1.10 | 1.10 |
| mingw32-gdbm | 1.8.0 | 1.8.0 |
+-------------------------+---------------+---------------+
| glib-networking | 2.32.3 | 2.33.3 |
| mingw32-glib-networking | 2.32.1 | 2.32.1 |
+-------------------------+---------------+---------------+
| glib2 | 2.32.3 | 2.33.3 |
| mingw32-glib2 | 2.32.2 | 2.33.1 |
+-------------------------+---------------+---------------+
| glibmm24 | | 2.33.2 |
| mingw32-glibmm24 | | 2.32.0 |
+-------------------------+---------------+---------------+
| gtk3 | 3.4.3 | 3.5.6 |
| mingw32-gtk3 | 3.4.2 | 3.4.2 |
+-------------------------+---------------+---------------+
| gtkhtml3 | 4.4.3 | 4.5.3 |
| mingw32-gtkhtml3 | 4.4.0 | 4.4.0 |
+-------------------------+---------------+---------------+
| gtkmm30 | | 3.5.4 |
| mingw32-gtkmm30 | | 3.4.0 |
+-------------------------+---------------+---------------+
| gtksourceview3 | 3.4.2 | 3.4.2 |
| mingw32-gtksourceview3 | 3.4.1 | 3.4.1 |
+-------------------------+---------------+---------------+
| icu | | 49.1.1 |
| mingw32-icu | | 4.8.1.1 |
+-------------------------+---------------+---------------+
| libffi | 3.0.10 | 3.0.10 |
| mingw32-libffi | 3.0.11 | 3.0.11 |
+-------------------------+---------------+---------------+
| libgeotiff | 1.2.5 | 1.2.5 |
| mingw32-libgeotiff | 1.3.0 | 1.3.0 |
+-------------------------+---------------+---------------+
| libgomp | | 4.7.1 |
| mingw32-libgomp | | 4.7.0 |
+-------------------------+---------------+---------------+
| libidn | 1.24 | 1.25 |
| mingw32-libidn | 1.14 | 1.14 |
+-------------------------+---------------+---------------+
| libjpeg-turbo | 1.2.0 | 1.2.0 |
| mingw32-libjpeg-turbo | 1.1.1 | 1.1.1 |
+-------------------------+---------------+---------------+
| libpng | 1.5.10 | 1.5.10 |
| mingw32-libpng | 1.5.7 | 1.5.7 |
+-------------------------+---------------+---------------+
| libsigsegv | 2.10 | 2.10 |
| mingw32-libsigsegv | 2.6 | 2.6 |
+-------------------------+---------------+---------------+
| libsoup | | 2.39.3 |
| mingw32-libsoup | | 2.38.1 |
+-------------------------+---------------+---------------+
| libssh2 | 1.4.1 | 1.4.2 |
| mingw32-libssh2 | 1.1 | 1.1 |
+-------------------------+---------------+---------------+
| libtasn1 | | 2.13 |
| mingw32-libtasn1 | | 2.12 |
+-------------------------+---------------+---------------+
| libtiff | | 4.0.2 |
| mingw32-libtiff | | 3.9.5 |
+-------------------------+---------------+---------------+
| libvirt | 0.9.11.4 | 0.9.12 |
| mingw32-libvirt | 0.9.11 | 0.9.11 |
+-------------------------+---------------+---------------+
| libvorbis | 1.3.3 | 1.3.3 |
| mingw32-libvorbis | 1.3.2 | 1.3.2 |
+-------------------------+---------------+---------------+
| libzip | 0.10.1 | 0.10.1 |
| mingw32-libzip | 0.9 | 0.9 |
+-------------------------+---------------+---------------+
| matahari | 0.6.0 | 0.6.0 |
| mingw32-matahari | 0.5.0 | 0.5.0 |
+-------------------------+---------------+---------------+
| minizip | | 1.2.7 |
| mingw32-minizip | | 1.2.5 |
+-------------------------+---------------+---------------+
| openjpeg | 1.4 | 1.5.0 |
| mingw32-openjpeg | 1.3 | 1.3 |
+-------------------------+---------------+---------------+
| openssl | 1.0.0j | 1.0.1c |
| mingw32-openssl | 1.0.0d | 1.0.0d |
+-------------------------+---------------+---------------+
| pango | | 1.30.1 |
| mingw32-pango | | 1.30.0 |
+-------------------------+---------------+---------------+
| pcre | 8.21 | 8.31 |
| mingw32-pcre | 8.30 | 8.30 |
+-------------------------+---------------+---------------+
| pixman | | 0.26.0 |
| mingw32-pixman | | 0.24.4 |
+-------------------------+---------------+---------------+
| proj | 4.7.0 | 4.8.0 |
| mingw32-proj | 4.6.1 | 4.6.1 |
+-------------------------+---------------+---------------+
| qwt | 5.2.2 | 5.2.2 |
| mingw32-qwt | 5.2.1 | 5.2.1 |
+-------------------------+---------------+---------------+
| readline | 6.2 | 6.2 |
| mingw32-readline | 5.2 | 5.2 |
+-------------------------+---------------+---------------+
| sqlite | 3.7.11 | 3.7.13 |
| mingw32-sqlite | 3.7.9 | 3.7.9 |
+-------------------------+---------------+---------------+
| tk | 8.5.11 | 8.5.11 |
| mingw32-tk | 8.5.9 | 8.5.9 |
+-------------------------+---------------+---------------+
| webkitgtk3 | | 1.9.3 |
| mingw32-webkitgtk3 | | 1.8.1 |
+-------------------------+---------------+---------------+
| zlib | | 1.2.7 |
| mingw32-zlib | | 1.2.5 |
+-------------------------+---------------+---------------+
MinGW 64-bit packages version discrepancies
-------------------------------------------
Fedora N Matches Found: 22
Fedora Rawhide Matches Found: 41
+-------------------------------+
| f17 | rawhide |
+-------------------------+---------------+---------------+
| atk | | 2.5.3 |
| mingw64-atk | | 2.4.0 |
+-------------------------+---------------+---------------+
| binutils | 2.22.52.0.1 | 2.22.52.0.4 |
| mingw64-binutils | 2.22.52 | 2.22.52.0.3 |
+-------------------------+---------------+---------------+
| cairo | | 1.12.2 |
| mingw64-cairo | | 1.10.2 |
+-------------------------+---------------+---------------+
| cpp | | 4.7.1 |
| mingw64-cpp | | 4.7.0 |
+-------------------------+---------------+---------------+
| curl | 7.24.0 | 7.26.0 |
| mingw64-curl | 7.25.0 | 7.25.0 |
+-------------------------+---------------+---------------+
| dbus | 1.4.10 | 1.6.0 |
| mingw64-dbus | 1.4.16 | 1.4.16 |
+-------------------------+---------------+---------------+
| fontconfig | | 2.9.92 |
| mingw64-fontconfig | | 2.9.0 |
+-------------------------+---------------+---------------+
| freetype | | 2.4.9 |
| mingw64-freetype | | 2.4.8 |
+-------------------------+---------------+---------------+
| gcc | | 4.7.1 |
| mingw64-gcc | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-c++ | | 4.7.1 |
| mingw64-gcc-c++ | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-gfortran | | 4.7.1 |
| mingw64-gcc-gfortran | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-objc | | 4.7.1 |
| mingw64-gcc-objc | | 4.7.0 |
+-------------------------+---------------+---------------+
| gcc-objc++ | | 4.7.1 |
| mingw64-gcc-objc++ | | 4.7.0 |
+-------------------------+---------------+---------------+
| glib-networking | 2.32.3 | 2.33.3 |
| mingw64-glib-networking | 2.32.1 | 2.32.1 |
+-------------------------+---------------+---------------+
| glib2 | 2.32.3 | 2.33.3 |
| mingw64-glib2 | 2.32.2 | 2.33.1 |
+-------------------------+---------------+---------------+
| glibmm24 | | 2.33.2 |
| mingw64-glibmm24 | | 2.32.0 |
+-------------------------+---------------+---------------+
| gtk3 | 3.4.3 | 3.5.6 |
| mingw64-gtk3 | 3.4.2 | 3.4.2 |
+-------------------------+---------------+---------------+
| gtkhtml3 | 4.4.3 | 4.5.3 |
| mingw64-gtkhtml3 | 4.4.0 | 4.4.0 |
+-------------------------+---------------+---------------+
| gtkmm30 | | 3.5.4 |
| mingw64-gtkmm30 | | 3.4.0 |
+-------------------------+---------------+---------------+
| gtksourceview3 | 3.4.2 | 3.4.2 |
| mingw64-gtksourceview3 | 3.4.1 | 3.4.1 |
+-------------------------+---------------+---------------+
| icu | | 49.1.1 |
| mingw64-icu | | 4.8.1.1 |
+-------------------------+---------------+---------------+
| libffi | 3.0.10 | 3.0.10 |
| mingw64-libffi | 3.0.11 | 3.0.11 |
+-------------------------+---------------+---------------+
| libgomp | | 4.7.1 |
| mingw64-libgomp | | 4.7.0 |
+-------------------------+---------------+---------------+
| libidn | 1.24 | 1.25 |
| mingw64-libidn | 1.14 | 1.14 |
+-------------------------+---------------+---------------+
| libjpeg-turbo | 1.2.0 | 1.2.0 |
| mingw64-libjpeg-turbo | 1.1.1 | 1.1.1 |
+-------------------------+---------------+---------------+
| libpng | 1.5.10 | 1.5.10 |
| mingw64-libpng | 1.5.7 | 1.5.7 |
+-------------------------+---------------+---------------+
| libsoup | | 2.39.3 |
| mingw64-libsoup | | 2.38.1 |
+-------------------------+---------------+---------------+
| libssh2 | 1.4.1 | 1.4.2 |
| mingw64-libssh2 | 1.1 | 1.1 |
+-------------------------+---------------+---------------+
| libtasn1 | | 2.13 |
| mingw64-libtasn1 | | 2.12 |
+-------------------------+---------------+---------------+
| libtiff | | 4.0.2 |
| mingw64-libtiff | | 3.9.5 |
+-------------------------+---------------+---------------+
| libvirt | 0.9.11.4 | 0.9.13 |
| mingw64-libvirt | 0.9.11 | 0.9.11 |
+-------------------------+---------------+---------------+
| libvorbis | 1.3.3 | 1.3.3 |
| mingw64-libvorbis | 1.3.2 | 1.3.2 |
+-------------------------+---------------+---------------+
| minizip | | 1.2.7 |
| mingw64-minizip | | 1.2.5 |
+-------------------------+---------------+---------------+
| openssl | 1.0.0j | 1.0.1c |
| mingw64-openssl | 1.0.0d | 1.0.0d |
+-------------------------+---------------+---------------+
| pango | | 1.30.1 |
| mingw64-pango | | 1.30.0 |
+-------------------------+---------------+---------------+
| pcre | 8.21 | 8.31 |
| mingw64-pcre | 8.30 | 8.30 |
+-------------------------+---------------+---------------+
| pixman | | 0.26.0 |
| mingw64-pixman | | 0.24.4 |
+-------------------------+---------------+---------------+
| readline | 6.2 | 6.2 |
| mingw64-readline | 5.2 | 5.2 |
+-------------------------+---------------+---------------+
| sqlite | 3.7.11 | 3.7.13 |
| mingw64-sqlite | 3.7.9 | 3.7.9 |
+-------------------------+---------------+---------------+
| webkitgtk3 | | 1.9.3 |
| mingw64-webkitgtk3 | | 1.8.1 |
+-------------------------+---------------+---------------+
| zlib | | 1.2.7 |
| mingw64-zlib | | 1.2.5 |
+-------------------------+---------------+---------------+
11 years, 9 months